Update Pinned CI Packages #11586

scbedd · 2020-05-21T19:14:09Z

This introduces new pylint failures.

Need to get these resolved before merge.

EDIT 7/8: Updated with latest master (including virtualenv pins)

chlowell · 2020-05-21T22:23:21Z

I see a new exception in pylint_guidelines_checker.py when analyzing azure-keyvault-keys:

Traceback (most recent call last):
  ...
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\__main__.py", line 18, in <module>
    pylint.run_pylint()
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\__init__.py", line 22, in run_pylint
    PylintRun(sys.argv[1:])
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\lint\run.py", line 344, in __init__
    linter.check(args)
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\lint\pylinter.py", line 871, in check
    self.get_ast, self._iterate_file_descrs(files_or_modules)
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\lint\pylinter.py", line 904, in _check_files
    self._check_file(get_ast, check_astroid_module, name, filepath, modname)
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\lint\pylinter.py", line 930, in _check_file
    check_astroid_module(ast_node)
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\lint\pylinter.py", line 1063, in check_astroid_module
    ast_node, walker, rawcheckers, tokencheckers
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\lint\pylinter.py", line 1107, in _check_astroid_module
    walker.walk(ast_node)
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\utils\ast_walker.py", line 75, in walk
    self.walk(child)
  File "azure-keyvault-keys\.tox\lint\lib\site-packages\pylint\utils\ast_walker.py", line 72, in walk
    callback(astroid)
  File "azure-sdk-for-python\scripts\pylint_custom_plugin\pylint_guidelines_checker.py", line 547, in visit_classdef
    msg_id="client-incorrect-naming-convention", node=node, confidence=None
TypeError: add_message() got an unexpected keyword argument 'msg_id'

kristapratico · 2020-05-26T15:44:21Z

I see a new exception in pylint_guidelines_checker.py when analyzing azure-keyvault-keys:

This sounds like my fault. I'll look into what changed with the custom checkers for the newer version of pylint.

kristapratico · 2020-05-26T17:49:44Z

@chlowell pushed a commit fixing that error, you should be unblocked now.

chlowell · 2020-05-26T20:06:52Z

Thanks @kristapratico, that appears to have worked.

I pushed a couple commits, one to address warnings in azure-keyvaut-keys and azure-identity, and one to disable the import-outside-toplevel rule.

…n into may-dep-update

azure-pipelines · 2020-07-08T22:00:33Z

Azure Pipelines successfully started running 1 pipeline(s).

scbedd · 2020-07-08T22:02:03Z

/azp run python - servicebus - ci

azure-pipelines · 2020-07-08T22:02:09Z

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

…dMessage does not violate pylint by overriding sync with async methods. Now the sync-specific/async-specific versions imply implement their respective settlement methods, with the shared scaffolding in base.

KieranBrantnerMagee · 2020-07-10T19:27:53Z

/azp run python - servicebus - tests

azure-pipelines · 2020-07-10T19:28:02Z

Azure Pipelines successfully started running 1 pipeline(s).

…or-python into may-dep-update

KieranBrantnerMagee · 2020-07-13T04:47:31Z

/azp run python - servicebus - tests

azure-pipelines · 2020-07-13T04:48:17Z

Azure Pipelines failed to run 1 pipeline(s).

KieranBrantnerMagee · 2020-07-13T19:47:05Z

/azp run python - servicebus - tests

azure-pipelines · 2020-07-13T19:47:14Z

Azure Pipelines successfully started running 1 pipeline(s).

…ialPolicy. In the mid-term we need to deprecate the Async versions of this policy and credential to unify on a single model in the primary namespace, see issue here: #12533

…wait.

…or-python into may-dep-update

praveenkuttappan · 2020-07-14T23:11:49Z

eng/test_tools.txt

 pylint==1.8.4; python_version < '3.4'
-astroid==2.3.3; python_version >= '3.4'


This is intentional to install latest version of astroid that is required by pylint. right?

sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_internal/algorithms/aes_cbc.py

rakshith91 · 2020-07-15T23:25:11Z

sdk/storage/azure-storage-blob/azure/storage/blob/aio/_blob_service_client_async.py

@@ -3,7 +3,7 @@
 # Licensed under the MIT License. See License.txt in the project root for
 # license information.
 # --------------------------------------------------------------------------
-
+# pylint: disable=invalid-overridden-method


This does not solve the purpose. We must create a common base class for sync and async and inherit both the clients from the base class.

class BlobServiceClientBase(): class BlobServiceClient(BlobServiceClientBase): again in ./aio class BlobServiceClient(BlobServiceClientBase):

The mypy pr is already doing this, I think we can reuse that one
Also this problem happened for upload, download, policies, I don't think we need to create a base and inherit for sync and async for all cases.

…into regenerate_keys * 'master' of https://github.com/Azure/azure-sdk-for-python: (100 commits) replace aka link (Azure#12597) [ServiceBus] Message/ReceivedMessage Properties alignment with other languages (Azure#12451) Find list of installed packages using pkg_resources (Azure#12591) token refresh offset (Azure#12136) updates (Azure#12595) User authentication samples (Azure#11343) Remove unnecessary base class (Azure#12374) Sequence -> Iterable for scopes (Azure#12579) Disable apistubgen step until issue is fixed (Azure#12594) fix pylint issue (Azure#12578) fix name in example (Azure#12572) Update tests.md (Azure#12574) Add stress tests for max batch size/prefetch, and for unsettled message receipt. Add capability to not auto-complete and adjust max_batch_size into the base stress tester. (Azure#12344) [formrecognizer] Capitalize enum values (Azure#12540) Update Pinned CI Packages (Azure#11586) remove async response hook policy (Azure#12529) update to target new warden version (Azure#12522) fix azure-storage-blob readme and samples issues (Azure#12511) code fence not formatted appropriately (Azure#12520) Fix documentation typo (Azure#12519) ...

…into regenerate_certs * 'master' of https://github.com/Azure/azure-sdk-for-python: (100 commits) replace aka link (Azure#12597) [ServiceBus] Message/ReceivedMessage Properties alignment with other languages (Azure#12451) Find list of installed packages using pkg_resources (Azure#12591) token refresh offset (Azure#12136) updates (Azure#12595) User authentication samples (Azure#11343) Remove unnecessary base class (Azure#12374) Sequence -> Iterable for scopes (Azure#12579) Disable apistubgen step until issue is fixed (Azure#12594) fix pylint issue (Azure#12578) fix name in example (Azure#12572) Update tests.md (Azure#12574) Add stress tests for max batch size/prefetch, and for unsettled message receipt. Add capability to not auto-complete and adjust max_batch_size into the base stress tester. (Azure#12344) [formrecognizer] Capitalize enum values (Azure#12540) Update Pinned CI Packages (Azure#11586) remove async response hook policy (Azure#12529) update to target new warden version (Azure#12522) fix azure-storage-blob readme and samples issues (Azure#12511) code fence not formatted appropriately (Azure#12520) Fix documentation typo (Azure#12519) ...

…into regenerate_secrets * 'master' of https://github.com/Azure/azure-sdk-for-python: (96 commits) replace aka link (Azure#12597) [ServiceBus] Message/ReceivedMessage Properties alignment with other languages (Azure#12451) Find list of installed packages using pkg_resources (Azure#12591) token refresh offset (Azure#12136) updates (Azure#12595) User authentication samples (Azure#11343) Remove unnecessary base class (Azure#12374) Sequence -> Iterable for scopes (Azure#12579) Disable apistubgen step until issue is fixed (Azure#12594) fix pylint issue (Azure#12578) fix name in example (Azure#12572) Update tests.md (Azure#12574) Add stress tests for max batch size/prefetch, and for unsettled message receipt. Add capability to not auto-complete and adjust max_batch_size into the base stress tester. (Azure#12344) [formrecognizer] Capitalize enum values (Azure#12540) Update Pinned CI Packages (Azure#11586) remove async response hook policy (Azure#12529) update to target new warden version (Azure#12522) fix azure-storage-blob readme and samples issues (Azure#12511) code fence not formatted appropriately (Azure#12520) Fix documentation typo (Azure#12519) ...

update deps appropriately

853149a

scbedd requested review from danieljurek, mitchdenny and weshaggard as code owners May 21, 2020 19:14

fix custom checkers - rename msg_id -> msgid

ca1d3d7

kristapratico mentioned this pull request May 26, 2020

[pylint checker] Investigate add_message failure with newer versions of pylint/astroid #10453

Closed

pylint updates for text analytics and form recognizer

1e57ff8

scbedd requested review from iscai-msft and kristapratico as code owners May 26, 2020 18:20

chlowell added 2 commits May 26, 2020 13:01

pylint updates for azure-identity and azure-keyvault-keys

29dc610

disable import-outside-toplevel

2e8b865

scbedd requested review from chlowell and schaabs as code owners May 26, 2020 20:06

chlowell mentioned this pull request May 26, 2020

SharedTokenCacheCredential takes an optional AuthenticationRecord #11637

Merged

Pylint for azure-core

2870fd0

scbedd requested review from lmazuel, xiangyan99 and zikalino as code owners May 27, 2020 17:34

lmazuel and others added 3 commits May 27, 2020 12:03

Mypy + pylint are friends

ef19556

Fix errors for pylint 2.5.2

ed68752

Merge branch 'may-dep-update' of github.com:Azure/azure-sdk-for-pytho…

7a28a35

…n into may-dep-update

scbedd requested review from annatisch, YijunXieMS and yunhaoling as code owners May 27, 2020 19:25

scbedd and others added 2 commits May 27, 2020 17:36

Merge branch 'master' into may-dep-update

b66fd1b

resolve conflicts

aee0753

scbedd and others added 2 commits July 10, 2020 10:55

Merge branch 'master' into may-dep-update

a51a22b

Refactor ReceivedMessageBase off such that the AIO version of Receive…

53bb229

…dMessage does not violate pylint by overriding sync with async methods. Now the sync-specific/async-specific versions imply implement their respective settlement methods, with the shared scaffolding in base.

Merge branch 'may-dep-update' of https://github.com/Azure/azure-sdk-f…

795bd20

…or-python into may-dep-update

scbedd requested a review from KieranBrantnerMagee as a code owner July 13, 2020 04:46

KieranBrantnerMagee and others added 3 commits July 13, 2020 19:52

Temporarily disable pylint checks for AsyncServiceBusSharedKeyCredent…

5d744cd

…ialPolicy. In the mid-term we need to deprecate the Async versions of this policy and credential to unify on a single model in the primary namespace, see issue here: #12533

Fix deferred settlement tests by reverting the mgmt link settlement a…

ccdfacb

…wait.

[Storage][Pylint]Fix Pylint

03466a7

scbedd requested review from amishra-dev, rakshith91, xiafu-msft and zezha-msft as code owners July 14, 2020 21:17

scbedd and others added 3 commits July 14, 2020 14:27

resolve conflicts

e4f9736

Merge branch 'may-dep-update' of https://github.com/Azure/azure-sdk-f…

55ecbe1

…or-python into may-dep-update

Merge branch 'master' into may-dep-update

f8b7a2b

praveenkuttappan approved these changes Jul 14, 2020

View reviewed changes

scbedd merged commit 0f9c3be into master Jul 14, 2020

scbedd deleted the may-dep-update branch July 14, 2020 23:25

rakshith91 reviewed Jul 15, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Pinned CI Packages #11586

Update Pinned CI Packages #11586

scbedd commented May 21, 2020 •

edited

Loading

chlowell commented May 21, 2020

kristapratico commented May 26, 2020

kristapratico commented May 26, 2020

chlowell commented May 26, 2020

azure-pipelines bot commented Jul 8, 2020

scbedd commented Jul 8, 2020

azure-pipelines bot commented Jul 8, 2020

KieranBrantnerMagee commented Jul 10, 2020

azure-pipelines bot commented Jul 10, 2020

KieranBrantnerMagee commented Jul 13, 2020

azure-pipelines bot commented Jul 13, 2020

KieranBrantnerMagee commented Jul 13, 2020

azure-pipelines bot commented Jul 13, 2020

praveenkuttappan Jul 14, 2020

rakshith91 Jul 15, 2020

xiafu-msft Jul 15, 2020

		pylint==1.8.4; python_version < '3.4'
		astroid==2.3.3; python_version >= '3.4'

Update Pinned CI Packages #11586

Update Pinned CI Packages #11586

Conversation

scbedd commented May 21, 2020 • edited Loading

chlowell commented May 21, 2020

kristapratico commented May 26, 2020

kristapratico commented May 26, 2020

chlowell commented May 26, 2020

azure-pipelines bot commented Jul 8, 2020

scbedd commented Jul 8, 2020

azure-pipelines bot commented Jul 8, 2020

KieranBrantnerMagee commented Jul 10, 2020

azure-pipelines bot commented Jul 10, 2020

KieranBrantnerMagee commented Jul 13, 2020

azure-pipelines bot commented Jul 13, 2020

KieranBrantnerMagee commented Jul 13, 2020

azure-pipelines bot commented Jul 13, 2020

praveenkuttappan Jul 14, 2020

Choose a reason for hiding this comment

rakshith91 Jul 15, 2020

Choose a reason for hiding this comment

xiafu-msft Jul 15, 2020

Choose a reason for hiding this comment

scbedd commented May 21, 2020 •

edited

Loading