Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ServiceBus - Track2 - Deprecate AsyncServiceBusSharedKeyCredentialPolicy and Credential #12533

Closed
KieranBrantnerMagee opened this issue Jul 14, 2020 · 1 comment
Closed

ServiceBus - Track2 - Deprecate AsyncServiceBusSharedKeyCredentialPolicy and Credential #12533

KieranBrantnerMagee opened this issue Jul 14, 2020 · 1 comment
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Milestone
Backlog

Comments

@KieranBrantnerMagee
Copy link
Member

Currently there are both sync and async implementations of this policy and credential.

Per python SDK guidelines, we should unify on a single shared model in the primary (non aio) namespace.
@KieranBrantnerMagee KieranBrantnerMagee added Service Bus Client This issue points to a problem in the data-plane of the library. labels Jul 14, 2020
@KieranBrantnerMagee KieranBrantnerMagee added this to the Backlog milestone Jul 14, 2020
KieranBrantnerMagee added a commit that referenced this issue Jul 14, 2020
@KieranBrantnerMagee
Temporarily disable pylint checks for AsyncServiceBusSharedKeyCredent…
5d744cd 
…ialPolicy.

In the mid-term we need to deprecate the Async versions of this policy and credential to unify on a single model in the primary namespace, see issue here: #12533
scbedd added a commit that referenced this issue Jul 14, 2020
@scbedd @kristapratico
@chlowell @lmazuel @KieranBrantnerMagee @xiafu-msft
Update Pinned CI Packages (#11586)
0f9c3be 
* update pinned CI deps

* fix custom checkers - rename msg_id -> msgid

* pylint updates for text analytics and form recognizer

* pylint updates for azure-identity and azure-keyvault-keys

* disable import-outside-toplevel

* Pylint for azure-core

* Mypy + pylint are friends

* Fix errors for pylint 2.5.2

* disable azure-identity warnings

* Refactor ReceivedMessageBase off such that the AIO version of ReceivedMessage does not violate pylint by overriding sync with async methods.  Now the sync-specific/async-specific versions imply implement their respective settlement methods, with the shared scaffolding in base.

* Temporarily disable pylint checks for AsyncServiceBusSharedKeyCredentialPolicy.
In the mid-term we need to deprecate the Async versions of this policy and credential to unify on a single model in the primary namespace, see issue here: #12533

* Fix deferred settlement tests by reverting the mgmt link settlement await.

* [Storage][Pylint]Fix Pylint

* resolve conflicts

Co-authored-by: Krista Pratico <[email protected]>
Co-authored-by: Charles Lowell <[email protected]>
Co-authored-by: Laurent Mazuel <[email protected]>
Co-authored-by: yijxie <[email protected]>
Co-authored-by: Kieran Brantner-Magee <[email protected]>
Co-authored-by: xiafu <[email protected]>
@KieranBrantnerMagee
Copy link
Member Author

Closing as no longer needed, credential must be async for async client, merging only applies to sync-only.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jan 22, 2021
CodeGen from PR 12533 in Azure/azure-rest-api-specs
864a98d 
Add format for integer type to fix linter validation (Azure#12533)

Co-authored-by: Chenglong Liu <[email protected]>
nffdiogosilva pushed a commit to nffdiogosilva/azure-core that referenced this issue Oct 17, 2022
@scbedd @kristapratico
@chlowell @lmazuel @KieranBrantnerMagee @xiafu-msft
Update Pinned CI Packages (#11586)
23a1ed4 
* update pinned CI deps

* fix custom checkers - rename msg_id -> msgid

* pylint updates for text analytics and form recognizer

* pylint updates for azure-identity and azure-keyvault-keys

* disable import-outside-toplevel

* Pylint for azure-core

* Mypy + pylint are friends

* Fix errors for pylint 2.5.2

* disable azure-identity warnings

* Refactor ReceivedMessageBase off such that the AIO version of ReceivedMessage does not violate pylint by overriding sync with async methods.  Now the sync-specific/async-specific versions imply implement their respective settlement methods, with the shared scaffolding in base.

* Temporarily disable pylint checks for AsyncServiceBusSharedKeyCredentialPolicy.
In the mid-term we need to deprecate the Async versions of this policy and credential to unify on a single model in the primary namespace, see issue here: Azure/azure-sdk-for-python#12533

* Fix deferred settlement tests by reverting the mgmt link settlement await.

* [Storage][Pylint]Fix Pylint

* resolve conflicts

Co-authored-by: Krista Pratico <[email protected]>
Co-authored-by: Charles Lowell <[email protected]>
Co-authored-by: Laurent Mazuel <[email protected]>
Co-authored-by: yijxie <[email protected]>
Co-authored-by: Kieran Brantner-Magee <[email protected]>
Co-authored-by: xiafu <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@KieranBrantnerMagee