Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[formrecognizer] Capitalize enum values #12540

Merged
merged 2 commits into from
Jul 15, 2020
Merged

[formrecognizer] Capitalize enum values #12540

merged 2 commits into from
Jul 15, 2020

Conversation

kristapratico
Copy link
Member

@kristapratico kristapratico commented Jul 14, 2020 •
edited
Loading

Autorest now generates with all uppercase enum values. Per discussion with @iscai-msft, this is more pythonic naming convention.

@kristapratico kristapratico added Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer labels Jul 14, 2020
@kristapratico kristapratico requested a review from iscai-msft July 14, 2020 21:15
@kristapratico kristapratico self-assigned this Jul 14, 2020
@kristapratico kristapratico merged commit 27a8578 into Azure:master Jul 15, 2020
@kristapratico kristapratico deleted the cap-enums branch July 15, 2020 20:33
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jul 20, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
00dfbc9 
…into regenerate_keys

* 'master' of https://github.com/Azure/azure-sdk-for-python: (100 commits)
  replace aka link (Azure#12597)
  [ServiceBus] Message/ReceivedMessage Properties alignment with other languages (Azure#12451)
  Find list of installed packages using pkg_resources (Azure#12591)
  token refresh offset (Azure#12136)
  updates (Azure#12595)
  User authentication samples (Azure#11343)
  Remove unnecessary base class (Azure#12374)
  Sequence -> Iterable for scopes (Azure#12579)
  Disable apistubgen step until issue is fixed (Azure#12594)
  fix pylint issue (Azure#12578)
  fix name in example (Azure#12572)
  Update tests.md (Azure#12574)
  Add stress tests for max batch size/prefetch, and for unsettled message receipt.  Add capability to not auto-complete and adjust max_batch_size into the base stress tester. (Azure#12344)
  [formrecognizer] Capitalize enum values (Azure#12540)
  Update Pinned CI Packages (Azure#11586)
  remove async response hook policy (Azure#12529)
  update to target new warden version (Azure#12522)
  fix azure-storage-blob readme and samples issues (Azure#12511)
  code fence not formatted appropriately (Azure#12520)
  Fix documentation typo (Azure#12519)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jul 20, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
ad8a18d 
…into regenerate_certs

* 'master' of https://github.com/Azure/azure-sdk-for-python: (100 commits)
  replace aka link (Azure#12597)
  [ServiceBus] Message/ReceivedMessage Properties alignment with other languages (Azure#12451)
  Find list of installed packages using pkg_resources (Azure#12591)
  token refresh offset (Azure#12136)
  updates (Azure#12595)
  User authentication samples (Azure#11343)
  Remove unnecessary base class (Azure#12374)
  Sequence -> Iterable for scopes (Azure#12579)
  Disable apistubgen step until issue is fixed (Azure#12594)
  fix pylint issue (Azure#12578)
  fix name in example (Azure#12572)
  Update tests.md (Azure#12574)
  Add stress tests for max batch size/prefetch, and for unsettled message receipt.  Add capability to not auto-complete and adjust max_batch_size into the base stress tester. (Azure#12344)
  [formrecognizer] Capitalize enum values (Azure#12540)
  Update Pinned CI Packages (Azure#11586)
  remove async response hook policy (Azure#12529)
  update to target new warden version (Azure#12522)
  fix azure-storage-blob readme and samples issues (Azure#12511)
  code fence not formatted appropriately (Azure#12520)
  Fix documentation typo (Azure#12519)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jul 21, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
e9cbd87 
…into ta_opinion_mining_sample

* 'master' of https://github.com/Azure/azure-sdk-for-python: (124 commits)
  [formrecognizer] Add type to FormField (Azure#12561)
  Add example summary for azure-identity readme.md (Azure#12509)
  Add logging to credentials (Azure#12319)
  Sdk automation/track2 azure mgmt keyvault (Azure#12638)
  Remove unnecessary coroutine declaration (Azure#12602)
  [Cosmos] Fix type comment (Azure#12598)
  replace aka link (Azure#12597)
  [ServiceBus] Message/ReceivedMessage Properties alignment with other languages (Azure#12451)
  Find list of installed packages using pkg_resources (Azure#12591)
  token refresh offset (Azure#12136)
  updates (Azure#12595)
  User authentication samples (Azure#11343)
  Remove unnecessary base class (Azure#12374)
  Sequence -> Iterable for scopes (Azure#12579)
  Disable apistubgen step until issue is fixed (Azure#12594)
  fix pylint issue (Azure#12578)
  fix name in example (Azure#12572)
  Update tests.md (Azure#12574)
  Add stress tests for max batch size/prefetch, and for unsettled message receipt.  Add capability to not auto-complete and adjust max_batch_size into the base stress tester. (Azure#12344)
  [formrecognizer] Capitalize enum values (Azure#12540)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jul 29, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
e4c94dc 
…into regenerate_secrets

* 'master' of https://github.com/Azure/azure-sdk-for-python: (96 commits)
  replace aka link (Azure#12597)
  [ServiceBus] Message/ReceivedMessage Properties alignment with other languages (Azure#12451)
  Find list of installed packages using pkg_resources (Azure#12591)
  token refresh offset (Azure#12136)
  updates (Azure#12595)
  User authentication samples (Azure#11343)
  Remove unnecessary base class (Azure#12374)
  Sequence -> Iterable for scopes (Azure#12579)
  Disable apistubgen step until issue is fixed (Azure#12594)
  fix pylint issue (Azure#12578)
  fix name in example (Azure#12572)
  Update tests.md (Azure#12574)
  Add stress tests for max batch size/prefetch, and for unsettled message receipt.  Add capability to not auto-complete and adjust max_batch_size into the base stress tester. (Azure#12344)
  [formrecognizer] Capitalize enum values (Azure#12540)
  Update Pinned CI Packages (Azure#11586)
  remove async response hook policy (Azure#12529)
  update to target new warden version (Azure#12522)
  fix azure-storage-blob readme and samples issues (Azure#12511)
  code fence not formatted appropriately (Azure#12520)
  Fix documentation typo (Azure#12519)
  ...
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Jan 21, 2021
CodeGen from PR 12540 in Azure/azure-rest-api-specs
11ef9a9 
Added readme.python.md for multi API support (Azure#12540)

* Added readme.python.md for multi API support
00Kai0 added a commit that referenced this pull request Jan 26, 2021
@00Kai0
T1 servicebus 2021 01 26 (#16337)
2b85308 
* CodeGen from PR 12540 in Azure/azure-rest-api-specs
Added readme.python.md for multi API support (#12540)

* Added readme.python.md for multi API support

* test,version,CHANGELOG

* fix changelog and version

Co-authored-by: SDKAuto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iscai-msft iscai-msft iscai-msft approved these changes

@rakshith91 rakshith91 rakshith91 approved these changes

Assignees

@kristapratico kristapratico

Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Form Recognizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kristapratico @rakshith91 @iscai-msft