SDK changes for swagger update to support AutomaticRepairsPolicy for Virtual Machine Scale Sets #8141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 15, 2019 13:00
hapandar
commented
Oct 16, 2019
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/OSProfile.cs
Show resolved
Hide resolved
hapandar
commented
Oct 16, 2019
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/ScaleInPolicy.cs
Show resolved
Hide resolved
hapandar
commented
Oct 16, 2019
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/VirtualMachineScaleSet.cs
Show resolved
Hide resolved
hyonholee
reviewed
Oct 16, 2019
| [assembly: AssemblyVersion("29.1.0.0")] | ||
| [assembly: AssemblyFileVersion("29.0.0.0")] | ||
| [assembly: AssemblyVersion("29.2.0.0")] | ||
| [assembly: AssemblyFileVersion("29.2.0.0")] |
There was a problem hiding this comment.
You don't have to update AssemblyFileVersion for minor version update. Leave it to 29.0.0.0
There was a problem hiding this comment.
@hyonholee @hapandar That is not correct. AssemblyFileVersion needs to be updated for every release, AssemblyVersion only when introducing a breaking change (aka a major version update).
So my suggestion is:
[assembly: AssemblyVersion("29.1.0.0")]
[assembly: AssemblyFileVersion("29.2.0.0")]Read about it in our process document: https://github.com/Azure/adx-documentation-pr/blob/master/engineering/adx_netsdk_process.md#signing-and-publishing-nuget-packges
An article explaining this: https://support.microsoft.com/en-us/help/556041
hyonholee
reviewed
Oct 16, 2019
sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj
Outdated
Show resolved
Hide resolved
|
LGTM |
isra-fel
suggested changes
Oct 18, 2019
isra-fel
added
needs-revision
Mgmt
hapandar
commented
Oct 18, 2019
sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj
Show resolved
Hide resolved
|
/azp run net - mgmt - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
isra-fel
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This SDK PR includes the below Swagger updates:
Azure/azure-rest-api-specs#7484
Azure/azure-rest-api-specs#7513
Azure/azure-rest-api-specs#7355
Azure/azure-rest-api-specs#7034
Resolved. Including the additional changes
Note: when I ran code gen tool, there were other changes (which were not part of my swagger changes) that were generated as well. Is the best practice to revert these changes?
Please let me know and I can plan to revert those changes manually. For example, the ScaleInPolicy is not part of my changes and is not covered as part of the tests I have written.