Swagger changes to support automatic repairs on Virtual Machine Scale Sets #7484

hapandar · 2019-10-14T17:53:03Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

openapi-sdkautomation · 2019-10-14T17:53:06Z

In Testing, Please Ignore

[Logs] (Generated from 92dd4e7, Iteration 8)

.NET: test-repo-billy/azure-sdk-for-net [Logs]

Package generation in progress.

Python: test-repo-billy/azure-sdk-for-python [Logs]

Package generation in progress.

Java: test-repo-billy/azure-sdk-for-java

Package generation pending.

JavaScript: test-repo-billy/azure-sdk-for-js

Package generation pending.

Go: test-repo-billy/azure-sdk-for-go

Package generation pending.

Ruby: test-repo-billy/azure-sdk-for-ruby

Package generation pending.

msftclas · 2019-10-14T17:53:15Z

All CLA requirements met.

hapandar · 2019-10-14T17:56:07Z

SDK generate.ps1 output:
Installing AutoRest version: latest
AutoRest installed successfully.
Commencing code generation
Generating CSharp code
Executing AutoRest command
cmd.exe /c autorest.cmd https://github.com/hapandar/azure-rest-api-specs/blob/master/specification/compute/resource-manager/readme.md --csharp --version=latest --reflect-api-versions --csharp-sdks-folder=C:\repos\azure-sdk-for-net\azure-sdk-for-net\sdk
2019-10-14 17:48:37 UTC
Azure-rest-api-specs repository information
GitHub fork: hapandar
Branch: master
Commit: f7a8532
AutoRest information
Requested version: latest
Bootstrapper version: [email protected]

AutorestCI · 2019-10-14T17:56:19Z

Automation for azure-sdk-for-python

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-python#7859

AutorestCI · 2019-10-14T17:59:33Z

Automation for azure-sdk-for-go

A PR has been created for you based on this PR content.

Once this PR will be merged, content will be added to your service PR:
Azure/azure-sdk-for-go#6056

azuresdkci · 2019-10-14T18:31:20Z

Can one of the admins verify this patch?

hapandar · 2019-10-14T21:33:50Z

Enabled is interpreted as false if it’s not provided. From: Hyonho Lee <[email protected]> Sent: Monday, October 14, 2019 2:24 PM To: Azure/azure-rest-api-specs <[email protected]> Cc: Harini Pandari <[email protected]>; Author <[email protected]> Subject: Re: [Azure/azure-rest-api-specs] [Do Not Merge] Swagger changes to support automatic repairs on Virtual Machine Scale Sets (#7484) @hyonholee commented on this pull request.

________________________________ In specification/compute/resource-manager/Microsoft.Compute/stable/2018-10-01/compute.json<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F7484%23discussion_r334668534&data=02%7C01%7CHarini.Pandari%40microsoft.com%7Cd8fe8cfa834a468595ff08d750ecd27e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066850389864468&sdata=znreWE5H6xHrpe9pTLEdHGrv4i5RQ2b6voVUuQ3DH8M%3D&reserved=0>:

@@ -6071,6 +6074,23 @@

}, "description": "Specifies the operating system settings for the virtual machine." }, + "AutomaticRepairsPolicy": { + "properties": { + "enabled": { Is this optional property? If so, if enabled is not given, it is interpreted as enabled=false in service? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FAzure%2Fazure-rest-api-specs%2Fpull%2F7484%3Femail_source%3Dnotifications%26email_token%3DAKXW7X6ELUADM5S5WM74XKDQOTPOZA5CNFSM4JASGTU2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCH4UAPQ%23pullrequestreview-301547582&data=02%7C01%7CHarini.Pandari%40microsoft.com%7Cd8fe8cfa834a468595ff08d750ecd27e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066850389864468&sdata=DSAjNJbcyj%2FegBrAiscg6ohIGRvHca1BpiKx720Wg%2BQ%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKXW7X6LJGAC46X2I3LJREDQOTPOZANCNFSM4JASGTUQ&data=02%7C01%7CHarini.Pandari%40microsoft.com%7Cd8fe8cfa834a468595ff08d750ecd27e%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637066850389874428&sdata=fvIgkux7JtoVNSARakdD1%2FZKAECTysboHBanFiFAKuI%3D&reserved=0>.

sanjaiganesh · 2019-10-16T02:18:20Z

specification/compute/resource-manager/Microsoft.Compute/stable/2018-10-01/compute.json

@@ -6071,6 +6074,23 @@
      },
      "description": "Specifies the operating system settings for the virtual machine."
    },
+    "AutomaticRepairsPolicy": {


"AutomaticRepairsPolicy": { [](start = 4, length = 27)

this is modifying the existing api version.
please ensure that the default : false is honored for existing resources (that don't have this property).
signing off, hoping this will be taken care.

yungezz · 2019-10-16T03:22:19Z

hi @erich-wang is this PR ok to merge?

Harini Pandari added 2 commits October 14, 2019 10:43

Update swagger to support AutomaticRepairs for VMScaleSet

719fbd8

Merge remote-tracking branch 'upstream/master'

f7a8532

hapandar requested a review from hyonholee as a code owner October 14, 2019 17:53

AutorestCI mentioned this pull request Oct 14, 2019

[AutoPR compute/resource-manager] Swagger changes to support automatic repairs on Virtual Machine Scale Sets Azure/azure-sdk-for-python#7869

Closed

AutorestCI mentioned this pull request Oct 14, 2019

[AutoPR compute/resource-manager] Swagger changes to support automatic repairs on Virtual Machine Scale Sets Azure/azure-sdk-for-go#6022

Closed

openapi-sdkautomation bot mentioned this pull request Oct 14, 2019

[AutoPR Microsoft.Azure.Management.Compute] Swagger changes to support automatic repairs on Virtual Machine Scale Sets test-repo-billy/azure-sdk-for-net#311

Merged

azuresdkci assigned erich-wang Oct 14, 2019

azuresdkci requested a review from erich-wang October 14, 2019 18:15

openapi-sdkautomation bot mentioned this pull request Oct 14, 2019

[AutoPR compute/resource-manager/v2017_03_30] Swagger changes to support automatic repairs on Virtual Machine Scale Sets test-repo-billy/azure-sdk-for-java#538

Closed

hapandar changed the title ~~Swagger changes to support automatic repairs on Virtual Machine Scale Sets~~ [Do Not Merge] Swagger changes to support automatic repairs on Virtual Machine Scale Sets Oct 14, 2019

Fix unreferenced file error

9d62642

hyonholee approved these changes Oct 14, 2019

View reviewed changes

hapandar changed the title ~~[Do Not Merge] Swagger changes to support automatic repairs on Virtual Machine Scale Sets~~ Swagger changes to support automatic repairs on Virtual Machine Scale Sets Oct 14, 2019

erich-wang added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 15, 2019

Small change - Modify the description for grace period

92dd4e7

sanjaiganesh reviewed Oct 16, 2019

View reviewed changes

sanjaiganesh added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Oct 16, 2019

erich-wang approved these changes Oct 16, 2019

View reviewed changes

erich-wang merged commit 14464cf into Azure:master Oct 16, 2019

AutorestCI mentioned this pull request Oct 16, 2019

[AutoPR compute/resource-manager] Swagger changes to support automatic repairs on Virtual Machine Scale Sets Azure/azure-sdk-for-go#6055

Merged

hapandar mentioned this pull request Oct 17, 2019

SDK changes for swagger update to support AutomaticRepairsPolicy for Virtual Machine Scale Sets Azure/azure-sdk-for-net#8141

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Swagger changes to support automatic repairs on Virtual Machine Scale Sets #7484

Swagger changes to support automatic repairs on Virtual Machine Scale Sets #7484

hapandar commented Oct 14, 2019 •

edited

Loading

openapi-sdkautomation bot commented Oct 14, 2019 •

edited

Loading

msftclas commented Oct 14, 2019 •

edited

Loading

hapandar commented Oct 14, 2019

AutorestCI commented Oct 14, 2019 •

edited

Loading

AutorestCI commented Oct 14, 2019 •

edited

Loading

azuresdkci commented Oct 14, 2019

hapandar commented Oct 14, 2019 via email

sanjaiganesh Oct 16, 2019

yungezz commented Oct 16, 2019

Swagger changes to support automatic repairs on Virtual Machine Scale Sets #7484

Swagger changes to support automatic repairs on Virtual Machine Scale Sets #7484

Conversation

hapandar commented Oct 14, 2019 • edited Loading

Latest improvements:

Contribution checklist:

ARM API Review Checklist

openapi-sdkautomation bot commented Oct 14, 2019 • edited Loading

In Testing, Please Ignore

[Logs] (Generated from 92dd4e7, Iteration 8)

msftclas commented Oct 14, 2019 • edited Loading

hapandar commented Oct 14, 2019

AutorestCI commented Oct 14, 2019 • edited Loading

Automation for azure-sdk-for-python

AutorestCI commented Oct 14, 2019 • edited Loading

Automation for azure-sdk-for-go

azuresdkci commented Oct 14, 2019

hapandar commented Oct 14, 2019 via email

sanjaiganesh Oct 16, 2019

Choose a reason for hiding this comment

yungezz commented Oct 16, 2019

hapandar commented Oct 14, 2019 •

edited

Loading

openapi-sdkautomation bot commented Oct 14, 2019 •

edited

Loading

msftclas commented Oct 14, 2019 •

edited

Loading

AutorestCI commented Oct 14, 2019 •

edited

Loading

AutorestCI commented Oct 14, 2019 •

edited

Loading