Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release build config #6965

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Release build config #6965

merged 2 commits into from
Jul 29, 2019

Conversation

chidozieononiwu
Copy link
Member

Set Build Configuration to release from the net - client pipeline with option to change the setting at queue time.

@chidozieononiwu
Copy link
Member Author

@Azure/azure-sdk-eng

@chidozieononiwu chidozieononiwu force-pushed the ReleaseBuildConfig branch 5 times, most recently from df8f81a to d45292b Compare July 18, 2019 17:07
@chidozieononiwu
Copy link
Member Author

/azp run net - client - ci

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

@chidozieononiwu chidozieononiwu force-pushed the ReleaseBuildConfig branch 8 times, most recently from a99f192 to aec393d Compare July 19, 2019 18:51
weshaggard
weshaggard reviewed Jul 29, 2019
View reviewed changes
eng/pipelines/templates/variables/globals.yml
BuildConfiguration: ''
${{ if eq(variables['System.TeamProject'], 'internal') }}:
BuildConfiguration: 'Release'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested that this second assignment actually works in an internal build?

weshaggard
weshaggard reviewed Jul 29, 2019
View reviewed changes
eng/pipelines/templates/variables/globals.yml Outdated
skipComponentGovernanceDetection: true
BuildConfiguration: ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will want this to be set to Debug and not empty by default. Otherwise we will not have the Configuration set correctly as we cannot default it to Debug if you set the Configuration property as a global property via the command line as those cannot be overridden in the props file.

weshaggard
weshaggard reviewed Jul 29, 2019
View reviewed changes
eng/pipelines/templates/variables/globals.yml Outdated
skipComponentGovernanceDetection: true
${{ if ne(variables['System.TeamProject'], 'internal') }}:
BuildConfiguration: ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this approach is likely better then the other one. However did you seem my comment about setting this to Debug and not empty? I think we should always set it to either Debug or Release.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I can set it to debug. However it works the way it is right now in both playground and internal projects

@chidozieononiwu chidozieononiwu merged commit e9c533e into Azure:master Jul 29, 2019
@chidozieononiwu chidozieononiwu deleted the ReleaseBuildConfig branch July 29, 2019 23:36
@chidozieononiwu chidozieononiwu mentioned this pull request Jul 29, 2019
Closed
@weshaggard weshaggard mentioned this pull request Feb 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard approved these changes

@danieljurek danieljurek Awaiting requested review from danieljurek

@mitchdenny mitchdenny Awaiting requested review from mitchdenny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chidozieononiwu @weshaggard