-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Microsoft.Azure.EventGrid is released without optimizations #18645
Comments
This seems like it may be something related to the build pipelines. @weshaggard and @mitchdenny, would you be so kind as to offer your thoughts? |
Thank you for your feedback. Tagging and routing to the team members best able to assist. |
@jsquire there was a point in time where we were accidently shipping Debug built binaries but that was fixed with #6965 which occurred (7/29/2019) a couple months after the 3.2.0 version was shipped (5/23/2019 https://www.nuget.org/packages/Microsoft.Azure.EventGrid/3.2.0) to nuget. To fix this we would need to create a new release. So I'd leave that up to the owners of this library to decide when the best time to ship an update here. |
Thanks, @weshaggard. Since we know the root cause has been resolved, routing to the Event Grid service team for consideration of a new release. |
Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @jfggdl. Issue DetailsDescribe the bug Expected behavior Actual behavior (include Exception or Stack Trace) To Reproduce
private static void PrintInfo(Assembly assembly)
{
var attribute = assembly.GetCustomAttributes(false).OfType<DebuggableAttribute>().FirstOrDefault();
Console.WriteLine($"JIT tracking enabled: {attribute.IsJITTrackingEnabled}");
Console.WriteLine($"JIT optimization disabled: {attribute.IsJITOptimizerDisabled}");
// for 3.2.0
// JIT tracking enabled: True
// JIT optimization disabled: True
// for 3.1.0
// JIT tracking enabled: false
// JIT optimization disabled: false
} Environment: Hosting platform or OS and .NET runtime version Windows 10 .NET Framework 4.8] Runtime Environment: Host (useful for support): IDE and version:
|
Thank you. Assigning to @ahamad-MS . |
@weshaggard @jsquire Can you please elaborate on the ask from service team here? Since this is related to EngSys/build pipeline, it is not clear to me what is the ask here. We are currently in the process of adding new nuget version to include new features. Will this be sufficient to resolve this issue? |
@ahamad-MS: There would need to be a new version of the library published to resolve this. Since you're in the process of releasing for new features, that would cover it. |
Sweet .. thanks @jsquire for the clarification. I will close this issue once the new library is published. |
New nuget is now available and published. https://www.nuget.org/packages/Microsoft.Azure.Management.EventGrid/6.1.0-preview I am closing this issue according to the discussion with @jsquire .. Please let us know if additional info needed. Thanks |
Describe the bug
Microsoft.Azure.EventGrid
3.2.0 is compiled without optimizations. The previous version, 3.1.0 was compiled correctly, with optimizations turned on.Expected behavior
A package should be compiled with optimizations
Actual behavior (include Exception or Stack Trace)
The package is compiled without optimizations
To Reproduce
Environment:
Name and version of the Library package used:
Microsoft.Azure.EventGrid 3.2.0
Hosting platform or OS and .NET runtime version
Windows 10 .NET Framework 4.8]
.NET SDK (reflecting any global.json):
Version: 5.0.103
Commit: 72dec52dbd
Runtime Environment:
OS Name: Windows
OS Version: 10.0.18363
OS Platform: Windows
RID: win10-x64
Base Path: C:\Program Files\dotnet\sdk\5.0.103\
Host (useful for support):
Version: 5.0.3
Commit: c636bbdc8a
IDE and version:
Visual Studio Version 16.8.5
The text was updated successfully, but these errors were encountered: