Skip to content

Commit

Permalink
Add release build configuration to release pipeline
Browse files Browse the repository at this point in the history
  • Loading branch information
chidozieononiwu committed Jul 19, 2019
1 parent 8892fdf commit 7d01f9e
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 4 deletions.
2 changes: 1 addition & 1 deletion eng/pipelines/client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ jobs:
- template: templates/jobs/archetype-sdk-client.yml
parameters:
ServiceDirectory: $(ServiceDirectory)
VersioningProperties: /p:OfficialBuildId=$(OfficialBuildId) /p:PreRelaseVersionLabel=$(PreReleaseVersionLabel) /p:DotNetFinalVersionKind=$(DotNetFinalVersionKind)
VersioningProperties: /p:OfficialBuildId=$(OfficialBuildId) /p:PreRelaseVersionLabel=$(PreReleaseVersionLabel) /p:DotNetFinalVersionKind=$(DotNetFinalVersionKind)
8 changes: 6 additions & 2 deletions eng/pipelines/templates/jobs/archetype-sdk-client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ jobs:
displayName: "Use .NET Core sdk $(DotNetCoreSDKVersion)"
inputs:
version: "$(DotNetCoreSDKVersion)"
- script: "dotnet pack eng/service.proj -o $(Build.ArtifactStagingDirectory) -warnaserror /p:ServiceDirectory=${{parameters.ServiceDirectory}} /p:PublicSign=false ${{ parameters.VersioningProperties }}"
- script: >-
dotnet pack eng/service.proj -o $(Build.ArtifactStagingDirectory) -warnaserror /p:ServiceDirectory=${{parameters.ServiceDirectory}}
/p:PublicSign=false ${{ parameters.VersioningProperties }} /p:Configuration=$(BuildConfiguration)
displayName: "Build and Package"
env:
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
Expand Down Expand Up @@ -112,7 +114,9 @@ jobs:
inputs:
packageType: sdk
version: "$(DotNetCoreSDKVersion)"
- script: dotnet test eng/service.proj --filter TestCategory!=Live --framework $(TestTargetFramework) --logger "trx;LogFileName=$(TestTargetFramework).trx" /p:ServiceDirectory=${{ parameters.ServiceDirectory }} /p:IncludeSrc=false
- script: >-
dotnet test eng/service.proj --filter TestCategory!=Live --framework $(TestTargetFramework) --logger "trx;LogFileName=$(TestTargetFramework).trx"
/p:ServiceDirectory=${{ parameters.ServiceDirectory }} /p:IncludeSrc=false /p:Configuration=$(BuildConfiguration)
displayName: "Build & Test ($(TestTargetFramework))"
env:
DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1
Expand Down
5 changes: 4 additions & 1 deletion eng/pipelines/templates/variables/globals.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,7 @@ variables:
DotNetCoreSDKVersion: '3.0.100-preview5-011568'
DotNetCoreRuntimeVersion: '2.1.10'
OfficialBuildId: $(Build.BuildNumber)
skipComponentGovernanceDetection: true
skipComponentGovernanceDetection: true
BuildConfiguration: ''
${{ if eq(variables['System.TeamProject'], 'internal') }}:
BuildConfiguration: 'Release'

0 comments on commit 7d01f9e

Please sign in to comment.