Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text Analytics SDK v3.1.0 #6291

Closed
wants to merge 1 commit into from
Closed

Text Analytics SDK v3.1.0 #6291

wants to merge 1 commit into from

Conversation

assafi
Copy link
Contributor

@assafi assafi commented May 15, 2019

[This is a replacement of PR 5860)

  • Update SDK to 3.1.0
  • Adding non-async and non-batch API calls
  • Fixing argument order in a few API calls

@assafi assafi mentioned this pull request May 15, 2019
Closed
dsgouda
dsgouda suggested changes May 15, 2019
View reviewed changes
Copy link
Contributor

@dsgouda dsgouda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this code gnerated using the generate.ps1 script, if not please generate using the script and commit changes to the .txt and SdkInfo_*.cs files

.../TextAnalytics/TextAnalytics/Microsoft.Azure.CognitiveServices.Language.TextAnalytics.csproj
]]></PackageReleaseNotes>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this line

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, please update the AssemblyFileVersion in AssemblyInfo.cs to 3.1.0.0

@dsgouda
Copy link
Contributor

dsgouda commented May 15, 2019

This may have to be updated due to repo structure changes to be introduced here
#6180

@dsgouda
Copy link
Contributor

dsgouda commented May 15, 2019

@assafi Please move your project to the new repo structure and open a new PR

@dsgouda dsgouda closed this May 15, 2019
@assafi assafi mentioned this pull request Jun 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsgouda dsgouda dsgouda requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@assafi @dsgouda