-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text Analytics SDK v4.0.0 - New project structure #6647
Conversation
@dsgouda Could you please review? |
@dsgouda / @AlexGhiondea - Could one of you please review? |
...tiveservices/Language.TextAnalytics/src/Customizations/TextAnalytics/Models/LanguageInput.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you link the spec changes you made for this one?
Also your breaking change should follow semantic versioning rules, so with a breaking change, bump up the version to 4.0.0 rather than 3.1.0
Also is this auto generated or you edited this code?
@shahabhijeet This change is manual and there are no spec changed to the swagger definition. I'll update the SDK version to 4.0.0 |
Please note that when auto-generating this SDK from the spec definition the parameter order will be reverted back. The spec itself will be updated on the next version of the service API at which point the correct order of parameters would be fixed. Until then, special attention should be given whenever this SDK is being updated to make sure that the parameter order is not accidentally reverted back. |
Please note, this is the successor of #6291 , only difference is the new project structure for the SDKs.
Summary of changes: