Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Analytics SDK v4.0.0 - New project structure #6647

Merged
merged 3 commits into from
Jul 19, 2019

Conversation

assafi
Copy link
Contributor

@assafi assafi commented Jun 19, 2019

Please note, this is the successor of #6291 , only difference is the new project structure for the SDKs.

Summary of changes:

  • Adding non-async calls
  • Adding non-batch calls
  • Correct order of params (id, text, lang)

@assafi
Copy link
Contributor Author

assafi commented Jun 19, 2019

@dsgouda Could you please review?

@dsgouda dsgouda requested a review from AlexGhiondea June 19, 2019 22:25
@assafi
Copy link
Contributor Author

assafi commented Jul 12, 2019

@dsgouda / @AlexGhiondea - Could one of you please review?

Copy link
Member

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link the spec changes you made for this one?
Also your breaking change should follow semantic versioning rules, so with a breaking change, bump up the version to 4.0.0 rather than 3.1.0

Also is this auto generated or you edited this code?

@assafi
Copy link
Contributor Author

assafi commented Jul 19, 2019

@shahabhijeet This change is manual and there are no spec changed to the swagger definition.
We prefer not update the API definition (which will require a service version bump) just to change the order of parameters in the SDK. The rest of the changes are done manually because there's no support for them in autorest (non-batch and non-async calls).

I'll update the SDK version to 4.0.0

@assafi assafi changed the title Text Analytics SDK v3.1.0 - New project structure Text Analytics SDK v4.0.0 - New project structure Jul 19, 2019
@assafi
Copy link
Contributor Author

assafi commented Jul 19, 2019

Please note that when auto-generating this SDK from the spec definition the parameter order will be reverted back. The spec itself will be updated on the next version of the service API at which point the correct order of parameters would be fixed. Until then, special attention should be given whenever this SDK is being updated to make sure that the parameter order is not accidentally reverted back.

@shahabhijeet shahabhijeet merged commit df69fc2 into Azure:master Jul 19, 2019
@assafi assafi deleted the assafi/ta_sdk3.1 branch July 20, 2019 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants