Update repo structure cognitive services 3 #6180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chidozieononiwu
force-pushed
the
UpdateRepoStructure_CognitiveServices_3
branch
from
5e32f06 to
0740f38
Compare
|
@Azure/azure-sdk-eng |
chidozieononiwu
force-pushed
the
UpdateRepoStructure_CognitiveServices_3
branch
9 times, most recently
from
694137b to
f0a280f
Compare
weshaggard
reviewed
May 13, 2019
...tomVision.Training/src/Microsoft.Azure.CognitiveServices.Vision.CustomVision.Training.csproj
Outdated
Show resolved
Hide resolved
chidozieononiwu
force-pushed
the
UpdateRepoStructure_CognitiveServices_3
branch
from
a8115bb to
b2fd8df
Compare
|
@chidozieononiwu Please resolve the merge conflicts, we have some changes coming in for cognitive services, this should be merged soon, |
weshaggard
reviewed
May 15, 2019
eng/data-plane.proj
Outdated
| @@ -3,7 +3,7 @@ | |||
| <ExcludeDataPlaneProjects Include="$(RepoSrcPath)\*\data-plane\**\*.Tests.*proj" Condition="'$(SkipTests)' == 'true'" /> | |||
| <ExcludeDataPlaneProjects Include="$(RepoRoot)\sdk\*\Microsoft.Azure.*\**\*.Tests.*proj" Condition="'$(SkipTests)' == 'true'" /> | |||
There was a problem hiding this comment.
You will need to do the same pattern change for the test projects.
weshaggard
reviewed
May 15, 2019
| @@ -0,0 +1,33 @@ | |||
| Microsoft Visual Studio Solution File, Format Version 12.00 | |||
There was a problem hiding this comment.
I was expecting that you would also remove "CognitiveServices" from the beginning of all these directory names.
weshaggard
approved these changes
May 15, 2019
chidozieononiwu
force-pushed
the
UpdateRepoStructure_CognitiveServices_3
branch
from
b2fd8df to
428bf8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move DataPlane libraries to new sdk folder.
Update repo structure.