-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New analyzer version to remove namespace analyzer #43687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this check instead of providing an "allow list" of namespaces differently? How are we validating in our pipelines that non-approved namespaces won't be shipped?
This was the result of an email discussion with the architects agreeing that this is no longer necessary due to API View being the authoritative voice for approved namespaces and package names. The analyzer has been a consistent point of feedback from partners who found it causing friction while onboarding to .NET. |
The release pipelines have logic to block a release if the package name is not approved. At this point, .NET is the only repo that is doing an extra check so I am cleaning the process. I will add you to the email thread where the discussion happened |
We can probably also clean-up all the existing references to this code https://github.com/search?q=repo%3AAzure%2Fazure-sdk-for-net%20AZC0001&type=code |
API change check API changes are not detected in this pull request. |
...nsions.AspNetCore.DataProtection.Keys/src/AzureDataProtectionKeyVaultKeyBuilderExtensions.cs
Show resolved
Hide resolved
/check-enforcer override |
The release pipelines have logic to block a release if the package name is not approved. At this point, .NET is the only repo that is doing an extra check so I am cleaning the process.
PR in tools repo: Azure/azure-sdk-tools#8164
Tracking issue: Azure/azure-sdk-tools#8105