Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New analyzer version to remove namespace analyzer #43687

Merged
merged 7 commits into from
May 1, 2024
Merged

Conversation

maririos
Copy link
Member

@maririos maririos commented Apr 26, 2024

The release pipelines have logic to block a release if the package name is not approved. At this point, .NET is the only repo that is doing an extra check so I am cleaning the process.

PR in tools repo: Azure/azure-sdk-tools#8164

Tracking issue: Azure/azure-sdk-tools#8105

@maririos maririos marked this pull request as ready for review April 29, 2024 17:23
@maririos maririos requested a review from weshaggard April 29, 2024 17:23
@maririos maririos changed the title [WIP] New analyzer version to remove namespace analyzer New analyzer version to remove namespace analyzer Apr 29, 2024
Copy link
Member

@annelo-msft annelo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this check instead of providing an "allow list" of namespaces differently? How are we validating in our pipelines that non-approved namespaces won't be shipped?

@jsquire
Copy link
Member

jsquire commented Apr 29, 2024

Why remove this check instead of providing an "allow list" of namespaces differently? How are we validating in our pipelines that non-approved namespaces won't be shipped?

This was the result of an email discussion with the architects agreeing that this is no longer necessary due to API View being the authoritative voice for approved namespaces and package names. The analyzer has been a consistent point of feedback from partners who found it causing friction while onboarding to .NET.

@maririos
Copy link
Member Author

Why remove this check instead of providing an "allow list" of namespaces differently? How are we validating in our pipelines that non-approved namespaces won't be shipped?

The release pipelines have logic to block a release if the package name is not approved. At this point, .NET is the only repo that is doing an extra check so I am cleaning the process. I will add you to the email thread where the discussion happened

@weshaggard
Copy link
Member

We can probably also clean-up all the existing references to this code https://github.com/search?q=repo%3AAzure%2Fazure-sdk-for-net%20AZC0001&type=code

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@maririos
Copy link
Member Author

maririos commented May 1, 2024

/check-enforcer override

@maririos maririos merged commit d949e9d into main May 1, 2024
323 of 335 checks passed
@maririos maririos deleted the maririos-patch-1 branch May 1, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants