Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New analyzer version to remove namespace analyzer #43687

Merged
merged 7 commits into from
May 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eng/Packages.Data.props
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@
-->
<ItemGroup>
<PackageReference Update="Microsoft.Azure.AutoRest.CSharp" Version="3.0.0-beta.20240428.10" PrivateAssets="All" />
<PackageReference Update="Azure.ClientSdk.Analyzers" Version="0.1.1-dev.20240214.2" PrivateAssets="All" />
<PackageReference Update="Azure.ClientSdk.Analyzers" Version="0.1.1-dev.20240429.1" PrivateAssets="All" />
<PackageReference Update="coverlet.collector" Version="3.2.0" PrivateAssets="All" />
<PackageReference Update="Microsoft.CodeAnalysis.NetAnalyzers" Version="7.0.4" PrivateAssets="All" />
<PackageReference Update="Microsoft.CodeAnalysis.BannedApiAnalyzers" Version="3.3.2" PrivateAssets="All" />
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<Version>1.0.0-beta.2</Version>
<PackageTags>Azure FarmBeats</PackageTags>
<TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
<NoWarn>$(NoWarn);AZC0001;AZC0012;AZC0007;AZC0006</NoWarn>
<NoWarn>$(NoWarn);AZC0012;AZC0007;AZC0006</NoWarn>
<DefineConstants>$(DefineConstants);EXPERIMENTAL</DefineConstants>
<IncludeOperationsSharedSource>true</IncludeOperationsSharedSource>
</PropertyGroup>
Expand Down
1 change: 0 additions & 1 deletion sdk/core/Azure.Core.Amqp/src/Azure.Core.Amqp.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
<PackageTags>Microsoft Azure AMQP</PackageTags>
<Nullable>enable</Nullable>
<TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
<NoWarn>$(NoWarn);AZC0001</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<PackageTags>Microsoft Azure Client Pipeline</PackageTags>
<Nullable>enable</Nullable>
<TargetFrameworks>$(RequiredTargetFrameworks);net461;net6.0</TargetFrameworks>
<NoWarn>$(NoWarn);AZC0001;AZC0012</NoWarn>
<NoWarn>$(NoWarn);AZC0012</NoWarn>
<IncludeOperationsSharedSource>true</IncludeOperationsSharedSource>
</PropertyGroup>

Expand Down
1 change: 0 additions & 1 deletion sdk/core/Azure.Core/src/GlobalSuppressions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,5 @@

using System.Diagnostics.CodeAnalysis;

[assembly: SuppressMessage("Usage", "AZC0001:Use one of the following pre-approved namespace groups (https://azure.github.io/azure-sdk/registered_namespaces.html): Azure.AI, Azure.Analytics, Azure.Communication, Azure.Data, Azure.DigitalTwins, Azure.Iot, Azure.Learn, Azure.Media, Azure.Management, Azure.Messaging, Azure.Search, Azure.Security, Azure.Storage, Azure.Template, Azure.Identity, Microsoft.Extensions.Azure", Justification = "<Pending>", Scope = "module")]
[assembly: SuppressMessage("Usage", "AZC0008:ClientOptions should have a nested enum called ServiceVersion", Justification = "<Pending>", Scope = "type", Target = "~T:Azure.Core.ClientOptions")]
[assembly: SuppressMessage("Usage", "AZC0014:Avoid using banned types in public API", Justification = "<Pending>", Scope = "member", Target = "~M:Azure.Core.Serialization.JsonObjectSerializer.#ctor(System.Text.Json.JsonSerializerOptions)")]
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
<ApiCompatVersion>1.0.0</ApiCompatVersion>
<Nullable>enable</Nullable>
<TargetFrameworks>netstandard2.0;net6.0</TargetFrameworks>
<NoWarn>$(NoWarn);AZC0001</NoWarn>
<PackageIcon>DotNetPackageIcon.png</PackageIcon>
<PackageIconPath>$(RepoEngPath)/images/$(PackageIcon)</PackageIconPath>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,4 @@

using System.Diagnostics.CodeAnalysis;

[assembly: SuppressMessage("Usage", "AZC0001:Use one of the following pre-approved namespace groups (https://azure.github.io/azure-sdk/registered_namespaces.html): Azure.AI, Azure.Analytics, Azure.Communication, Azure.Data, Azure.DigitalTwins, Azure.IoT, Azure.Learn, Azure.Media, Azure.Management, Azure.Messaging, Azure.ResourceManager, Azure.Search, Azure.Security, Azure.Storage, Azure.Template, Azure.Identity, Microsoft.Extensions.Azure", Justification = "<Pending>", Scope = "namespace", Target = "~N:Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents")]
[assembly: SuppressMessage("Usage", "AZC0007:DO provide a minimal constructor that takes only the parameters required to connect to the service.", Justification = "Seems like a misfire, as this is a simple class that does not have client options.(Perhaps the name ending in Client)", Scope = "type", Target = "~T:Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents.TokenIssuanceStart.WebJobsAuthenticationEventsContextClient")]
[assembly: SuppressMessage("Usage", "AZC0001:Use one of the following pre-approved namespace groups (https://azure.github.io/azure-sdk/registered_namespaces.html): Azure.AI, Azure.Analytics, Azure.Communication, Azure.Data, Azure.DigitalTwins, Azure.IoT, Azure.Learn, Azure.Media, Azure.Management, Azure.Messaging, Azure.ResourceManager, Azure.Search, Azure.Security, Azure.Storage, Azure.Template, Azure.Identity, Microsoft.Extensions.Azure", Justification = "<Pending>", Scope = "namespace", Target = "~N:Microsoft.Azure.WebJobs.Extensions.AuthenticationEvents.TokenIssuanceStart")]
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@
using CloudNative.CloudEvents.SystemTextJson;
using CloudEvent = CloudNative.CloudEvents.CloudEvent;

#pragma warning disable AZC0001 // Use one of the following pre-approved namespace groups (https://azure.github.io/azure-sdk/registered_namespaces.html): Azure.AI, Azure.Analytics, Azure.Communication, Azure.Data, Azure.DigitalTwins, Azure.Iot, Azure.Learn, Azure.Media, Azure.Management, Azure.Messaging, Azure.Search, Azure.Security, Azure.Storage, Azure.Template, Azure.Identity, Microsoft.Extensions.Azure
namespace Microsoft.Azure.Messaging.EventGrid.CloudNativeCloudEvents
#pragma warning restore AZC0001 // Use one of the following pre-approved namespace groups (https://azure.github.io/azure-sdk/registered_namespaces.html): Azure.AI, Azure.Analytics, Azure.Communication, Azure.Data, Azure.DigitalTwins, Azure.Iot, Azure.Learn, Azure.Media, Azure.Management, Azure.Messaging, Azure.Search, Azure.Security, Azure.Storage, Azure.Template, Azure.Identity, Microsoft.Extensions.Azure
{
/// <summary>
/// This class contains extension methods to enable usage of the CloudNative.CloudEvent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<Version>3.5.0-beta.1</Version>
<!--The ApiCompatVersion is managed automatically and should not generally be modified manually.-->
<ApiCompatVersion>3.4.1</ApiCompatVersion>
<NoWarn>$(NoWarn);AZC0001;CS1591</NoWarn>
<NoWarn>$(NoWarn);CS1591</NoWarn>
<AssemblyOriginatorKeyFile>sign.snk</AssemblyOriginatorKeyFile>
<IsExtensionClientLibrary>true</IsExtensionClientLibrary>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<Version>6.4.0-beta.1</Version>
<!--The ApiCompatVersion is managed automatically and should not generally be modified manually.-->
<ApiCompatVersion>6.3.2</ApiCompatVersion>
<NoWarn>$(NoWarn);AZC0001;CS1591;SA1636</NoWarn>
<NoWarn>$(NoWarn);CS1591;SA1636</NoWarn>
<AssemblyOriginatorKeyFile>sign.snk</AssemblyOriginatorKeyFile>
<IsExtensionClientLibrary>true</IsExtensionClientLibrary>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<Version>1.4.0-beta.1</Version>
<!--The ApiCompatVersion is managed automatically and should not generally be modified manually.-->
<ApiCompatVersion>1.3.1</ApiCompatVersion>
<NoWarn>$(NoWarn);AZC0001;AZC0102</NoWarn>
<NoWarn>$(NoWarn);AZC0102</NoWarn>
<IsExtensionClientLibrary>true</IsExtensionClientLibrary>
</PropertyGroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@
using Azure.Extensions.AspNetCore.Configuration.Secrets;
using Azure.Security.KeyVault.Secrets;

#pragma warning disable AZC0001 // Extension methods have to be in the correct namespace to appear in intellisense.
namespace Microsoft.Extensions.Configuration
#pragma warning restore
{
/// <summary>
/// Extension methods for registering <see cref="AzureKeyVaultConfigurationProvider"/> with <see cref="IConfigurationBuilder"/>.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,7 @@
using Azure.Storage.Blobs.Models;
using Microsoft.AspNetCore.DataProtection.Repositories;

#pragma warning disable AZC0001 //
namespace Azure.Extensions.AspNetCore.DataProtection.Blobs
#pragma warning restore
{
/// <summary>
/// An <see cref="IXmlRepository"/> which is backed by Azure Blob Storage.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Options;

#pragma warning disable AZC0001 // Extension methods have to be in the correct namespace to appear in intellisense.
#pragma warning disable // TODO cleanup of all the warning messages. Issue https://github.com/Azure/azure-sdk-for-net/issues/43768
namespace Microsoft.AspNetCore.DataProtection
#pragma warning disable
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
using Microsoft.Extensions.DependencyInjection;
using Microsoft.Extensions.Options;

#pragma warning disable AZC0001 // Extension methods have to be in the correct namespace to appear in intellisense.
#pragma warning disable // TODO cleanup of all the warning messages. Issue https://github.com/Azure/azure-sdk-for-net/issues/43768
namespace Microsoft.AspNetCore.DataProtection
#pragma warning disable
maririos marked this conversation as resolved.
Show resolved Hide resolved
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,7 @@
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Logging.Abstractions;

#pragma warning disable AZC0001
namespace Microsoft.AspNetCore.DataProtection
#pragma warning restore AZC0001
{
/// <summary>
/// This type is a copy of https://github.com/dotnet/aspnetcore/blob/e1bf38ccaf2a98f95e48bf22b8b76d996a0c33ea/src/DataProtection/DataProtection/test/TypeForwardingActivatorTests.cs
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<PackageTags>aspnetcore;dataprotection;azure;blob;key store</PackageTags>
<Version>1.0.0-beta.1</Version>
<IsExtensionClientLibrary>true</IsExtensionClientLibrary>
<NoWarn>$(NoWarn);AZC0001;CA1812</NoWarn>
<NoWarn>$(NoWarn);CA1812</NoWarn>
</PropertyGroup>

<ItemGroup>
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

using System.Diagnostics.CodeAnalysis;

[assembly: SuppressMessage("Usage", "AZC0001:Use one of the following pre-approved namespace groups (https://azure.github.io/azure-sdk/registered_namespaces.html): Azure.AI, Azure.Analytics, Azure.Communication, Azure.Containers, Azure.Core.Expressions, Azure.Data, Azure.DigitalTwins, Azure.Identity, Azure.IoT, Azure.Learn, Azure.Management, Azure.Media, Azure.Messaging, Azure.MixedReality, Azure.Monitor, Azure.ResourceManager, Azure.Search, Azure.Security, Azure.Storage, Azure.Template, Microsoft.Extensions.Azure", Justification = "<Pending>", Scope = "namespace", Target = "~N:Azure.Health.Insights.RadiologyInsights")]
[assembly: SuppressMessage("Naming", "AZC0030:Improper model name suffix", Justification = "<Pending>", Scope = "type", Target = "~T:Azure.Health.Insights.RadiologyInsights.FindingOptions")]
[assembly: SuppressMessage("Naming", "AZC0030:Improper model name suffix", Justification = "<Pending>", Scope = "type", Target = "~T:Azure.Health.Insights.RadiologyInsights.RadiologyInsightsInferenceOptions")]
[assembly: SuppressMessage("Naming", "AZC0032:Improper model name suffix", Justification = "<Pending>", Scope = "type", Target = "~T:Azure.Health.Insights.RadiologyInsights.RadiologyInsightsData")]
Expand Down
9 changes: 0 additions & 9 deletions sdk/identity/Azure.Identity/src/GlobalSuppressions.cs

This file was deleted.

3 changes: 1 addition & 2 deletions sdk/keyvault/samples/keyvaultproxy/Directory.Build.props
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@
<RootNamespace>AzureSamples.Security.KeyVault.Proxy</RootNamespace>
<LangVersion>11.0</LangVersion>
<NoWarn>
$(NoWarn);
AZC0001
$(NoWarn)
</NoWarn>
</PropertyGroup>
</Project>
2 changes: 1 addition & 1 deletion sdk/maps/Azure.Maps.Common/src/Azure.Maps.Common.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<AssemblyTitle>Microsoft Azure.Maps.Common client library</AssemblyTitle>
<Version>1.0.0-beta.5</Version>
<DefineConstants>CommonSDK;$(DefineConstants)</DefineConstants>
<NoWarn>$(NoWarn);AZC0001;AZC0012</NoWarn>
<NoWarn>$(NoWarn);AZC0012</NoWarn>
<PackageTags>Microsoft Azure Maps Common, Microsoft, Azure, Maps, azureofficial</PackageTags>
<Description>
This client library enables working with the Microsoft Azure Maps services which provides developers from all industries with powerful geospatial capabilities.
Expand Down
Loading
Loading