Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove namespace analyzer #8164

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Remove namespace analyzer #8164

merged 1 commit into from
Apr 29, 2024

Conversation

maririos
Copy link
Member

@maririos maririos commented Apr 26, 2024

The release pipelines have logic to block a release if the package name is not approved. At this point, .NET is the only repo that is doing an extra check so I am cleaning the process. I will add you to the email thread where the discussion happened

Copy link
Member

@jsquire jsquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maririos maririos marked this pull request as ready for review April 29, 2024 17:21
@maririos maririos requested a review from weshaggard April 29, 2024 17:22
@maririos maririos changed the title [WIP] Remove namespace analyzer Remove namespace analyzer Apr 29, 2024
@maririos maririos merged commit 677526b into main Apr 29, 2024
39 checks passed
@maririos maririos deleted the anlyzer branch April 29, 2024 18:40
@chidozieononiwu
Copy link
Member

This change breaks APIView at

_analyzers.Add(new ClientAssemblyNamespaceAnalyzer());

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants