Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute #27949

Conversation

hari-bodicherla
Copy link
Contributor

Contributing to the Azure SDK

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

heaths and others added 30 commits February 28, 2022 21:55
* Fix PartiallyDeployedAttribute to catch exceptions

Despite being patterned from RecordedTestAttribute that does get a failed result from tests that throw, the same didn't work here. Spent a little time investigating to no avail, but this is a simple, straight-forward workaround given limited time.

* Fix build break
…sted data (Azure#27255)

* Fix count, min, max, sum.

* Fix test
* Add ChainingClassifier

* implement chaining

* add tests

* pr fb

* pr fb; +add tests

* pr fb

* pr fb
* correct namespace

* build error

* public api
…to allow the apps to consume AddAzureMonitorMetricExporter. (Azure#27256)
* remove everything

* regenerate

Co-authored-by: Yao Kou <[email protected]>
* remove for renaming

* regenerate compute

* update api

* fix test cases

* update

* remove everything

* regenerate

* update api

* regenerate

* update api

* fix and regenerate

Co-authored-by: Yao Kou <[email protected]>
The focus of these changes is to add guidance to the event publishing sample,
calling out the impact of code running in the event handlers for the buffered
producer client.
…zure#27259)

* revert transactional checksums

* revert part 2

* exportapi

* fix md5 false condition

* fix mock

* fix datalake mock

* fix accidental file deletion

* changelog

Co-authored-by: jschrepp-MSFT <[email protected]>
Co-authored-by: Sean McCullough <[email protected]>
* 12767912: Add isLocalInference in the public SDK

* Rename the variable

* Thick clent feature (Azure#5)

* 12767907: Add a package dependency on Microsoft.RL

* Add RankProcessor

* Remove unused file

* Remove some key

* Toggle commented codes so that most tests can pass

* Getting the required config details for rankprocessor to enable livemode

* Updating the wrong variable name

* Cleanup

* Revert "12767907: Add a package dependency on Microsoft.RL"

This reverts commit c586920.

* Revert "Add RankProcessor"

This reverts commit 43967d3.

* Revert "Remove unused file"

This reverts commit 1e400a8.

* Revert "Toggle commented codes so that most tests can pass"

This reverts commit 7ec50ec.

* Delete DisposeHelper.cs

* Revert "Revert "12767907: Add a package dependency on Microsoft.RL""

This reverts commit d6df6b5.

* Cleanup after reverting

* generating client configuration using autorest

* Revert "generating client configuration using autorest"

This reverts commit 6b75695.

* Configuration details for livemodel

* cleanup

* cleanup

* Added ToDo comments

* correct the version in endpoints

Co-authored-by: Tejaswi Paruchuri <[email protected]>
Co-authored-by: Tparuchuri <[email protected]>

* 12768045: Add rank processor for single slot (Azure#3)

Add RankProcessor

Remove unused file

Remove some key

Toggle commented codes so that most tests can pass

RankProcessor is working. Still need to clean up the codes

Add test json files

only construct LiveModel when localInference is true

Move rankprocessor to under model

Add latest generated files from autorest

Add autogenerated files from autorest

Fix the setting in DecisionContext

Remove wrong comment

Revert unexpected auto-generated file changes

Addressed a comment

Move suppression to GlobalSuppressions.cs

Remove the decoration in MultiSlotClient.cs

Refactor rankProcessor so that the actions is not modified and restored;
added a converter between sdk and Rl.Net; replace Newtonsoft.json with
System.Text.Json

Address comments

Refactor RlObjuectConverter; remove some unneeded setters, etc.

Added unit tests for RlObjectConverter, DecisionContext,
JsonRawStringListConverter

Remove unused using

* 13009290: Create RankProcessor class to Azure Personalizer client library for .NET for multi slot (Azure#7)

* 13009290: Create RankProcessor class to Azure Personalizer client
              library for .NET for multi slot

* Address comments

* Subsampling

* Cleanup and added tests

* Cleanup and added tests

* cleanup

* cleanup

* Single SubSample rate

* Cleanup

* Cleanup

* Variable name

* 13192221: Point to the Rl.Net nuget package from SDK dev drop (Azure#9)

* Adding test code for Model/Put api and moving to preview.3

* Johnhuang/13216589 reward activate local inference api (Azure#10)

* Update API view file

* 13216589: Add local inference reward api
13216590: Add local inference activate api

* Fix the comments

* Remove IsDisposed method

* Revert "Update API view file"

This reverts commit 0a4dcbf.

* Remove MultiSlotClient class as it is never used

* Add more change after other PRs were merged

* Revert "Add more change after other PRs were merged"

This reverts commit 35a3120.

* 13225147: Update API view file for thick client (Azure#11)

* 13225147: Update API view file for thick client

* Remove some suppressing warning

* Add more changes after 2 PRs were merged

* lazy load rank processor, refresh config  and relaod token on expiry (Azure#12)

* lazy load rank processor, refresh config  and relaod token on expiry

* Comments & Cleanup

* Cleanup

* Addressed comments

* Cleanup

* Fix conflict

Co-authored-by: John Huang <[email protected]>

* 13309375: Improve the tests by mocking LiveModel when test mode is (Azure#14)

* 13309375: Improve the tests by mocking LiveModel when test mode is
	  Playback but using real LiveModel when test mode is Live

* Change some public classes to private

* Address those comments in the main PR

* Update Microsoft.RL version

* Rename some properties

* Update Microsoft.RL version

* Fix spelling check

* Remove the unneeded warning

* Update live model config

* Use similar method names for export and import apis

* Johnhuang/13170630 address thick client sdk review (Azure#18)

* 13170630: Address comments from SDK review

* Update API view file

* Remove unnecessary file under Gerated folder

* Add more test for RLObjectConverter

* Remove unused parameter

* Remove unneeded comment

* Update recording sessions for tests that were changed in earlier commit. (Azure#19)

Co-authored-by: Personalizer Team <[email protected]>

* Update api view file after model api change (Azure#20)

* Rename modelStream to modelBody (Azure#21)

* Update Microsoft.RL version

* 13678440: Some cosmetic change to address comments from DotNet team (Azure#22)

* Update method names for Export/Import models as per suggestions. (Azure#23)

* Update method names for Export/Import models as per suggestions.

* Updates after running codecheck.ps1 script

Co-authored-by: Personalizer Team <[email protected]>

Co-authored-by: Tejaswi Paruchuri <[email protected]>
Co-authored-by: Tparuchuri <[email protected]>
Co-authored-by: Personalizer Team <[email protected]>
Co-authored-by: Sharath Malladi <[email protected]>
* Stop the processor when disposing listener

* PR fb
* Identity Updating Troubleshooting guide

* Update sdk/identity/Azure.Identity/TROUBLESHOOTING.md

Co-authored-by: Christopher Scott <[email protected]>

* Update sdk/identity/Azure.Identity/TROUBLESHOOTING.md

Co-authored-by: Christopher Scott <[email protected]>

* Update sdk/identity/Azure.Identity/TROUBLESHOOTING.md

Co-authored-by: Christopher Scott <[email protected]>

* Update sdk/identity/Azure.Identity/TROUBLESHOOTING.md

Co-authored-by: Christopher Scott <[email protected]>

* Update sdk/identity/Azure.Identity/TROUBLESHOOTING.md

Co-authored-by: Christopher Scott <[email protected]>

* Update sdk/identity/Azure.Identity/TROUBLESHOOTING.md

Co-authored-by: Christopher Scott <[email protected]>

* Update sdk/identity/Azure.Identity/TROUBLESHOOTING.md

Co-authored-by: Christopher Scott <[email protected]>

* fb

* fix links

* ungerunding headers

* Update sdk/identity/Azure.Identity/TROUBLESHOOTING.md

Co-authored-by: Christopher Scott <[email protected]>

* Update sdk/identity/Azure.Identity/TROUBLESHOOTING.md

Co-authored-by: Christopher Scott <[email protected]>

* Update sdk/identity/Azure.Identity/TROUBLESHOOTING.md

Co-authored-by: Christopher Scott <[email protected]>

* Update sdk/identity/Azure.Identity/TROUBLESHOOTING.md

Co-authored-by: Christopher Scott <[email protected]>

* more fb

* more fb

* Update sdk/identity/Azure.Identity/TROUBLESHOOTING.md

Co-authored-by: Christopher Scott <[email protected]>

* add additional help section

* fb

* add permission issues section

* fb

* make image link absolute

Co-authored-by: Christopher Scott <[email protected]>
* SDK generation from 2021-12-01 Compute Swagger

* AssemblyInfo Update

* Generated from main branch in Swagger repo

* added tests for Architecture (Azure#27217)

* added tests for Architecture

* updated tests

Co-authored-by: rytruong <[email protected]>

* adding customizations

* Disk tests recordings

* restore point test

* test recording

* fix customization, and CI

Co-authored-by: Ryan <[email protected]>
Co-authored-by: rytruong <[email protected]>
Co-authored-by: Theodore Chang <[email protected]>
…2-01-preview API (Azure#27178)

* Update SDK with generated contents, SDK version and mgmt metadata

* Recover transfer tests and update session records

* Add scope map, token and connected registry tests. Update Session Records

* PR Feedback: Delete resource dependencies
* Clean up unused codes and dependencies

* fix the only deleted files

Co-authored-by: sima-zhu <[email protected]>
1. change `DefaultScope` to return null when initialized by `default` keyword
2. improve the performance of `DefaultScope` a little bit
3. use common `HashCodebuilder` to generate the hash code

follow up of Azure#26635
* update to use common source for operation includes

* missed a remove from storage
* add lro enum

* add comments

* update api
* allow version override. update proxy-docker so that logging will work properly
* update targeted tags to common dev versioning scheme
* change to target_version.txt instead of a variable in docker-start-proxy.ps1

Co-authored-by: scbedd <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
@heaths
Copy link
Member

heaths commented Apr 4, 2022

Can you explain what you are trying to change? GitHub shows 250 commits and infinite files (typically well over a couple thousand files) changed in this PR, so was this the result of a bad merge perhaps? Understanding what you're trying to do could help get this sorted.

Typically, you'll fork this project and create a topic branch from main, commit your changes, then push to your fork. Submit a PR from that.

@heaths heaths added Do Not Merge needs-author-feedback Workflow: More information is needed from author to address the issue. labels Apr 4, 2022
@hari-bodicherla
Copy link
Contributor Author

Can you explain what you are trying to change? GitHub shows 250 commits and infinite files (typically well over a couple thousand files) changed in this PR, so was this the result of a bad merge perhaps? Understanding what you're trying to do could help get this sorted.

Typically, you'll fork this project and create a topic branch from main, commit your changes, then push to your fork. Submit a PR from that.

Abandoning this PR since there are multiple merge issues. and created new PR #27984 . Please take a look and review.

grizzlytheodore added a commit that referenced this pull request Apr 18, 2022
…rty in Dedicated Hosts for API version 2022-03-01 Compute #27949 (#27984)

* generated

* updated code

Co-authored-by: Theodore Chang <[email protected]>
grizzlytheodore added a commit that referenced this pull request May 10, 2022
…rty in Dedicated Hosts for API version 2022-03-01 Compute #27949 (#27984)

* generated

* updated code

Co-authored-by: Theodore Chang <[email protected]>
Yao725 pushed a commit that referenced this pull request May 13, 2022
* generated from new folder

* fix updateed object

* updated recordings for 2022-03-01

* new recordings

* last recordings and test fixes

* fix dedicated host test

* add ;

* mitigate failing test

* fix last test recording

* Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute #27949 (#27984)

* generated

* updated code

Co-authored-by: Theodore Chang <[email protected]>

* update with latest swagger form

* dedicatedHost customization

* small ssdk change 1.1 (#28006)

* [RestorePoints] InstanceView Fix SDK changes (#28188)

* sdk changes for instanview fix 1.1

* added record tests 2.1

Co-authored-by: Theodore Chang <[email protected]>

* SDK changes for Vmss Flex deleteOption (#27923)

* delete option vmss flex

* record test

* newline

* regenerated sdk

Co-authored-by: Kimberly Yip Chang <[email protected]>

* Updated tests for changes in PR Azure/azure-rest-api-specs#18609 (#28063)

* Generated SDK

* added tests, playback recordings for VM and VMSS application profile

(cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89)

* Fixed and re-recoded galley application and gallery application version tests

* Added changes that were created by SDK generation for dedicated HostGroup, but unrelated to my Swagger changes

* added changes to SdkInfo_ComputeManagementClient.cs and compute_resource-management.txt file that were created by SDK generation.

* Undid changes to eng/mgmt/mgmtmetadata/compute_resource-manager.txt

* Undid changes to sdk\compute\Microsoft.Azure.Management.Compute\src\Generated\SdkInfo_ComputeManagementClient.cs

* Re-created the SDK withhout changes to gallery.json and undid changes to test.

* Added test recordings for VM and VMSS application profile.

* remove changes from tests that were not re-recorded

Co-authored-by: Theodore Chang <[email protected]>

* generated from new folder

* fix updateed object

* updated recordings for 2022-03-01

* new recordings

* last recordings and test fixes

* fix dedicated host test

* add ;

* mitigate failing test

* fix last test recording

* Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute #27949 (#27984)

* generated

* updated code

Co-authored-by: Theodore Chang <[email protected]>

* update with latest swagger form

* dedicatedHost customization

* small ssdk change 1.1 (#28006)

* [RestorePoints] InstanceView Fix SDK changes (#28188)

* sdk changes for instanview fix 1.1

* added record tests 2.1

Co-authored-by: Theodore Chang <[email protected]>

* SDK changes for Vmss Flex deleteOption (#27923)

* delete option vmss flex

* record test

* newline

* regenerated sdk

Co-authored-by: Kimberly Yip Chang <[email protected]>

* Updated tests for changes in PR Azure/azure-rest-api-specs#18609 (#28063)

* Generated SDK

* added tests, playback recordings for VM and VMSS application profile

(cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89)

* Fixed and re-recoded galley application and gallery application version tests

* Added changes that were created by SDK generation for dedicated HostGroup, but unrelated to my Swagger changes

* added changes to SdkInfo_ComputeManagementClient.cs and compute_resource-management.txt file that were created by SDK generation.

* Undid changes to eng/mgmt/mgmtmetadata/compute_resource-manager.txt

* Undid changes to sdk\compute\Microsoft.Azure.Management.Compute\src\Generated\SdkInfo_ComputeManagementClient.cs

* Re-created the SDK withhout changes to gallery.json and undid changes to test.

* Added test recordings for VM and VMSS application profile.

* remove changes from tests that were not re-recorded

Co-authored-by: Theodore Chang <[email protected]>

* without preview release

* Delete VMApplicationProfile_Tests.json

* Delete TestVMScaleSetApplicationProfile.json

* fix VMTestBase for DH

* resolve tests

* update version name

* Sanitize SAS and key

* Update Microsoft.Azure.Management.Compute.csproj

Co-authored-by: hari-bodicherla <[email protected]>
Co-authored-by: prchin <[email protected]>
Co-authored-by: Kimberly Yip Chang <[email protected]>
Co-authored-by: Kimberly Yip Chang <[email protected]>
Co-authored-by: Bhaskar Brahma <[email protected]>
paterasMSFT pushed a commit that referenced this pull request Jun 15, 2022
* generated from new folder

* fix updateed object

* updated recordings for 2022-03-01

* new recordings

* last recordings and test fixes

* fix dedicated host test

* add ;

* mitigate failing test

* fix last test recording

* Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute #27949 (#27984)

* generated

* updated code

Co-authored-by: Theodore Chang <[email protected]>

* update with latest swagger form

* dedicatedHost customization

* small ssdk change 1.1 (#28006)

* [RestorePoints] InstanceView Fix SDK changes (#28188)

* sdk changes for instanview fix 1.1

* added record tests 2.1

Co-authored-by: Theodore Chang <[email protected]>

* SDK changes for Vmss Flex deleteOption (#27923)

* delete option vmss flex

* record test

* newline

* regenerated sdk

Co-authored-by: Kimberly Yip Chang <[email protected]>

* Updated tests for changes in PR Azure/azure-rest-api-specs#18609 (#28063)

* Generated SDK

* added tests, playback recordings for VM and VMSS application profile

(cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89)

* Fixed and re-recoded galley application and gallery application version tests

* Added changes that were created by SDK generation for dedicated HostGroup, but unrelated to my Swagger changes

* added changes to SdkInfo_ComputeManagementClient.cs and compute_resource-management.txt file that were created by SDK generation.

* Undid changes to eng/mgmt/mgmtmetadata/compute_resource-manager.txt

* Undid changes to sdk\compute\Microsoft.Azure.Management.Compute\src\Generated\SdkInfo_ComputeManagementClient.cs

* Re-created the SDK withhout changes to gallery.json and undid changes to test.

* Added test recordings for VM and VMSS application profile.

* remove changes from tests that were not re-recorded

Co-authored-by: Theodore Chang <[email protected]>

* generated from new folder

* fix updateed object

* updated recordings for 2022-03-01

* new recordings

* last recordings and test fixes

* fix dedicated host test

* add ;

* mitigate failing test

* fix last test recording

* Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute #27949 (#27984)

* generated

* updated code

Co-authored-by: Theodore Chang <[email protected]>

* update with latest swagger form

* dedicatedHost customization

* small ssdk change 1.1 (#28006)

* [RestorePoints] InstanceView Fix SDK changes (#28188)

* sdk changes for instanview fix 1.1

* added record tests 2.1

Co-authored-by: Theodore Chang <[email protected]>

* SDK changes for Vmss Flex deleteOption (#27923)

* delete option vmss flex

* record test

* newline

* regenerated sdk

Co-authored-by: Kimberly Yip Chang <[email protected]>

* Updated tests for changes in PR Azure/azure-rest-api-specs#18609 (#28063)

* Generated SDK

* added tests, playback recordings for VM and VMSS application profile

(cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89)

* Fixed and re-recoded galley application and gallery application version tests

* Added changes that were created by SDK generation for dedicated HostGroup, but unrelated to my Swagger changes

* added changes to SdkInfo_ComputeManagementClient.cs and compute_resource-management.txt file that were created by SDK generation.

* Undid changes to eng/mgmt/mgmtmetadata/compute_resource-manager.txt

* Undid changes to sdk\compute\Microsoft.Azure.Management.Compute\src\Generated\SdkInfo_ComputeManagementClient.cs

* Re-created the SDK withhout changes to gallery.json and undid changes to test.

* Added test recordings for VM and VMSS application profile.

* remove changes from tests that were not re-recorded

Co-authored-by: Theodore Chang <[email protected]>

* without preview release

* Delete VMApplicationProfile_Tests.json

* Delete TestVMScaleSetApplicationProfile.json

* fix VMTestBase for DH

* resolve tests

* update version name

* Sanitize SAS and key

* Update Microsoft.Azure.Management.Compute.csproj

Co-authored-by: hari-bodicherla <[email protected]>
Co-authored-by: prchin <[email protected]>
Co-authored-by: Kimberly Yip Chang <[email protected]>
Co-authored-by: Kimberly Yip Chang <[email protected]>
Co-authored-by: Bhaskar Brahma <[email protected]>
zhihaoxue pushed a commit to zhihaoxue/azure-sdk-for-net that referenced this pull request Jul 27, 2022
* generated from new folder

* fix updateed object

* updated recordings for 2022-03-01

* new recordings

* last recordings and test fixes

* fix dedicated host test

* add ;

* mitigate failing test

* fix last test recording

* Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute Azure#27949 (Azure#27984)

* generated

* updated code

Co-authored-by: Theodore Chang <[email protected]>

* update with latest swagger form

* dedicatedHost customization

* small ssdk change 1.1 (Azure#28006)

* [RestorePoints] InstanceView Fix SDK changes (Azure#28188)

* sdk changes for instanview fix 1.1

* added record tests 2.1

Co-authored-by: Theodore Chang <[email protected]>

* SDK changes for Vmss Flex deleteOption (Azure#27923)

* delete option vmss flex

* record test

* newline

* regenerated sdk

Co-authored-by: Kimberly Yip Chang <[email protected]>

* Updated tests for changes in PR Azure/azure-rest-api-specs#18609 (Azure#28063)

* Generated SDK

* added tests, playback recordings for VM and VMSS application profile

(cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89)

* Fixed and re-recoded galley application and gallery application version tests

* Added changes that were created by SDK generation for dedicated HostGroup, but unrelated to my Swagger changes

* added changes to SdkInfo_ComputeManagementClient.cs and compute_resource-management.txt file that were created by SDK generation.

* Undid changes to eng/mgmt/mgmtmetadata/compute_resource-manager.txt

* Undid changes to sdk\compute\Microsoft.Azure.Management.Compute\src\Generated\SdkInfo_ComputeManagementClient.cs

* Re-created the SDK withhout changes to gallery.json and undid changes to test.

* Added test recordings for VM and VMSS application profile.

* remove changes from tests that were not re-recorded

Co-authored-by: Theodore Chang <[email protected]>

* generated from new folder

* fix updateed object

* updated recordings for 2022-03-01

* new recordings

* last recordings and test fixes

* fix dedicated host test

* add ;

* mitigate failing test

* fix last test recording

* Generated SDK modules and recorded tests for UltraSSDCapability property in Dedicated Hosts for API version 2022-03-01 Compute Azure#27949 (Azure#27984)

* generated

* updated code

Co-authored-by: Theodore Chang <[email protected]>

* update with latest swagger form

* dedicatedHost customization

* small ssdk change 1.1 (Azure#28006)

* [RestorePoints] InstanceView Fix SDK changes (Azure#28188)

* sdk changes for instanview fix 1.1

* added record tests 2.1

Co-authored-by: Theodore Chang <[email protected]>

* SDK changes for Vmss Flex deleteOption (Azure#27923)

* delete option vmss flex

* record test

* newline

* regenerated sdk

Co-authored-by: Kimberly Yip Chang <[email protected]>

* Updated tests for changes in PR Azure/azure-rest-api-specs#18609 (Azure#28063)

* Generated SDK

* added tests, playback recordings for VM and VMSS application profile

(cherry picked from commit c08e89b426bb6dd41b9a37ecb3d42ad172509f89)

* Fixed and re-recoded galley application and gallery application version tests

* Added changes that were created by SDK generation for dedicated HostGroup, but unrelated to my Swagger changes

* added changes to SdkInfo_ComputeManagementClient.cs and compute_resource-management.txt file that were created by SDK generation.

* Undid changes to eng/mgmt/mgmtmetadata/compute_resource-manager.txt

* Undid changes to sdk\compute\Microsoft.Azure.Management.Compute\src\Generated\SdkInfo_ComputeManagementClient.cs

* Re-created the SDK withhout changes to gallery.json and undid changes to test.

* Added test recordings for VM and VMSS application profile.

* remove changes from tests that were not re-recorded

Co-authored-by: Theodore Chang <[email protected]>

* without preview release

* Delete VMApplicationProfile_Tests.json

* Delete TestVMScaleSetApplicationProfile.json

* fix VMTestBase for DH

* resolve tests

* update version name

* Sanitize SAS and key

* Update Microsoft.Azure.Management.Compute.csproj

Co-authored-by: hari-bodicherla <[email protected]>
Co-authored-by: prchin <[email protected]>
Co-authored-by: Kimberly Yip Chang <[email protected]>
Co-authored-by: Kimberly Yip Chang <[email protected]>
Co-authored-by: Bhaskar Brahma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge needs-author-feedback Workflow: More information is needed from author to address the issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.