Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Personalizer] Thick client feature and Model Put API #26828

Merged
merged 36 commits into from
Mar 1, 2022
Merged

[Personalizer] Thick client feature and Model Put API #26828

merged 36 commits into from
Mar 1, 2022

Conversation

johnhuang01
Copy link
Contributor

@johnhuang01 johnhuang01 commented Feb 7, 2022 •
edited
Loading

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@ghost ghost added Azure.Core customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Feb 7, 2022
@ghost
Copy link

ghost commented Feb 7, 2022

Thank you for your contribution @johnhuang01! We will review the pull request and get back to you soon.

@ghost ghost added the Community Contribution Community members are working on the issue label Feb 7, 2022
@ghost
Copy link

ghost commented Feb 7, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@check-enforcer
Copy link

check-enforcer bot commented Feb 7, 2022

This pull request is protected by Check Enforcer.
For more information about how to run a pipeline against this pull request, see this.

johnhuang01 and others added 15 commits February 7, 2022 16:19
@johnhuang01
12767912: Add isLocalInference in the public SDK
c9072da
@johnhuang01
Rename the variable
2dc705e
@johnhuang01 @Tparuchuri
Thick clent feature (#5)
926c450 
* 12767907: Add a package dependency on Microsoft.RL

* Add RankProcessor

* Remove unused file

* Remove some key

* Toggle commented codes so that most tests can pass

* Getting the required config details for rankprocessor to enable livemode

* Updating the wrong variable name

* Cleanup

* Revert "12767907: Add a package dependency on Microsoft.RL"

This reverts commit c586920.

* Revert "Add RankProcessor"

This reverts commit 43967d3.

* Revert "Remove unused file"

This reverts commit 1e400a8.

* Revert "Toggle commented codes so that most tests can pass"

This reverts commit 7ec50ec.

* Delete DisposeHelper.cs

* Revert "Revert "12767907: Add a package dependency on Microsoft.RL""

This reverts commit d6df6b5.

* Cleanup after reverting

* generating client configuration using autorest

* Revert "generating client configuration using autorest"

This reverts commit 6b75695.

* Configuration details for livemodel

* cleanup

* cleanup

* Added ToDo comments

* correct the version in endpoints

Co-authored-by: Tejaswi Paruchuri <[email protected]>
Co-authored-by: Tparuchuri <[email protected]>
@johnhuang01
12768045: Add rank processor for single slot (#3)
526b2bb 
Add RankProcessor

Remove unused file

Remove some key

Toggle commented codes so that most tests can pass

RankProcessor is working. Still need to clean up the codes

Add test json files

only construct LiveModel when localInference is true

Move rankprocessor to under model

Add latest generated files from autorest

Add autogenerated files from autorest

Fix the setting in DecisionContext

Remove wrong comment

Revert unexpected auto-generated file changes

Addressed a comment

Move suppression to GlobalSuppressions.cs

Remove the decoration in MultiSlotClient.cs

Refactor rankProcessor so that the actions is not modified and restored;
added a converter between sdk and Rl.Net; replace Newtonsoft.json with
System.Text.Json

Address comments

Refactor RlObjuectConverter; remove some unneeded setters, etc.

Added unit tests for RlObjectConverter, DecisionContext,
JsonRawStringListConverter

Remove unused using
@johnhuang01
13009290: Create RankProcessor class to Azure Personalizer client lib…
4284717 
…rary for .NET for multi slot (#7)

* 13009290: Create RankProcessor class to Azure Personalizer client
              library for .NET for multi slot

* Address comments
@Tparuchuri @johnhuang01
Subsampling
4c40b50
@Tparuchuri @johnhuang01
Cleanup and added tests
63bffb9
@Tparuchuri @johnhuang01
Cleanup and added tests
625033e
@Tparuchuri @johnhuang01
cleanup
fb0fd6a
@Tparuchuri @johnhuang01
cleanup
d5058a5
@Tparuchuri @johnhuang01
Single SubSample rate
329c0af
@Tparuchuri @johnhuang01
Cleanup
954818a
@Tparuchuri @johnhuang01
Cleanup
43210dd
@Tparuchuri @johnhuang01
Variable name
d99d43f
@johnhuang01
13192221: Point to the Rl.Net nuget package from SDK dev drop (#9)
9b1c3b0
@JoshLove-msft JoshLove-msft mentioned this pull request Feb 8, 2022
Closed
Personalizer Team and others added 4 commits February 8, 2022 10:17
Adding test code for Model/Put api and moving to preview.3
93fd434
@sharathmalladi
Merge pull request #13 from sharathmalladi/users/sharathm/model_put
137a442 
Adding test code for Model/Put api and moving to preview.3
@johnhuang01
Johnhuang/13216589 reward activate local inference api (#10)
740f238 
* Update API view file

* 13216589: Add local inference reward api
13216590: Add local inference activate api

* Fix the comments

* Remove IsDisposed method

* Revert "Update API view file"

This reverts commit 0a4dcbf.

* Remove MultiSlotClient class as it is never used
@johnhuang01
Add more change after other PRs were merged
35a3120
johnhuang01 and others added 3 commits February 14, 2022 17:03
@johnhuang01
13309375: Improve the tests by mocking LiveModel when test mode is (#14)
356fcbc 
* 13309375: Improve the tests by mocking LiveModel when test mode is
	  Playback but using real LiveModel when test mode is Live

* Change some public classes to private

* Address those comments in the main PR

* Update Microsoft.RL version

* Rename some properties

* Update Microsoft.RL version
@johnhuang01
Fix spelling check
0526ce9
@johnhuang01
Remove the unneeded warning
5a49312
@johnhuang01 johnhuang01 marked this pull request as ready for review February 15, 2022 20:38
@johnhuang01 johnhuang01 changed the title Thick client feature Thick client feature and Model Put API Feb 15, 2022
@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.AI.Personalizer. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.AI.Personalizer. You can review API changes here

@johnhuang01
Johnhuang/13170630 address thick client sdk review (#18)
30aca4c 
* 13170630: Address comments from SDK review

* Update API view file

* Remove unnecessary file under Gerated folder

* Add more test for RLObjectConverter

* Remove unused parameter

* Remove unneeded comment
@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.AI.Personalizer. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.AI.Personalizer. You can review API changes here

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.AI.Personalizer. You can review API changes here

@sharathmalladi
Update method names for Export/Import models as per suggestions. (#23)
65e7fa7 
* Update method names for Export/Import models as per suggestions.

* Updates after running codecheck.ps1 script

Co-authored-by: Personalizer Team <[email protected]>
@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.AI.Personalizer. You can review API changes here

@Mohit-Chakraborty Mohit-Chakraborty changed the title Thick client feature and Model Put API [Personalizer] Thick client feature and Model Put API Mar 1, 2022
@Mohit-Chakraborty Mohit-Chakraborty merged commit e7f6846 into Azure:main Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshLove-msft JoshLove-msft JoshLove-msft left review comments

@Mohit-Chakraborty Mohit-Chakraborty Mohit-Chakraborty approved these changes

@KrzysztofCwalina KrzysztofCwalina Awaiting requested review from KrzysztofCwalina

@tg-msft tg-msft Awaiting requested review from tg-msft

@orenmichaely orenmichaely Awaiting requested review from orenmichaely

@tyclintw tyclintw Awaiting requested review from tyclintw

Assignees
No one assigned
Labels
Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@johnhuang01 @azure-sdk @Mohit-Chakraborty @JoshLove-msft @Tparuchuri @sharathmalladi