Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lro enum #27284

Merged
merged 3 commits into from
Mar 2, 2022
Merged

Add lro enum #27284

merged 3 commits into from
Mar 2, 2022

Conversation

m-nash
Copy link
Member

@m-nash m-nash commented Mar 2, 2022

Contributing to the Azure SDK

Adding a new LRO enum to indicate if the method should wait for full completion or return after it has started.

Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.

For specific information about pull request etiquette and best practices, see this section.

@azure-sdk
Copy link
Collaborator

API changes have been detected in Azure.Core. You can review API changes here

API changes

+     public enum WaitUntil {
+         Completed = 0,
+         Started = 1,
+     }

@check-enforcer
Copy link

check-enforcer bot commented Mar 2, 2022

This pull request is protected by Check Enforcer.
For more information about how to run a pipeline against this pull request, see this.

@m-nash m-nash requested a review from tg-msft as a code owner March 2, 2022 01:54
Copy link
Member

@annelo-msft annelo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add tests to illustrate the intended usage of this type.

Are updates needed to any of the Operation* types to enforce usage of this type, or is there an issue tracking that work?

@m-nash
Copy link
Member Author

m-nash commented Mar 2, 2022

We should add tests to illustrate the intended usage of this type.

Are updates needed to any of the Operation* types to enforce usage of this type, or is there an issue tracking that work?

No real way to enforce this, you can easily use an Operation object as a return for a method that does not have this parameter. This would be the new standard going forward for LRO methods however which are initially being enforced only in generated clients like LLC and Mgmt

@annelo-msft
Copy link
Member

Looks like we have this issue tracking the work I mentioned - I just added the Azure.Core label so it doesn't get lost.

#25716

@m-nash m-nash merged commit 03191ea into main Mar 2, 2022
@m-nash m-nash deleted the mnash-lroEnum branch March 2, 2022 17:32
yanfa317 pushed a commit to yanfa317/azure-sdk-for-net that referenced this pull request Mar 8, 2022
* add lro enum

* add comments

* update api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants