-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextAnalytics] Added DisableServiceLogs property to ExtractSummaryAction #22803
[TextAnalytics] Added DisableServiceLogs property to ExtractSummaryAction #22803
Conversation
@@ -30,6 +30,16 @@ public ExtractSummaryAction() | |||
/// </summary> | |||
public string ModelVersion { get; set; } | |||
|
|||
/// <summary> | |||
/// The default value of this property is 'true'. This means, Text Analytics service won't log your input text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the default for this is false. It should be true only for actions that process sensitive data such as healthcare and pii.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing this out. Hadn't realized they are different depending on the type of action. Updating it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm interesting. The swagger does have this defaulting to True. I'll ask on the PR. https://github.com/Azure/azure-rest-api-specs/blob/d758c4205d331c552cafbb755ed02673b9fa5e22/specification/cognitiveservices/data-plane/TextAnalytics/preview/v3.2-preview.1/TextAnalytics.json#L810
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll merge this PR to unblock the next ones (keeping it 'false' for now). Created #22809 for tracking.
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For data-plane/track 2 SDKs Issue the following command as a pull request comment:
For track 1 management-plane SDKsPlease open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification. |
…23109) * [TextAnalytics] Generating code from 3.2-preview.1 swagger (#22774) * [TextAnalytics] Implemented ExtractiveSummarization input (#22791) Co-authored-by: Mariana Rios Flores <[email protected]> * [TextAnalytics] Added DisableServiceLogs property to ExtractSummaryAction (#22803) * [TextAnalytics] Remaining Extractive Text Summarization implementation work (#22841) Co-authored-by: Deyaaeldeen Almahallawi <[email protected]> * [TextAnalytics] Added model factory for extractive summarization models (#22873) * [TextAnalytics] SummarySentece is now a struct (#22915) * [TextAnalytics] Recording old tests with service version 3.2-preview.1 (#23078) * [TextAnalytics] Added sample for Extractive Text Summarization (#23097) Co-authored-by: Mariana Rios Flores <[email protected]> Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
Fixes #22799.
Regenerated the code from the latest swagger. This made it possible for us to add the missing
DisableServiceLogs
property to theExtractSummaryAction
class.