Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextAnalytics] Added DisableServiceLogs property to ExtractSummaryAction #22803

Merged
merged 4 commits into from
Jul 22, 2021

Conversation

kinelski
Copy link
Member

Fixes #22799.

Regenerated the code from the latest swagger. This made it possible for us to add the missing DisableServiceLogs property to the ExtractSummaryAction class.

@kinelski kinelski added the Client This issue points to a problem in the data-plane of the library. label Jul 22, 2021
@kinelski kinelski self-assigned this Jul 22, 2021
@kinelski kinelski marked this pull request as ready for review July 22, 2021 21:50
@@ -30,6 +30,16 @@ public ExtractSummaryAction()
/// </summary>
public string ModelVersion { get; set; }

/// <summary>
/// The default value of this property is 'true'. This means, Text Analytics service won't log your input text.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the default for this is false. It should be true only for actions that process sensitive data such as healthcare and pii.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out. Hadn't realized they are different depending on the type of action. Updating it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this PR to unblock the next ones (keeping it 'false' for now). Created #22809 for tracking.

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

@kinelski kinelski merged commit 63ba0fe into Azure:feature/textanalytics/summarization Jul 22, 2021
@kinelski kinelski deleted the ta-logs branch July 22, 2021 23:46
kinelski added a commit that referenced this pull request Aug 4, 2021
…23109)

* [TextAnalytics] Generating code from 3.2-preview.1 swagger (#22774)

* [TextAnalytics] Implemented ExtractiveSummarization input (#22791)

Co-authored-by: Mariana Rios Flores <[email protected]>

* [TextAnalytics] Added DisableServiceLogs property to ExtractSummaryAction (#22803)

* [TextAnalytics] Remaining Extractive Text Summarization implementation work (#22841)

Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>

* [TextAnalytics] Added model factory for extractive summarization models (#22873)

* [TextAnalytics] SummarySentece is now a struct (#22915)

* [TextAnalytics] Recording old tests with service version 3.2-preview.1 (#23078)

* [TextAnalytics] Added sample for Extractive Text Summarization (#23097)

Co-authored-by: Mariana Rios Flores <[email protected]>
Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants