[TextAnalytics] Implemented ExtractiveSummarization input

[kinelski]

Part of #22773.

[maririos]

Suggested change

	/// to the text input, as decided by the service. Defaults to <see cref="SummarySentencesOrder.Offset"/>.
	/// to the document input, as decided by the service. Defaults to <see cref="SummarySentencesOrder.Offset"/>.

[maririos]

Do you think we should do the default in a remarks?

[kinelski]

We don't do it in the remarks in other properties. For example, in other actions:

        /// <summary>
        /// The default value of this property is 'false'. This means, Text Analytics service logs your input text for 48 hours,
        /// solely to allow for troubleshooting issues.
        /// Setting this property to true, disables input logging and may limit our ability to investigate issues that occur.
        /// <para>
        /// Please see Cognitive Services Compliance and Privacy notes at <see href="https://aka.ms/cs-compliance"/> for additional details,
        /// and Microsoft Responsible AI principles at <see href="https://www.microsoft.com/ai/responsible-ai"/>.
        /// </para>
        /// </summary>
        /// <remarks>
        /// This property only applies for <see cref="TextAnalyticsClientOptions.ServiceVersion.V3_1"/> and up.
        /// </remarks>
        public bool? DisableServiceLogs { get; set; }

So I put it in the summary section for consistency.

[kristapratico]

LGTM

[deyaaeldeen]

Can we add a test for a single action case with a long document? e.g. JS uses: https://github.com/Azure/azure-sdk-for-js/blob/7e1680e3f8a82e5f41c1c8ccdfa433f9f2c250c0/sdk/textanalytics/ai-text-analytics/test/public/textAnalyticsClient.spec.ts#L930

[kinelski]

This would be a live test, so I can only add it when the output side is implemented. Do you have tests for long documents in all endpoints in JS or this is something added only for extractive text summarization?

[deyaaeldeen]

I can only add it when the output side is implemented.

To clarify, you're saying processing the response received from the service is not yet implement in the SDK? that is fine if so.

The nature of the input document depends on the action you want to apply to it so in this case I think a long document is needed to make sure we get a useful summary.

[kinelski]

To clarify, you're saying processing the response received from the service is not yet implement in the SDK?

Correct. We just have the "sending" part implemented in this PR.

[deyaaeldeen]

The implementation looks good. I left one comment about adding a test case.

[check-enforcer]

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.