Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TextAnalytics] Generating code from 3.2-preview.1 swagger #22774

Merged

Conversation

kinelski
Copy link
Member

@kinelski kinelski commented Jul 21, 2021

Part of #22773.

@kinelski kinelski added the Client This issue points to a problem in the data-plane of the library. label Jul 21, 2021
@kinelski kinelski marked this pull request as ready for review July 21, 2021 19:02
/// <summary>
/// ExtractiveSummarizationTasks
/// </summary>
public IList<ExtractiveSummarizationTask> ExtractiveSummarizationTasks { get; set; }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not that it really matters, but to go with the flow, u can make this type internal

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean the ExtractiveSummarizationTask type? It is generated as an internal type by default.

@kinelski
Copy link
Member Author

macOS is failing even before starting the tests. Other OSs are passing, so doesn't seem related to the changes in this PR. We'll test macOS property when merging changes from the feature branch into main.

@kinelski kinelski merged commit 14bb340 into Azure:feature/textanalytics/summarization Jul 21, 2021
@kinelski kinelski deleted the ta-swagger branch July 21, 2021 19:48
kinelski added a commit that referenced this pull request Aug 4, 2021
…23109)

* [TextAnalytics] Generating code from 3.2-preview.1 swagger (#22774)

* [TextAnalytics] Implemented ExtractiveSummarization input (#22791)

Co-authored-by: Mariana Rios Flores <[email protected]>

* [TextAnalytics] Added DisableServiceLogs property to ExtractSummaryAction (#22803)

* [TextAnalytics] Remaining Extractive Text Summarization implementation work (#22841)

Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>

* [TextAnalytics] Added model factory for extractive summarization models (#22873)

* [TextAnalytics] SummarySentece is now a struct (#22915)

* [TextAnalytics] Recording old tests with service version 3.2-preview.1 (#23078)

* [TextAnalytics] Added sample for Extractive Text Summarization (#23097)

Co-authored-by: Mariana Rios Flores <[email protected]>
Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Feb 23, 2023
[Microsoft.ConfidentialLedger] Add node count property to managed CCF resource type (Azure#22774)

* Add node count property as mCCF property

* Format json and node count property
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Text Analytics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants