-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated models to handle nullable and make events properties readonly #21978
Closed
navali-msft
wants to merge
167
commits into
feature/communication-ServerCalling-preview2
from
navali/models-update
Closed
Updated models to handle nullable and make events properties readonly #21978
navali-msft
wants to merge
167
commits into
feature/communication-ServerCalling-preview2
from
navali/models-update
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…21550) * Fixed regression in BlobProperties where IsLatestVersion was not setting the value * Rerecorded one more test * Update BlobProperties to set properties by using internal constructor * Updated tests to remove unused BlobProperties * Make BlobProperties properties internal
* Move WebPubSub to LLC + extensions * Small changes * Moved to LLC + extensions * changes * Finished moving to generated surface area * updated API file * PR review feedback incorporated * regenerated APIs * fixed a bug
* Update README.md adding dependency injection section * Update README.md Proposing changes based on the chat with @KrzysztofCwalina and @davidfowl. The changes are around simplifying the samples and using the configuration instead of the hard coded connection string. * Update README.md Change the method named used and show the configuration snippet as well. * Update sdk/servicebus/Azure.Messaging.ServiceBus/README.md Co-authored-by: Scott Addie <[email protected]> * Update sdk/servicebus/Azure.Messaging.ServiceBus/README.md Co-authored-by: Scott Addie <[email protected]> * minor edits Co-authored-by: Alex Ghiondea <[email protected]> Co-authored-by: Scott Addie <[email protected]>
The focus of these changes is to clamp the calculation for the natural delay (before it is clamped to the `MaxDelay`) to prevent overflowing the `TimeSpan` type.
* add AuthenticationScope client option * formatting * nit * Update sdk/containerregistry/Azure.Containers.ContainerRegistry/src/ContainerRegistryClientOptions.cs Co-authored-by: Jeremy Meng <[email protected]> * add negative test for AuthenticationScope * add directions to the README * nits * fix auth scope setting in recorded tests * remove lines * removing negative test since we don't record calls from identity * update API * updates to README * nit Co-authored-by: Jeremy Meng <[email protected]>
Update AutoRest C# version to 3.0.0-beta.20210603.1
The focus of these changes is to expose an additional set of connection options for configuring the transport. Included are options for - A custom send buffer size - A custom receive buffer size - A delegate to participate in SSL certificate validation
Co-authored-by: Ben Broderick Phillips <[email protected]>
Co-authored-by: Ben Broderick Phillips <[email protected]>
* API feedback changes
* Update ShareLink sample Fixes #21543 * Include auto-gen sources
* this gets allocations in line. but isn't great. * temporarily disable the probe. * try Azure/autorest#4152 * Revert "temporarily disable the probe." This reverts commit f5d1587. * fix empty path. * mocking. * fix 403. * I really dislike url-encoding... * private protected. nice. * fix tests. * datalake. * fix that. * shares. * queues * batch. * this works. * this works. too.
* Support cloud event handshake * Fix CloudEvent handshake * Update README * Fix * Update sdk/eventgrid/Microsoft.Azure.WebJobs.Extensions.EventGrid/src/TriggerBinding/HttpRequestProcessor.cs Co-authored-by: Jesse Squire <[email protected]> Co-authored-by: Jesse Squire <[email protected]>
* Batch receive fixes * Use AwaitWithCancellation * volatile * Remove unnecessary catch * Fix tests * Fix flaky tests * Fix test
navali-msft
requested review from
dpwatrous,
fabiocav,
heaths,
idear1203,
jfggdl,
JialinXin,
JoshLove-msft,
jsquire,
kasobol-msft,
kinelski,
Kishp01,
m-nash,
maririos,
markcowl,
mathewc,
mitchdenny,
Mohit-Chakraborty,
nisha-bhatia,
pakrym,
paterasMSFT,
rasidhan,
schaabs,
seanmcc-msft,
serkantkaraca,
vicancy,
weshaggard,
YalinLi0312 and
yeskarthik
as code owners
June 18, 2021 22:43
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Feb 1, 2023
Machinelearningservices microsoft.machine learning services 2022 12 01 preview (Azure#21761) * Adds base for updating Microsoft.MachineLearningServices from version preview/2022-10-01-preview to version 2022-12-01-preview * Updates readme * Updates API version in new specs and examples * Add Dec API Registries Swagger (Azure#21419) * add december registries swagger + examples * add status code 202 in examples * fix 202 examples * fixes * fixes * fix * add 202 back in for put/patch Co-authored-by: Komal Yadav <[email protected]> * remove location (Azure#21430) Co-authored-by: Komal Yadav <[email protected]> * remove readonly flag on schedules property for CI (Azure#21653) Co-authored-by: Naman Agarwal <[email protected]> * add missing workspace properties (Azure#21725) * December preview updating mfe.json specs (Azure#21510) * December preview updating mfe.json specs * MFE Dec 2022 Preview API - Adding logbase * MFE 2022-12-01-preview swagger spec model validation fix * MFE 2022-12-01-preview swagger spec model validation fix, add missing location * MFE 2022-12-01-preview swagger spec model validation - typo fix * MFE 2022-12-01-preview swagger spec model validation - fix api version in automljob example * MFE 2022-12-01-preview swagger spec model validation - fix for multiselectenabled error * MFE 2022-12-01-preview swagger spec model validation - fix for multiselectenabled error * Fix for 1006 - RemovedDefinition (RecurrenceTrigger,CronTrigger) (Azure#21822) * fix ReadonlyPropertyChanged of MLC (Azure#21814) Co-authored-by: Bingchen Li <[email protected]> * fixed custom-words conflict (Azure#21829) * fix custom-words conflict merge (Azure#21830) * example fix (INVALID_REQUEST_PARAMETER) (Azure#21832) Co-authored-by: Ivaliy Ivanov <[email protected]> * example fix, use correct api preview version - (INVALID_REQUEST_PARAMETER) (Azure#21833) Co-authored-by: Ivaliy Ivanov <[email protected]> * Revert breaking change for MLC swagger 2022-12-01-preview (Azure#21885) Co-authored-by: Bingchen Li <[email protected]> * Revert Connection Category back to enum. (Azure#21939) * revert provisioning state change (Azure#21940) * remove body (Azure#21978) Co-authored-by: Komal Yadav <[email protected]> * Addressed comments, added x-ms-long-running-operation to a patch call (Azure#22005) * Addressed comments, added x-ms-long-running-operation to a patch call * fix examples for patch - remove body * fixed formatting * Ivalbert fix patch2 (Azure#22006) * Addressed comments, added x-ms-long-running-operation to a patch call * fix examples for patch - remove body * fixed formatting * fixed formatting * Updated custom words (Azure#22262) * Fixed prettier errors (Azure#22237) * fixed examples for LRO_RESPONSE_HEADER check (Azure#22293) * fixed examples for LRO_RESPONSE_HEADER check (Azure#22294) * Example fix - OBJECT_MISSING_REQUIRED_PROPERTY - Missing required property: triggerType (Azure#22317) --------- Co-authored-by: Komal Yadav <[email protected]> Co-authored-by: Komal Yadav <[email protected]> Co-authored-by: Naman Agarwal <[email protected]> Co-authored-by: Naman Agarwal <[email protected]> Co-authored-by: ZhidaLiu <[email protected]> Co-authored-by: libc16 <[email protected]> Co-authored-by: Bingchen Li <[email protected]> Co-authored-by: Ivaliy Ivanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new service
label and/or contact assigned reviewer.If the check fails at the
Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1
. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1
to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.