-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PlayAudio Api on ConversationClient (Out-Call Scenario) #21430
Merged
Paresh-Arvind-Patil
merged 6 commits into
feature/communication-ServerCalling-preview1
from
dev/papati/adding_playAudio_api_for_out-call
May 28, 2021
Merged
Added PlayAudio Api on ConversationClient (Out-Call Scenario) #21430
Paresh-Arvind-Patil
merged 6 commits into
feature/communication-ServerCalling-preview1
from
dev/papati/adding_playAudio_api_for_out-call
May 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Communication
label
May 27, 2021
Paresh-Arvind-Patil
requested review from
zihzhan-msft,
navali-msft,
chrwhit,
bharat-kalyan-namburi,
ajaych-ms and
arifsaikat-microsoft
and removed request for
zihzhan-msft
May 27, 2021 22:33
sdk/communication/Azure.Communication.Calling.Server/src/ConversationClient.cs
Show resolved
Hide resolved
chrwhit
reviewed
May 27, 2021
sdk/communication/Azure.Communication.Calling.Server/src/ConversationClient.cs
Show resolved
Hide resolved
chrwhit
reviewed
May 27, 2021
sdk/communication/Azure.Communication.Calling.Server/src/Generated/ConversationRestClient.cs
Outdated
Show resolved
Hide resolved
chrwhit
reviewed
May 27, 2021
sdk/communication/Azure.Communication.Calling.Server/src/swagger/Sample-Swagger.json
Outdated
Show resolved
Hide resolved
bharat-kalyan-namburi
approved these changes
May 28, 2021
ajaych-ms
reviewed
May 28, 2021
...ion/Azure.Communication.Calling.Server/tests/ConversationClients/ConversationClientsTests.cs
Show resolved
Hide resolved
ajaych-ms
approved these changes
May 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paresh-Arvind-Patil
merged commit May 28, 2021
ba8e7a9
into
feature/communication-ServerCalling-preview1
Paresh-Arvind-Patil
deleted the
dev/papati/adding_playAudio_api_for_out-call
branch
May 28, 2021 22:18
minnieliu
pushed a commit
that referenced
this pull request
Jun 8, 2021
* Onboard ServerCalling feature project. * Onboard Server Calling Test project. * Onboard Server Calling Test project. * New apis and models for different operations. * Update Recorded Test files. * Naming changes and fix build. * Resolve comments. * Removed operationContext from Recording apis (#21309) Co-authored-by: Paresh Arvind Patil <[email protected]> * Onboard ServerCalling feature project. * Onboard Server Calling Test project. * New apis and models for different operations. * Onboard Server Calling Test project. * Update Recorded Test files. * Naming changes and fix build. * Resolve comments. * Address comments. * Fix build * Fixed the typo CallRecordingStateChangeEvent EventType (#21434) Co-authored-by: Paresh Arvind Patil <[email protected]> * remove remaining context & request (#21437) * Update swagger. * Update swagger link to a perm url. * Added PlayAudio Api on ConversationClient (Out-Call Scenario) (#21430) * Added playAudio and cancelMedia api for out-call * Added PlayAudio api on ConversationClient * Updated the PlayAudio url description * Updated as per PR feedback * Re-build the swagger updating the auto-genrated files Co-authored-by: Paresh Arvind Patil <[email protected]> * Udpate Sdk based on new Swagger. * Update API version. * Address comments. * Update apis with new swagger, address CallState enum. * Update Live test to use Instrumented Client. * Fix broken link * Fix broken link * Fix broken link * Adding AudioFileId and CallbackUri parameter in PlayAudio Api (Out-Call) (#21503) * Adding AudioFileId and callbackuri for PlayAudio Api out-call * minor fixes * Made Param optional Co-authored-by: Paresh Arvind Patil <[email protected]> * Mark failed live test as Ignore to unblock build. * Added events in the swagger, added model for creating serializer, com… (#21535) * Added events in the swagger, added model for creating serializer, comments updated, invite participant change to add participant * comments fix. * fixes based on comments * Set operation context as optional and last parameter * NIT fix * NIT fix (#21540) * Fix build Analyze. * Fix build Analyze. * Minor fix for ConvClient joinCall api. * Minor fix for ConvClient joinCall api. (#21558) * Address comments. * Added unit test for recording apis (#21578) Co-authored-by: Paresh Arvind Patil <[email protected]> * Address comments. * Specify parameters in RestApiCall. * Update Namespace to CallingServer. * Update links in md files. * Update links in md files. * Update CallClient.cs * Update ConversationClient.cs * Feature/zihzhan livetesting (#21677) * Enable living testing. * Test Playback. * Add playaudio test record. * Add createcall test record. * Add delete call record. * Add hangup call test record. * Add cancelAllMediaOperations call test record. * Enable living tests. * Address comments. Co-authored-by: Naveed Ali <[email protected]> Co-authored-by: Paresh Arvind Patil <[email protected]> Co-authored-by: Paresh Arvind Patil <[email protected]> Co-authored-by: navali-msft <[email protected]>
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
Feb 1, 2023
Machinelearningservices microsoft.machine learning services 2022 12 01 preview (Azure#21761) * Adds base for updating Microsoft.MachineLearningServices from version preview/2022-10-01-preview to version 2022-12-01-preview * Updates readme * Updates API version in new specs and examples * Add Dec API Registries Swagger (Azure#21419) * add december registries swagger + examples * add status code 202 in examples * fix 202 examples * fixes * fixes * fix * add 202 back in for put/patch Co-authored-by: Komal Yadav <[email protected]> * remove location (Azure#21430) Co-authored-by: Komal Yadav <[email protected]> * remove readonly flag on schedules property for CI (Azure#21653) Co-authored-by: Naman Agarwal <[email protected]> * add missing workspace properties (Azure#21725) * December preview updating mfe.json specs (Azure#21510) * December preview updating mfe.json specs * MFE Dec 2022 Preview API - Adding logbase * MFE 2022-12-01-preview swagger spec model validation fix * MFE 2022-12-01-preview swagger spec model validation fix, add missing location * MFE 2022-12-01-preview swagger spec model validation - typo fix * MFE 2022-12-01-preview swagger spec model validation - fix api version in automljob example * MFE 2022-12-01-preview swagger spec model validation - fix for multiselectenabled error * MFE 2022-12-01-preview swagger spec model validation - fix for multiselectenabled error * Fix for 1006 - RemovedDefinition (RecurrenceTrigger,CronTrigger) (Azure#21822) * fix ReadonlyPropertyChanged of MLC (Azure#21814) Co-authored-by: Bingchen Li <[email protected]> * fixed custom-words conflict (Azure#21829) * fix custom-words conflict merge (Azure#21830) * example fix (INVALID_REQUEST_PARAMETER) (Azure#21832) Co-authored-by: Ivaliy Ivanov <[email protected]> * example fix, use correct api preview version - (INVALID_REQUEST_PARAMETER) (Azure#21833) Co-authored-by: Ivaliy Ivanov <[email protected]> * Revert breaking change for MLC swagger 2022-12-01-preview (Azure#21885) Co-authored-by: Bingchen Li <[email protected]> * Revert Connection Category back to enum. (Azure#21939) * revert provisioning state change (Azure#21940) * remove body (Azure#21978) Co-authored-by: Komal Yadav <[email protected]> * Addressed comments, added x-ms-long-running-operation to a patch call (Azure#22005) * Addressed comments, added x-ms-long-running-operation to a patch call * fix examples for patch - remove body * fixed formatting * Ivalbert fix patch2 (Azure#22006) * Addressed comments, added x-ms-long-running-operation to a patch call * fix examples for patch - remove body * fixed formatting * fixed formatting * Updated custom words (Azure#22262) * Fixed prettier errors (Azure#22237) * fixed examples for LRO_RESPONSE_HEADER check (Azure#22293) * fixed examples for LRO_RESPONSE_HEADER check (Azure#22294) * Example fix - OBJECT_MISSING_REQUIRED_PROPERTY - Missing required property: triggerType (Azure#22317) --------- Co-authored-by: Komal Yadav <[email protected]> Co-authored-by: Komal Yadav <[email protected]> Co-authored-by: Naman Agarwal <[email protected]> Co-authored-by: Naman Agarwal <[email protected]> Co-authored-by: ZhidaLiu <[email protected]> Co-authored-by: libc16 <[email protected]> Co-authored-by: Bingchen Li <[email protected]> Co-authored-by: Ivaliy Ivanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draft
mode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csproj
andAssemblyInfo.cs
files have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]
orAzure.ResourceManager.[RP]
Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new service
label and/or contact assigned reviewer.If the check fails at the
Verify Code Generation
step, please ensure:generate.ps1/cmd
to generate this PR instead of callingautorest
directly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1
. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1
to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.