Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MetricsAdvisor] Address archboard review feedback #15973

Closed
kinelski opened this issue Oct 14, 2020 · 1 comment
Closed

[MetricsAdvisor] Address archboard review feedback #15973

kinelski opened this issue Oct 14, 2020 · 1 comment
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor

Comments

@kinelski
Copy link
Member

kinelski commented Oct 14, 2020

Split into:
(#16170) Update CreateDataFeed method to take a whole DataFeed
(#16314) Flatten DataFeedOptions
(#16317) Renames to do
(#16319) Consider creating overloads for similar service methods
(#16320) Make sure all possible DataFeedSource concrete implementations are listed in docs
(#16321) Consider making constructor of complex types parameterless
(#16325) Consider not returning strings or primitive types from service methods
(#16326) Return only the ID of the created models in Create methods
(#16331) DimensionKey is too complex
(#16333) Adding new data source types could break older SDK versions

@kinelski kinelski added Client This issue points to a problem in the data-plane of the library. blocking-release Blocks release Cognitive - Metrics Advisor labels Oct 14, 2020
@kinelski kinelski added this to the [2020] November milestone Oct 14, 2020
@kinelski kinelski removed this from the [2020] November milestone Oct 27, 2020
@kinelski
Copy link
Member Author

This issue will be split into multiple work items, so closing this one.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Development

No branches or pull requests

1 participant