Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetricsAdvisor] Make sure all possible DataFeedSource concrete implementations are listed in docs #16320

Closed
kinelski opened this issue Oct 27, 2020 · 1 comment · Fixed by #22516
Closed

[MetricsAdvisor] Make sure all possible DataFeedSource concrete implementations are listed in docs #16320

kinelski opened this issue Oct 27, 2020 · 1 comment · Fixed by #22516
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Milestone
[2021] July

Comments

@kinelski
Copy link
Member

DataFeedSource is abstract, so discoverability of derived classes is compromised. Make sure these are listed in docs.
@kinelski kinelski added Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor labels Oct 27, 2020
@kinelski kinelski added this to the [2020] November milestone Oct 27, 2020
@kinelski kinelski mentioned this issue Oct 27, 2020
Closed
@kinelski kinelski modified the milestones: [2020] November, Backlog Oct 29, 2020
@kinelski kinelski modified the milestones: Backlog, [2021] July Jul 8, 2021
@kinelski kinelski mentioned this issue Jul 8, 2021
Merged
@kinelski kinelski linked a pull request Jul 8, 2021 that will close this issue
[MetricsAdvisor] Improve docstrings for whole client #22516
Merged
@kinelski
Copy link
Member Author

kinelski commented Jul 9, 2021

Fixed by #22516.

@kinelski kinelski closed this as completed Jul 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Milestone
[2021] July
Development

Successfully merging a pull request may close this issue.

[MetricsAdvisor] Improve docstrings for whole client kinelski/azure-sdk-for-net
1 participant
@kinelski