Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetricsAdvisor] Renames to do #16317

Closed
5 tasks done
kinelski opened this issue Oct 27, 2020 · 0 comments · Fixed by #16466
Closed
5 tasks done

[MetricsAdvisor] Renames to do #16317

kinelski opened this issue Oct 27, 2020 · 0 comments · Fixed by #16466
Assignees
@kinelski
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Milestone
[2020] November

Comments

@kinelski
Copy link
Member

kinelski commented Oct 27, 2020 •
edited
Loading

  • CreateFeedback => AddFeedback. Create suggests that it will fail if already created.
  • GetMetricFeedbacks is ungrammatical ("feedback" is uncountable). Consider renaming GET methods to GetMetricFeedback and GetAllMetricFeedback.
  • CRUD Anomaly Alert Configuration methods' names can be shortened (e.g., CreateAnomalyAlertConfiguration => CreateAlertConfiguration).
  • CRUD Anomaly Detection Configuration methods' names can be shortened (e.g., CreateMetricAnomalyDetectionConfiguration => CreateDetectionConfiguration).
  • GetMetricDimensionValues => GetDimensionValues.
@kinelski kinelski added Client This issue points to a problem in the data-plane of the library. blocking-release Blocks release Cognitive - Metrics Advisor labels Oct 27, 2020
@kinelski kinelski added this to the [2020] November milestone Oct 27, 2020
@kinelski kinelski mentioned this issue Oct 27, 2020
Closed
@kinelski kinelski self-assigned this Oct 28, 2020
@kinelski kinelski mentioned this issue Oct 30, 2020
Merged
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this issue Jan 5, 2022
CodeGen from PR 16317 in Azure/azure-rest-api-specs
55b2504 
Modify module-name released (Azure#16317)

* add resourcemanager and add repo for go track2

* add resourcemanager

* fix other
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kinelski kinelski

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Milestone
[2020] November
Development

Successfully merging a pull request may close this issue.

[MetricsAdvisor] Post-Arch Board review renames kinelski/azure-sdk-for-net
1 participant
@kinelski