Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MetricsAdvisor] Return only the ID of the created models in Create methods #16326

Closed
kinelski opened this issue Oct 27, 2020 · 0 comments · Fixed by #16451
Closed

[MetricsAdvisor] Return only the ID of the created models in Create methods #16326

kinelski opened this issue Oct 27, 2020 · 0 comments · Fixed by #16451
Assignees
@kinelski
Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Milestone
[2020] November

Comments

@kinelski
Copy link
Member

Let's use CreateDataFeed as an example.

Current behavior:

var dataFeed = new DataFeed(...);
dataFeed = adminClient.CreateDataFeed(dataFeed); // outputs the reference passed as input, with dataFeed.Id set.

If users want to get more information about the created data feed (e.g., metric IDs), they need to make a Get operation, since the only thing returned by the service during Create is the ID of the new data feed.

Returning a whole DataFeed object may give users the wrong impression that all of its fields are populated. We should return only the ID. Be aware of #16325.
@kinelski kinelski added Client This issue points to a problem in the data-plane of the library. blocking-release Blocks release Cognitive - Metrics Advisor labels Oct 27, 2020
@kinelski kinelski added this to the [2020] November milestone Oct 27, 2020
@kinelski kinelski mentioned this issue Oct 27, 2020
Closed
@kinelski kinelski self-assigned this Oct 29, 2020
@kinelski kinelski mentioned this issue Oct 29, 2020
Merged
@kinelski kinelski mentioned this issue Nov 4, 2020
Closed
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this issue Oct 28, 2021
CodeGen from PR 16326 in Azure/azure-rest-api-specs
5b7a2c0 
marketplacenotifications: fixing an invalid operation id (Azure#16326)

Since both of these share the same operation id - neither is currently valid / can work
as such this fixes these to use the canonical name (List and Get) based on the convention
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-net that referenced this issue Jan 5, 2022
CodeGen from PR 16326 in Azure/azure-rest-api-specs
1f69403 
marketplacenotifications: fixing an invalid operation id (Azure#16326)

Since both of these share the same operation id - neither is currently valid / can work
as such this fixes these to use the canonical name (List and Get) based on the convention
@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kinelski kinelski

Labels
blocking-release Blocks release Client This issue points to a problem in the data-plane of the library. Cognitive - Metrics Advisor
Projects
None yet
Milestone
[2020] November
Development

Successfully merging a pull request may close this issue.

[MetricsAdvisor] Update return type of Create methods to Response<string> kinelski/azure-sdk-for-net
1 participant
@kinelski