Use inlineSources to bundle source file contents inside map files

[xirzec]

Today when TSC generates sourcemaps, it doesn't include the source file contents, which means we have to include the src directory (which we didn't always do correctly.)

To sidestep this problem, we can tell the compiler to always include the source file contents, which should make it easier for consumers of the esm sources to manage using the map files.

Fixes #7544

[richardpark-msft]

@xirzec - any obvious negatives to this approach?

[xirzec]

@xirzec - any obvious negatives to this approach?

The map files are bigger, but considering they are useless without the TS files, it's not like there is a way we could avoid shipping the TS file contents in some form or another anyway.

[chradek]

Would it be possible to update our SDK guidelines to also recommend this approach, vs the current approach of shipping all the TS files?

[xirzec]

Would it be possible to update our SDK guidelines to also recommend this approach, vs the current approach of shipping all the TS files?

Yep, good idea

[sadasant]

This is awesome! If CI is working fine, we should get this in this week. Probably after the preview release?

[xirzec]

screenshot showing the dev experience - VS Code shows a source TS file from the package, even though you can see it's not part of the package on disk

[willmtemple]

@xirzec with this change, if I use go-to-definition will we still be taken to the actual source file on disk if it is available? I.e. if I observe an issue in a test or something that is resolving to another package, and I go to its definition, will I end up on the actual source file or on a reconstructed buffer that contains the sources from the map files?

[xirzec]

@xirzec with this change, if I use go-to-definition will we still be taken to the actual source file on disk if it is available? I.e. if I observe an issue in a test or something that is resolving to another package, and I go to its definition, will I end up on the actual source file or on a reconstructed buffer that contains the sources from the map files?

It seems to honor going to the real source files. I tested it with going to definition on a function from core-http from inside search after rebuilding with the flag.

[jeremymeng]

😢 go-to-def doesn't seem to work with my Emacs configuration. When I test with abort-controller package it went to the d.ts file. Maybe I will wait for @daviwil Emacs tricks to get it working

[xirzec]

😢 go-to-def doesn't seem to work with my Emacs configuration. When I test with abort-controller package it went to the d.ts file. Maybe I will wait for @daviwil Emacs tricks to get it working

I noticed even in the old world (pre-inline sources) sometimes go to def would hit the definitions instead for certain packages/types.