Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of compiler options instead of reshipping source files #7544

Closed
KarishmaGhiya opened this issue Feb 26, 2020 · 0 comments · Fixed by #7615
Closed

Use of compiler options instead of reshipping source files #7544

KarishmaGhiya opened this issue Feb 26, 2020 · 0 comments · Fixed by #7615
Assignees
@xirzec
Labels
Client This issue points to a problem in the data-plane of the library.

Comments

@KarishmaGhiya
Copy link
Member

Summary from the discussion on #7507 -

The rollup version of the source map includes a sourcesContent member, whereas the source maps for the ES (module) output does not. So the TS files are needed for the modularized output. We probably can fix this with the compiler option inlineSources instead of reshipping source files
cc: @xirzec @chradek
@KarishmaGhiya KarishmaGhiya added the Client This issue points to a problem in the data-plane of the library. label Feb 26, 2020
@KarishmaGhiya KarishmaGhiya mentioned this issue Feb 26, 2020
Merged
@xirzec xirzec self-assigned this Mar 3, 2020
@xirzec xirzec mentioned this issue Mar 3, 2020
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@xirzec xirzec

Labels
Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use inlineSources to bundle source file contents inside map files xirzec/azure-sdk-for-js
2 participants
@xirzec @KarishmaGhiya