renamed lib to src for core-http

[KarishmaGhiya]

No description provided.

[xirzec]

Looks like you missed a rename:

samples/node-sample.ts(6,27): error TS2307: Cannot find module '../lib/coreHttp'.

[xirzec]

There looks to be another tsconfig file it uses: tsconfig.es.json

[xirzec]

Approved with one small change request

[xirzec]

let's drop this line

[KarishmaGhiya]

I removed this line "src/**/*.ts", Is that all?

[chradek]

I think we're actually supposed to include the TS files in the package:
https://azure.github.io/azure-sdk/typescript_design.html#ts-config-sourceMap

Be sure to include your original TypeScript sources in the package.

[chradek]

Overall looks good, I think the src TS files just need to be added back as per the guidelines (for sourcemap support).

[xirzec]

Hmm this is interesting since I know we don't do this consistently. I thought the generated maps contained the file contents?

@bterlson

[chradek]

I don't know more than a high-level of how source maps work, but I do notice that the rollup version of the source map includes a sourcesContent member, whereas the source maps for the ES (module) output does not. So I imagine the TS files are at least needed for the modularized output. I don't know how hard it would be to change that.

[xirzec]

Looks like we can fix this with the compiler option inlineSources - can we open an issue to track moving to this instead of reshipping all source files?

[KarishmaGhiya]

Opened the issue - #7544

[xirzec]

Awesome, I think we're good to go on this one then.