[Core lro] Update linting scripts and auto linting #11273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
requested review from
bterlson,
sadasant and
xirzec
as code owners
ghost
added
the
willmtemple
reviewed
Sep 16, 2020
There was a problem hiding this comment.
Some comments below. Note for the comment about the this concerns, I'm not necessarily saying that we should block this PR for that, just to figure out if we're going to leave it as is or make a change and then we could take an issue on that change if we do decide that.
sadasant
suggested changes
Sep 22, 2020
deyaaeldeen
commented
Sep 22, 2020
xirzec
approved these changes
Sep 22, 2020
|
@deyaaeldeen PR description please 🙏✨ I know we miss it in many places, but we can work together on improving 💪 |
sadasant
approved these changes
Sep 23, 2020
deyaaeldeen
added a commit
to deyaaeldeen/azure-sdk-for-js
that referenced
this pull request
Sep 25, 2020
* [Core lro] Update linting scripts and auto linting * applying formatting changes * address Jeff's feedback * remove dist-esm/** * adding dist-esm/src back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching the
eslintconfiguration file used forcore-lroto use the newer one in the root of the repository and fixing all the linting problems. Furthermore, enforce the absence of linting errors in CI.