[Eslint Plugin] Update ts-naming-options rule to expect a more reasonable name for constructor options #11403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
requested review from
bterlson,
daviwil,
sadasant,
sophiajt,
xirzec,
willmtemple,
jeremymeng,
KarishmaGhiya,
HarshaNalluru,
ramya-rao-a,
joheredi and
richardpark-msft
richardpark-msft
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
Seems very sensible to me.
I think @jonathandturner brought this up in one of our team meetings so you've got at least two votes (probably). :)
xirzec
approved these changes
Sep 24, 2020
common/tools/eslint-plugin-azure-sdk/docs/rules/ts-naming-options.md
Outdated
Show resolved
Hide resolved
This was referenced Sep 25, 2020
deyaaeldeen
added a commit
to deyaaeldeen/azure-sdk-for-js
that referenced
this pull request
Sep 25, 2020
…able name for constructor options (Azure#11403) * better handling of class constructors in ts-naming-options rule * adding tests * adding upsert to my dictionary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
ts-naming-optionsexpects the type of the options parameter to the constructor of a client class to be namedConstructorOptions, but I think a more reasonable behavior would be to expect<class name>Optionsinstead and this PR implements this. Suggestions for alternative behaviors are welcome!