Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] [KeyVault] Copyright headers #3911

Merged
merged 4 commits into from
Jun 20, 2019
Merged

[JS] [KeyVault] Copyright headers #3911

merged 4 commits into from
Jun 20, 2019

Conversation

sadasant
Copy link
Contributor

Fixes #3783

@sadasant sadasant added Client This issue points to a problem in the data-plane of the library. KeyVault labels Jun 18, 2019
@sadasant sadasant requested a review from sophiajt June 18, 2019 20:32
@sadasant sadasant self-assigned this Jun 18, 2019
@sadasant sadasant force-pushed the feature/fix3783 branch 2 times, most recently from 256a891 to aac9c2f Compare June 18, 2019 20:46
@sophiajt
Copy link
Contributor

The header should be:

// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

From: https://docs.opensource.microsoft.com/releasing/copyright-headers.html

sophiajt
sophiajt suggested changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@sophiajt sophiajt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above. There's a standard header we should use (which also removes the mention of the LICENSE file)

@sadasant
Copy link
Contributor Author

This is the latest one:

// Copyright (c) Microsoft Corporation.
// Licensed under the MIT license.

sophiajt
sophiajt reviewed Jun 20, 2019
View reviewed changes
sdk/keyvault/keyvault-secrets/tests/recoverBackupRestore.test.ts
assert.ok(
result.length > 4500,
`Unexpected length (${result.length}) of buffer from backupSecret()`
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's fine, but general note - try to only do what the PR is about. I'm guessing this just slipped in

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh this is probably VSCode auto-formatting stuff

@sadasant sadasant merged commit 6dc526c into master Jun 20, 2019
@sadasant sadasant deleted the feature/fix3783 branch June 20, 2019 23:13
@daviwil daviwil mentioned this pull request Jun 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiajt sophiajt sophiajt approved these changes

Assignees

@sadasant sadasant

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[JS] [KeyVault] Ensure that every file has the respective copyright
2 participants
@sadasant @sophiajt