Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] [KeyVault] Copyright headers #3911

Merged
merged 4 commits into from
Jun 20, 2019
Merged

[JS] [KeyVault] Copyright headers #3911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e29a961
[JS] [KeyVault] Copyright headers
sadasant Jun 18, 2019
4151271
Related to #3837
sadasant Jun 18, 2019
cfa417b
updated copyrights based on feedback
sadasant Jun 20, 2019
e7da79b
latest feedback
sadasant Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sdk/keyvault/keyvault-keys/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

import {
ServiceClientCredentials,
Expand Down
3 changes: 3 additions & 0 deletions sdk/keyvault/keyvault-keys/src/keysModels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

import * as msRest from "@azure/core-http";
import { ParsedKeyVaultEntityIdentifier } from "./core/keyVaultBase";
import { JsonWebKey, JsonWebKeyOperation, JsonWebKeyCurveName } from "./core/models";
Expand Down
3 changes: 3 additions & 0 deletions sdk/keyvault/keyvault-keys/tests/CRUD.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

import * as assert from "assert";
import { getKeyvaultName } from "./utils/utils.common";
import { KeysClient, CreateEcKeyOptions, UpdateKeyOptions, GetKeyOptions } from "../src";
Expand Down
3 changes: 3 additions & 0 deletions sdk/keyvault/keyvault-keys/tests/list.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

import * as assert from "assert";
import { getKeyvaultName } from "./utils/utils.common";
import { KeysClient, CreateEcKeyOptions, UpdateKeyOptions, GetKeyOptions } from "../src";
Expand Down
3 changes: 3 additions & 0 deletions sdk/keyvault/keyvault-keys/tests/recoverBackupRestore.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

import * as assert from "assert";
import { getKeyvaultName } from "./utils/utils.common";
import { KeysClient, CreateEcKeyOptions, UpdateKeyOptions, GetKeyOptions } from "../src";
Expand Down
3 changes: 3 additions & 0 deletions sdk/keyvault/keyvault-keys/tests/utils/index.browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

export async function blobToString(blob: Blob): Promise<string> {
const fileReader = new FileReader();
return new Promise<string>((resolve, reject) => {
Expand Down
3 changes: 3 additions & 0 deletions sdk/keyvault/keyvault-keys/tests/utils/recorder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

import fs from "fs-extra";
import queryString from "query-string";
import { blobToString } from "./index.browser";
Expand Down
3 changes: 3 additions & 0 deletions sdk/keyvault/keyvault-keys/tests/utils/utils.common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

import { env } from "./recorder";

// Async iterator's polyfill for Node 8
Expand Down
4 changes: 2 additions & 2 deletions sdk/keyvault/keyvault-secrets/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

import {
ServiceClientCredentials,
Expand Down
3 changes: 3 additions & 0 deletions sdk/keyvault/keyvault-secrets/src/secretsModels.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

import * as msRest from "@azure/core-http";
import { DeletionRecoveryLevel } from "./core/models";
import { ParsedKeyVaultEntityIdentifier } from "./core/keyVaultBase";
Expand Down
3 changes: 3 additions & 0 deletions sdk/keyvault/keyvault-secrets/tests/CRUD.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

import * as assert from "assert";
import { SecretsClient } from "../src";
import { record, setReplaceableVariables, delay, setReplacements, env } from "./utils/recorder";
Expand Down
3 changes: 3 additions & 0 deletions sdk/keyvault/keyvault-secrets/tests/list.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

import * as assert from "assert";
import { expect } from "chai";
import { SecretsClient } from "../src";
Expand Down
8 changes: 7 additions & 1 deletion sdk/keyvault/keyvault-secrets/tests/recoverBackupRestore.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

import * as assert from "assert";
import { SecretsClient } from "../src";
import { record, setReplaceableVariables, delay, setReplacements, env } from "./utils/recorder";
Expand Down Expand Up @@ -104,7 +107,10 @@ describe("Secret client - restore secrets and recover backups", () => {
await client.setSecret(secretName, "RSA");
const result = await client.backupSecret(secretName);
assert.equal(Buffer.isBuffer(result), true, "Unexpected return value from backupSecret()");
assert.ok(result.length > 4500, `Unexpected length (${result.length}) of buffer from backupSecret()`);
assert.ok(
result.length > 4500,
`Unexpected length (${result.length}) of buffer from backupSecret()`
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's fine, but general note - try to only do what the PR is about. I'm guessing this just slipped in

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh this is probably VSCode auto-formatting stuff

await flushSecret();
});

Expand Down
3 changes: 3 additions & 0 deletions sdk/keyvault/keyvault-secrets/tests/utils/recorder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

import fs from "fs-extra";
import queryString from "query-string";
import { blobToString } from "./index.browser";
Expand Down
3 changes: 3 additions & 0 deletions sdk/keyvault/keyvault-secrets/tests/utils/utils.common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.

import { env } from "./recorder";

// Async iterator's polyfill for Node 8
Expand Down