-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
License headers in source files is wrong #3837
Comments
We have a list of officially blessed copyright headers for various languages here (Microsoft Internal, sorry). Also, the LICENSE.md file must be included in the package. I'll update the guidelines to be more clear about this. |
Reposting here for those who do not have access:
|
I believe with latest efforts on enabling the eslint plugin v3 on all our packages, we have the below copyright in the non auto generated files
@joheredi Does the code generator have a default copyright text to use or relies on the user to provide one? If it has its own, then we should update it to use the above text |
It has a default value if nothing is provided /*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is regenerated.
*/ Autorest also comes with a few canned license headers that users can use by name /*
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for
* license information.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is
* regenerated.
*/ I can modify /*
* Copyright (c) Microsoft Corporation.
* Licensed under the MIT License.
*
* Code generated by Microsoft (R) AutoRest Code Generator.
* Changes may cause incorrect behavior and will be lost if the code is
* regenerated.
*/ |
Thanks @joheredi |
All
Describe the bug
We currently state the phrase in our code, including auto-generated code:
But this is not where the license file is. It's called "LICENSE", and the header comments should be changed to reflect this.
The text was updated successfully, but these errors were encountered: