Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/identity 3.1.2 #24132

Merged
merged 5 commits into from
Dec 7, 2022
Merged

Hotfix/identity 3.1.2 #24132

merged 5 commits into from
Dec 7, 2022

Conversation

KarishmaGhiya
Copy link
Member

@KarishmaGhiya KarishmaGhiya commented Dec 5, 2022 •
edited
Loading

Packages impacted by this PR

@azure/identity

Issues associated with this PR

This PR merges changes from hotfix branch hotfix/identity_3.1.2 to main
Original issue - #24003
Fixed by shipping version https://www.npmjs.com/package/@azure/identity/v/3.1.2 through the hotfix branch

Describe the problem that is addressed by this PR

Merging hotfix branch release commits back into main branch

Checklists

  • Added impacted package name to the issue description
  • Added a changelog (if necessary)

@ghost ghost added the Azure.Identity label Dec 5, 2022
@KarishmaGhiya KarishmaGhiya marked this pull request as ready for review December 6, 2022 03:13
@KarishmaGhiya KarishmaGhiya requested review from xirzec, jeremymeng and mpodwysocki and removed request for schaabs and witemple-msft December 6, 2022 03:13
@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-identity

@KarishmaGhiya
Copy link
Member Author

This PR doesn't cause the API update reported though. The API update happened in a different PR to main branch earlier today - 5706943
I think all subsequent PRs into main will need the API to be approved @xirzec
But how did the CI allow the previous PR to be merged into without the API approval? @ckairen

jeremymeng
jeremymeng reviewed Dec 7, 2022
View reviewed changes
sdk/identity/identity/CHANGELOG.md
### Features Added

### Breaking Changes
## 3.1.2 (2022-12-05)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a section for 3.1.3 now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does CI do that automatically for us when releasing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes there should be a PR out by azure-sdk bot for that. If I don't see one, I can create another PR. But I want to avoid doing in same PR bcz it confuses customers.

@KarishmaGhiya
Copy link
Member Author

KarishmaGhiya commented Dec 7, 2022 •
edited
Loading

\azp run js- identity

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@KarishmaGhiya
Copy link
Member Author

/azp run js - identity

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@KarishmaGhiya KarishmaGhiya merged commit c8923a3 into main Dec 7, 2022
@KarishmaGhiya KarishmaGhiya deleted the hotfix/identity_3.1.2 branch December 7, 2022 20:41
@ckairen
Copy link
Member

ckairen commented Dec 12, 2022

This PR doesn't cause the API update reported though. The API update happened in a different PR to main branch earlier today - 5706943 I think all subsequent PRs into main will need the API to be approved @xirzec But how did the CI allow the previous PR to be merged into without the API approval? @ckairen

We don't block on merges, we only block on releases. As for the API update, there's probably a small window between the pipeline run and the creation of API review ticket where it gets a bit confusing. @praveenkuttappan is looking into the issue

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Aug 23, 2023
@guptanitish-ms @lobashh
@SharanSingh @Aleksand4rZivanovic @a-lazarlazic @mykolian @srnanikolicmdcs @rebeccaxu-ms @LeiWang3 @viparek @nmirkovic-microsoft @pmahanandire @Nidhi-Gupta6198
CodeGen from PR 25293 in Azure/azure-rest-api-specs
33ff899 
Release sql microsoft.sql 2023 02 01 preview (Azure#25293)

* Adds base for updating Microsoft.Sql from version preview/2022-11-01-preview to version 2023-02-01-preview

* Updates readme

* Updates API version in new specs and examples

* add mi refresh API (Azure#24093)

* add mi refresh API

* remove stray character

* add examples

* fix lro error

* fix lro error only in example

* fixing prettier issue

* Test commit - adding error schema

* Test2

* Test - changing error type

* Revert "Test - changing error type"

This reverts commit 84fff94ea9cefca5312d2f5c12e099f315e0c064.

* Reverting 3 test commits

* Test - adding commong error type reference

* fix type format errors

---------

Co-authored-by: Stefan Krivokapic <[email protected]>

* Adding changes from main to release branch. PRs 24175 and 24185 (Azure#24221)

* Enable multiple partner servers and failover of read-only endpoint for SQL DB Failover Group in version 2023-02-01-preview. (Azure#24132)

* Added the swagger spec and example json files for failvoer group API update in V2023-020-1

* Corrected the FailoverGroupGet.json example

* Updated the auto-generated FailoverGroups.json

Fixed FailoverGroups.json swagger arm-id attribute for databases field

* Added the missing headers field manually

* Fix FailoverGroups.json

---------

Co-authored-by: Sharan Singh <[email protected]>

* Changes to Location Capabilities (Azure#24209)

* Loc cap changes

* removing changes not related to my changes in dsmain

* DAG API 2023-02-01 (Azure#24108)

* add new dag api version

* Update swagger

* Update swagger

* patch resource

* make replicationMode writable

* Add FreeLimitExhaustion Capability in 2023-02-01-preview API (Azure#24224)

* Add FreeLimitExhaustion Capability in 2023-02-01-preview API

* Change property from name to exhaustionBehaviorType

* generate swagger for LocationCapabilites (Azure#24290)

* inital commit for LTR Policy Immutability (Azure#24347)

* inital commit for immutable ltr backups (Azure#24349)

* Update Servers swagger files with adding property "IsIPv6Enabled" (Azure#24305)

* Update swagger files for Server API

* Add v5 tag for Servers

* Restore none for minimal TLS version

* Add auto rotation param to databases api (Azure#24339)

* Add auto rotation param to databases api

* add armid

* Adding IsFreemium and CreateTime to Get MI API (Azure#24239)

* Updated the examples for LTR Policies and LTR Backups (Azure#24821)

* Updated the examples for LTR Policies and LTR Backups

* Not sure why makeBackupsImmutable got deleted

* updating swagger files for enum name changes (Azure#24742)

* Carrying over minor changes for the 2023-02-01-preview release (Azure#25177)

* Carrying over minor changes for the 2023-02-01-preview release

* Reverting example files that didn't have DsMainDev side changes, and fixing prettier check

* Fixes for LTR examples with model validation and prettier check for ServerDelete

* Reverting LTR changes

* Adding arm-id to serversjson

* swagger changes for adding new parameter in dc telemetry (Azure#24834)

* testing push

* reverting push

* swagger files for DC add parameter change

* delete added file

* modified swagger files without Venkat's change

* modified swagger files

* changed modelAsString to true

* add example files

* add example files

* fix mismatch

* Removing Pattern from ManagedInstance to avoid incident  (Azure#25295)

* Carrying over minor changes for the 2023-02-01-preview release

* Reverting example files that didn't have DsMainDev side changes, and fixing prettier check

* Fixes for LTR examples with model validation and prettier check for ServerDelete

* Reverting LTR changes

* Adding arm-id to serversjson

* Removing the Pattern property from ManagedInstances.json as it should not be present and will cause issues in downstream client generation

---------

Co-authored-by: guptanitish-ms <[email protected]>
Co-authored-by: Stefan Krivokapic <[email protected]>
Co-authored-by: lobashh <[email protected]>
Co-authored-by: Sharan Singh <[email protected]>
Co-authored-by: Aleksand4rZivanovic <[email protected]>
Co-authored-by: a-lazarlazic <[email protected]>
Co-authored-by: mykolian <[email protected]>
Co-authored-by: Srna Nikolic <[email protected]>
Co-authored-by: rebeccaxu-ms <[email protected]>
Co-authored-by: LeiWang3 <[email protected]>
Co-authored-by: viparek <[email protected]>
Co-authored-by: Nikola Mirkovic <[email protected]>
Co-authored-by: pmahanandire <[email protected]>
Co-authored-by: nidhigupta <[email protected]>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Oct 27, 2023
@jacobopac @guptanitish-ms
@lobashh @SharanSingh @Aleksand4rZivanovic @a-lazarlazic @mykolian @srnanikolicmdcs @rebeccaxu-ms @LeiWang3 @viparek @nmirkovic-microsoft @ms-mjovkovic @rayboyd30 @kosta-bizetic @CelinaJiangJXY @Yashu1818 @sonjaciric @nesavicMSFT @alejandro182 @saljain0101 @mmilovanovic95 @archanasahoo22
CodeGen from PR 26289 in Azure/azure-rest-api-specs
92611c0 
Release sql microsoft.sql 2023 05 01 preview (Azure#26289)

* Adds base for updating Microsoft.Sql from version preview/2023-02-01-preview to version 2023-05-01-preview

* Updates readme

* Updates API version in new specs and examples

* Adding JobPrivateEndpoints API to version 2023-05-01-preview  (Azure#24902)

* Adds base for updating Microsoft.Sql from version preview/2022-11-01-preview to version 2023-02-01-preview

* Updates readme

* Updates API version in new specs and examples

* add mi refresh API (Azure#24093)

* add mi refresh API

* remove stray character

* add examples

* fix lro error

* fix lro error only in example

* fixing prettier issue

* Test commit - adding error schema

* Test2

* Test - changing error type

* Revert "Test - changing error type"

This reverts commit 84fff94ea9cefca5312d2f5c12e099f315e0c064.

* Reverting 3 test commits

* Test - adding commong error type reference

* fix type format errors

---------

Co-authored-by: Stefan Krivokapic <[email protected]>

* Adding changes from main to release branch. PRs 24175 and 24185 (Azure#24221)

* Enable multiple partner servers and failover of read-only endpoint for SQL DB Failover Group in version 2023-02-01-preview. (Azure#24132)

* Added the swagger spec and example json files for failvoer group API update in V2023-020-1

* Corrected the FailoverGroupGet.json example

* Updated the auto-generated FailoverGroups.json

Fixed FailoverGroups.json swagger arm-id attribute for databases field

* Added the missing headers field manually

* Fix FailoverGroups.json

---------

Co-authored-by: Sharan Singh <[email protected]>

* Changes to Location Capabilities (Azure#24209)

* Loc cap changes

* removing changes not related to my changes in dsmain

* DAG API 2023-02-01 (Azure#24108)

* add new dag api version

* Update swagger

* Update swagger

* patch resource

* make replicationMode writable

* Add FreeLimitExhaustion Capability in 2023-02-01-preview API (Azure#24224)

* Add FreeLimitExhaustion Capability in 2023-02-01-preview API

* Change property from name to exhaustionBehaviorType

* generate swagger for LocationCapabilites (Azure#24290)

* inital commit for LTR Policy Immutability (Azure#24347)

* inital commit for immutable ltr backups (Azure#24349)

* Update Servers swagger files with adding property "IsIPv6Enabled" (Azure#24305)

* Update swagger files for Server API

* Add v5 tag for Servers

* Restore none for minimal TLS version

* Add auto rotation param to databases api (Azure#24339)

* Add auto rotation param to databases api

* add armid

* Adding IsFreemium and CreateTime to Get MI API (Azure#24239)

* job private endpoint swagger

* rerun pipelines

* adding job private endpoints to readme

* rerun pipelines

* trying to fix lint errors

* fixing typos - singular resource name and description.

* adding arm-id

* Moving files to the new version; no changes to the files themselves.

* adding job agent private endpoints to readme

---------

Co-authored-by: Jeremy Frosti <[email protected]>
Co-authored-by: guptanitish-ms <[email protected]>
Co-authored-by: Stefan Krivokapic <[email protected]>
Co-authored-by: lobashh <[email protected]>
Co-authored-by: Sharan Singh <[email protected]>
Co-authored-by: Aleksand4rZivanovic <[email protected]>
Co-authored-by: a-lazarlazic <[email protected]>
Co-authored-by: mykolian <[email protected]>
Co-authored-by: Srna Nikolic <[email protected]>
Co-authored-by: rebeccaxu-ms <[email protected]>
Co-authored-by: LeiWang3 <[email protected]>
Co-authored-by: viparek <[email protected]>
Co-authored-by: Nikola Mirkovic <[email protected]>

* DAG API 2023-05-01 for MI First (Azure#25638)

* mi first dag api 2023-05-01

* adding x-ms-identifiers

* adding job step and target group apis to version 2023-05-01-preview (Azure#25689)

* adding job step and target group apis to versoin 2023-05-01-preview

* remove required credential

---------

Co-authored-by: Ray Boyd <[email protected]>

* updating location capabilities for 2023-05-01-preview (Azure#25539)

Co-authored-by: Ray Boyd <[email protected]>

* Updating Instance Pool swagger for 2023-05-01-preview (Azure#25580)

* Updating Instance Pool swagger for 2023-05-01-preview

* Add format specification

* Update examples

---------

Co-authored-by: Kosta Bizetic <[email protected]>
Co-authored-by: Ivan Arandjelovic <[email protected]>

* Add Archive option to LTR Policy and LTR Backup for SQL DB  (Azure#25799)

* added changes

* fix swagger validation failures

* adding fixes

* added more changes

* added fixes

* fixed LintDiff

* added changes

* fix lintDiff

* Swagger validations for serverless parameters added in SQL API (Azure#25852)

* Swagger validations for serverless parameters added in SQL API

* Fixing spellcheck in example file

* Fix LintDiff error

---------

Co-authored-by: Yash Udasi <[email protected]>

* Add AAD support to job agents version 2023-05-01-preview (Azure#25553)

* adding job agent identity support to 2023-05-01-preview

* updated swagger with just aad changes

---------

Co-authored-by: Ray Boyd <[email protected]>

* Dev/sonjac/ltr api update (Azure#25701)

* Adding generated files.

* Fixing swagger errors.

* Managed Instance swagger to support Authentication Metadata (Azure#25795)

* generated swagger

* fixed prettier:

* fixed minor stuff

* swagger fixes

* added missing example file

* removed unused file

* externalgovernance fixes

* minor fixes

* missing character

* Adding JobAgents API with SKU support to version 2023-05-01-preview (Azure#24995)

* Adds base for updating Microsoft.Sql from version preview/2022-11-01-preview to version 2023-02-01-preview

* Updates readme

* Updates API version in new specs and examples

* add mi refresh API (Azure#24093)

* add mi refresh API

* remove stray character

* add examples

* fix lro error

* fix lro error only in example

* fixing prettier issue

* Test commit - adding error schema

* Test2

* Test - changing error type

* Revert "Test - changing error type"

This reverts commit 84fff94ea9cefca5312d2f5c12e099f315e0c064.

* Reverting 3 test commits

* Test - adding commong error type reference

* fix type format errors

---------

Co-authored-by: Stefan Krivokapic <[email protected]>

* Adding changes from main to release branch. PRs 24175 and 24185 (Azure#24221)

* Enable multiple partner servers and failover of read-only endpoint for SQL DB Failover Group in version 2023-02-01-preview. (Azure#24132)

* Added the swagger spec and example json files for failvoer group API update in V2023-020-1

* Corrected the FailoverGroupGet.json example

* Updated the auto-generated FailoverGroups.json

Fixed FailoverGroups.json swagger arm-id attribute for databases field

* Added the missing headers field manually

* Fix FailoverGroups.json

---------

Co-authored-by: Sharan Singh <[email protected]>

* Changes to Location Capabilities (Azure#24209)

* Loc cap changes

* removing changes not related to my changes in dsmain

* DAG API 2023-02-01 (Azure#24108)

* add new dag api version

* Update swagger

* Update swagger

* patch resource

* make replicationMode writable

* Add FreeLimitExhaustion Capability in 2023-02-01-preview API (Azure#24224)

* Add FreeLimitExhaustion Capability in 2023-02-01-preview API

* Change property from name to exhaustionBehaviorType

* generate swagger for LocationCapabilites (Azure#24290)

* inital commit for LTR Policy Immutability (Azure#24347)

* inital commit for immutable ltr backups (Azure#24349)

* Update Servers swagger files with adding property "IsIPv6Enabled" (Azure#24305)

* Update swagger files for Server API

* Add v5 tag for Servers

* Restore none for minimal TLS version

* Add auto rotation param to databases api (Azure#24339)

* Add auto rotation param to databases api

* add armid

* Adding IsFreemium and CreateTime to Get MI API (Azure#24239)

* Updated the examples for LTR Policies and LTR Backups (Azure#24821)

* Updated the examples for LTR Policies and LTR Backups

* Not sure why makeBackupsImmutable got deleted

* swagger changes

* api version changed

* adding identity files to the version on review

* change of getjobagent

* change test

* nit fix

* Changes to use SKU name to specify SLO

* Changes for job agent update SLO with 2023-05-01 version

* removing files of 2023-02-01

* fix

* removing changes on JobAgents 2023-02-01

---------

Co-authored-by: Jeremy Frosti <[email protected]>
Co-authored-by: guptanitish-ms <[email protected]>
Co-authored-by: Stefan Krivokapic <[email protected]>
Co-authored-by: lobashh <[email protected]>
Co-authored-by: Sharan Singh <[email protected]>
Co-authored-by: Aleksand4rZivanovic <[email protected]>
Co-authored-by: a-lazarlazic <[email protected]>
Co-authored-by: mykolian <[email protected]>
Co-authored-by: Srna Nikolic <[email protected]>
Co-authored-by: rebeccaxu-ms <[email protected]>
Co-authored-by: LeiWang3 <[email protected]>
Co-authored-by: viparek <[email protected]>
Co-authored-by: Nikola Mirkovic <[email protected]>

* added swagger spec and example json files for failovergroup api (Azure#25837)

* Updating Managed Instance swagger for 2023-05-01-preview (Azure#26098)

* Modifying ManagedInstances.json and corresponding examples

* Remove example

* Fix syntax errors

* Swagger API changes to support PUT and PATCH to update replication link type (Azure#25690)

* Add Swagger files for Replication Link Update Link Type

* resolve validation error

* Modify property description

* resolve lint errors

* Reverting MI change for readme to fix merge conflict with main (Azure#26296)

---------

Co-authored-by: jacobopac <[email protected]>
Co-authored-by: guptanitish-ms <[email protected]>
Co-authored-by: Stefan Krivokapic <[email protected]>
Co-authored-by: lobashh <[email protected]>
Co-authored-by: Sharan Singh <[email protected]>
Co-authored-by: Aleksand4rZivanovic <[email protected]>
Co-authored-by: a-lazarlazic <[email protected]>
Co-authored-by: mykolian <[email protected]>
Co-authored-by: Srna Nikolic <[email protected]>
Co-authored-by: rebeccaxu-ms <[email protected]>
Co-authored-by: LeiWang3 <[email protected]>
Co-authored-by: viparek <[email protected]>
Co-authored-by: Nikola Mirkovic <[email protected]>
Co-authored-by: ms-mjovkovic <[email protected]>
Co-authored-by: Ray Boyd <[email protected]>
Co-authored-by: Ray Boyd <[email protected]>
Co-authored-by: Kosta Bizetić <[email protected]>
Co-authored-by: Kosta Bizetic <[email protected]>
Co-authored-by: Ivan Arandjelovic <[email protected]>
Co-authored-by: CelinaJiangJXY <[email protected]>
Co-authored-by: Yash Udasi <[email protected]>
Co-authored-by: Yash Udasi <[email protected]>
Co-authored-by: Sonja Ciric <[email protected]>
Co-authored-by: Nebojsa Savic <[email protected]>
Co-authored-by: alejandro182 <[email protected]>
Co-authored-by: saljain0101 <[email protected]>
Co-authored-by: Marko Milovanovic <[email protected]>
Co-authored-by: Archana Sahoo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremymeng jeremymeng jeremymeng approved these changes

@mpodwysocki mpodwysocki mpodwysocki approved these changes

@xirzec xirzec Awaiting requested review from xirzec

Assignees
No one assigned
Labels
Azure.Identity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KarishmaGhiya @azure-sdk @ckairen @jeremymeng @mpodwysocki