[identity] Expires on timestamp should be in seconds not ms #23920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarishmaGhiya
requested review from
witemple-msft and
schaabs
as code owners
ghost
added
the
KarishmaGhiya
changed the title
|
API change check API changes are not detected in this pull request. |
mpodwysocki
approved these changes
Nov 18, 2022
jeremymeng
approved these changes
Nov 18, 2022
Post release automated changes for azure-identity
xirzec
reviewed
Nov 18, 2022
| @@ -255,7 +255,7 @@ export class ManagedIdentityCredential implements TokenCredential { | |||
| logger.info(`token = ${resultToken.token}`); | |||
| return { | |||
| accessToken: resultToken?.token, | |||
| expiresInSeconds: resultToken?.expiresOnTimestamp, | |||
| expiresInSeconds: resultToken?.expiresOnTimestamp / 1000, | |||
There was a problem hiding this comment.
if this is undefined won't this return NaN? Also what if it's not divisible by 1000?
Perhaps something more robust like
expiresInSeconds: resultToken?.expiresOnTimestamp ? Math.ceil(resultToken?.expiresOnTimestamp / 1000) : undefined
KarishmaGhiya
added a commit
that referenced
this pull request
Dec 6, 2022
KarishmaGhiya
added a commit
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/identity
Issues associated with this PR
Fixes #23903
Describe the problem that is addressed by this PR
The "expiresOnTimestamp" field in Managed Identity should be in seconds and was assigned milliseconds. The PR fixes the bug
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
Are there test cases added in this PR? (If not, why?)
Provide a list of related PRs (if any)
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists