Consume start and end partition and row keys #25293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
API change check API changes are not detected in this pull request. |
craxal
reviewed
Mar 20, 2023
| @@ -37,6 +39,28 @@ describe("SAS generation", function () { | |||
| assert.equal(tableSas, expectedSas1); | |||
| }); | |||
|
|
|||
| it("should generate a SAS token with start partition and row keys", async () => { | |||
There was a problem hiding this comment.
Mocha explicitly states that arrow functions are discouraged, because they cannot access the Mocha context available in this:
There was a problem hiding this comment.
yes, we even have a work item tracking changing arrow functions to regular functions #13005.
There was a problem hiding this comment.
Well, I guess today is the day for Tables. I have migrated all the tests from arrow functions to anonymous functions.
jeremymeng
approved these changes
Mar 22, 2023
|
Hello @joheredi! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
6 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/data-tables
Issues associated with this PR
#25252
Describe the problem that is addressed by this PR
We accept startPartitionKey, startRowKey, endPartitionKey and endRowKey parameters when generating table sas token. However internally we are ignoring those provided values.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
To fix this problem we simply need to plumb the values through
Are there test cases added in this PR? (If not, why?)
YES
Provide a list of related PRs (if any)
N/A