[core-amqp] move to shared rollup config #19588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the shared rollup config from dev-tool for product. while working on this, move `StandardAbortMessage` from error.ts to util/constants.ts to break the circular dependency of errors -> utils -> errors.
while keeping rollup.test.config.js. Core-amqp has some dependencies that we don't want to add into the shared rollup config so we take an approach similar to what has been done to Event Hubs and Service Bus tests.
jeremymeng
requested review from
deyaaeldeen,
HarshaNalluru and
ramya-rao-a
as code owners
ghost
added
the
deyaaeldeen
reviewed
Jan 3, 2022
| // fs, net, and tls are used by rhea and need to be shimmed | ||
| // dotenv doesn't work in the browser, so replace it with a no-op function | ||
| shim({ | ||
| dotenv: `export function config() { }`, |
There was a problem hiding this comment.
I think browser tests should not have dotenv uses that need to be shimmed
There was a problem hiding this comment.
You are right. We actually don't use env vars at all in any of the tests. Removing.
deyaaeldeen
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the shared rollup config from dev-tool for product.
while working on this, move
StandardAbortMessagefrom error.ts toutil/constants.ts to break the circular dependency of errors -> utils
-> errors.
Remove rollup.base.config.js while keeping rollup.test.config.js. Core-amqp has some dependencies that we don't want to add into the shared rollup config so we take an approach similar to what has been done to Event Hubs and Service Bus tests.
Resolves #17808