Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core-amqp - use shared roll up config from dev-tool #17808

Closed
1 task
jeremymeng opened this issue Sep 23, 2021 · 0 comments · Fixed by #19588
Closed
1 task

core-amqp - use shared roll up config from dev-tool #17808

jeremymeng opened this issue Sep 23, 2021 · 0 comments · Fixed by #19588
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.

Comments

@jeremymeng
Copy link
Member

jeremymeng commented Sep 23, 2021

For the following libraries

  • core/core-amqp

The Azure SDK for JS repository uses rollup in order to produce browser bundles.
Historically, every package contained its own rollup configuration files when building a browser bundle for testing.

We have an effort in place to share rollup configuration across packages from a common source.

What to do:

  1. Delete rollup.base.config.js and rollup.test.config.js
  2. Update rollup.config.js to the following:
  
import { makeConfig } from "@azure/dev-tool/shared-config/rollup";

export default makeConfig(require("./package.json"));

See the original PR for the shared configuration for an example of how this was done for another package.

  1. Run rushx test from the package folder after setting up your environment

Acceptance criteria:

  • rushx test succeeds
  • rollup.base.config.js and rollup.test.config.js are removed from the relevant directories
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 23, 2021
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system. labels Sep 23, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Sep 23, 2021
@jeremymeng jeremymeng added this to the [2021] November milestone Sep 23, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 11, 2022
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 11, 2022
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 11, 2022
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 11, 2022
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 11, 2022
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 11, 2022
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 11, 2022
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 11, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. EngSys This issue is impacting the engineering system.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants