[core-amqp] move to shared rollup config (#19588)

* [core-amqp] Move to shared rollup config

- Use the shared rollup config from dev-tool for product.

  while working on this, move `StandardAbortMessage` from error.ts to
  util/constants.ts to break the circular dependency of errors -> utils
  -> errors.

* Remove rollup.base.config.js

while keeping rollup.test.config.js. Core-amqp has some dependencies that we
don't want to add into the shared rollup config so we take an approach similar
to what has been done to Event Hubs and Service Bus tests.

* Remove unused `dotenv` code

sdk/core/core-amqp/package.json

@@ -81,6 +81,7 @@
     "util": "^0.12.1"
   },
   "devDependencies": {
+    "@azure/dev-tool": "^1.0.0",
     "@azure/eslint-plugin-azure-sdk": "^3.0.0",
     "@microsoft/api-extractor": "^7.18.11",
     "@rollup/plugin-commonjs": "11.0.2",
@@ -98,7 +99,6 @@
     "chai": "^4.2.0",
     "cross-env": "^7.0.2",
     "debug": "^4.1.1",
-    "dotenv": "^8.2.0",
     "downlevel-dts": "~0.4.0",
     "eslint": "^7.15.0",
     "karma": "^6.2.0",

sdk/core/core-amqp/rollup.config.js

@@ -1,16 +1,5 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
+import { makeConfig } from "@azure/dev-tool/shared-config/rollup";
 
-import * as base from "./rollup.base.config";
-
-const inputs = [];
-
-if (!process.env.ONLY_BROWSER) {
-  inputs.push(base.nodeConfig());
-}
-
-if (!process.env.ONLY_NODE) {
-  inputs.push(base.browserConfig());
-}
-
-export default inputs;
+export default makeConfig(require("./package.json"));

sdk/core/core-amqp/rollup.test.config.js

@@ -1,7 +1,58 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.
-// Licensed under the MIT License.
+import cjs from "@rollup/plugin-commonjs";
+import inject from "@rollup/plugin-inject";
+import json from "@rollup/plugin-json";
+import multiEntry from "@rollup/plugin-multi-entry";
+import nodeResolve from "@rollup/plugin-node-resolve";
+import replace from "@rollup/plugin-replace";
+import shim from "rollup-plugin-shim";
+import sourcemaps from "rollup-plugin-sourcemaps";
+import { makeConfig, makeBrowserTestConfig } from "@azure/dev-tool/shared-config/rollup";
 
-import * as base from "./rollup.base.config";
+const inputs = makeConfig(require("./package.json"));
 
-// Node tests are run via ts-node
-export default [base.browserConfig(true)];
+if (!process.env.ONLY_NODE) {
+  // service-bus has many dependencies that we do not
+  // want to bring into the shared rollup config, so
+  // replace the original test config with a patched one
+  inputs[1] = makeBrowserTestConfigPatch();
+}
+
+function makeBrowserTestConfigPatch() {
+  const config = { ...makeBrowserTestConfig(require("./package.json")) };
+  config.plugins = [
+    multiEntry({ exports: false }),
+    sourcemaps(),
+    replace({
+      delimiters: ["", ""],
+    }),
+    // fs, net, and tls are used by rhea and need to be shimmed
+    shim({
+      os: `export default { }`,
+      path: `export default { }`,
+    }),
+    nodeResolve({
+      mainFields: ["module", "browser"],
+      preferBuiltins: false,
+    }),
+    cjs({
+      namedExports: {
+        chai: ["should", "assert"],
+        assert: ["equal", "deepEqual", "notEqual"],
+      },
+    }),
+    // rhea and rhea-promise use the Buffer global which requires
+    // injection to shim properly
+    inject({
+      modules: {
+        Buffer: ["buffer", "Buffer"],
+        process: "process",
+      },
+      exclude: ["./**/package.json"],
+    }),
+    json(),
+  ];
+
+  return config;
+}
+
+export default inputs;

sdk/core/core-amqp/src/cbs.ts

@@ -12,7 +12,8 @@ import {
   SenderOptions,
   generate_uuid,
 } from "rhea-promise";
-import { StandardAbortMessage, translate } from "./errors";
+import { translate } from "./errors";
+import { StandardAbortMessage } from "./util/constants";
 import { logErrorStackTrace, logger } from "./log";
 import { Constants } from "./util/constants";
 import { RequestResponseLink } from "./requestResponseLink";

sdk/core/core-amqp/src/errors.ts

@@ -6,12 +6,6 @@ import { AmqpError, AmqpResponseStatusCode, isAmqpError as rheaIsAmqpError } fro
 import { isDefined, isObjectWithProperties } from "./util/typeGuards";
 import { isNode, isNumber, isString } from "../src/util/utils";
 
-/**
- * The standard error message accompanying an AbortError.
- * @hidden
- */
-export const StandardAbortMessage = "The operation was aborted.";
-
 /**
  * Maps the conditions to the numeric AMQP Response status codes.
  * @internal

sdk/core/core-amqp/src/index.ts

@@ -10,7 +10,7 @@ export { TokenType } from "./auth/token";
 export { ConnectionConfig, ConnectionConfigOptions } from "./connectionConfig/connectionConfig";
 
 export { CbsClient, CbsResponse } from "./cbs";
-export { Constants } from "./util/constants";
+export { Constants, StandardAbortMessage } from "./util/constants";
 export { AmqpMessageHeader } from "./messageHeader";
 export { AmqpMessageProperties } from "./messageProperties";
 export {
@@ -28,7 +28,6 @@ export {
   isSystemError,
   SystemErrorConditionMapper,
   NetworkSystemError,
-  StandardAbortMessage,
 } from "./errors";
 export {
   delay,

sdk/core/core-amqp/src/requestResponseLink.ts

@@ -2,7 +2,7 @@
 // Licensed under the MIT license.
 
 import { AbortError, AbortSignalLike } from "@azure/abort-controller";
-import { ConditionStatusMapper, StandardAbortMessage, translate } from "./errors";
+import { ConditionStatusMapper, translate } from "./errors";
 import {
   Connection,
   EventContext,
@@ -17,7 +17,7 @@ import {
   generate_uuid,
 } from "rhea-promise";
 import { logErrorStackTrace, logger } from "./log";
-import { Constants } from "./util/constants";
+import { Constants, StandardAbortMessage } from "./util/constants";
 import { isDefined } from "./util/typeGuards";
 
 /**

sdk/core/core-amqp/src/util/constants.ts

@@ -122,3 +122,9 @@ export const Constants = {
     falseFilterList: 83483426824,
   },
 } as const;
+
+/**
+ * The standard error message accompanying an AbortError.
+ * @hidden
+ */
+export const StandardAbortMessage = "The operation was aborted.";

sdk/core/core-amqp/src/util/lock.ts

@@ -3,7 +3,7 @@
 
 import { AbortError, AbortSignalLike } from "@azure/abort-controller";
 import { OperationTimeoutError } from "rhea-promise";
-import { StandardAbortMessage } from "../errors";
+import { StandardAbortMessage } from "./constants";
 import { logger } from "../log";
 
 /**

sdk/core/core-amqp/src/util/utils.ts

@@ -3,7 +3,7 @@
 
 import { AbortError, AbortSignalLike } from "@azure/abort-controller";
 import { CancellableAsyncLock, CancellableAsyncLockImpl } from "./lock";
-import { StandardAbortMessage } from "../errors";
+import { StandardAbortMessage } from "./constants";
 import { WebSocketImpl } from "rhea-promise";
 import { isDefined } from "./typeGuards";
 

sdk/core/core-amqp/test/retry.spec.ts

@@ -2,7 +2,6 @@
 // Licensed under the MIT license.
 
 import * as chai from "chai";
-import * as dotenv from "dotenv";
 import {
   Constants,
   MessagingError,
@@ -18,7 +17,6 @@ import debugModule from "debug";
 
 const debug = debugModule("azure:core-amqp:retry-spec");
 const should = chai.should();
-dotenv.config();
 
 [RetryMode.Exponential, RetryMode.Fixed].forEach((mode) => {
   describe(`retry function for "${