Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KeyVault] - Delete methods should ignore 404 #15586

Merged
merged 5 commits into from
Jun 8, 2021
Merged

[KeyVault] - Delete methods should ignore 404 #15586

merged 5 commits into from
Jun 8, 2021

Conversation

maorleger
Copy link
Member

@maorleger maorleger commented Jun 7, 2021 •
edited
Loading

What

  • Ensure KeyVaultAccessControlClient delete* methods ignore 404s and return void
  • Update tests to use supportsTracing helper

Why

  • This came up in a recent architecture discussion. By succeeding when trying to delete a role definition that was already deleted we make retries much easier for the consumer.
  • The supportsTracing helper was added after these tests were written and is much more comprehensive.

Resolves #15580

@ghost ghost added the KeyVault label Jun 7, 2021
@maorleger maorleger force-pushed the 15580-delete-role-feedback branch from d7fd344 to 9a2bd91 Compare June 7, 2021 17:17
@maorleger maorleger requested a review from heaths June 7, 2021 18:03
sadasant
sadasant approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@sadasant sadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

sadasant
sadasant approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@sadasant sadasant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

maorleger
maorleger commented Jun 7, 2021
View reviewed changes
sdk/keyvault/keyvault-admin/src/generated/models/index.ts
@@ -8,33 +8,38 @@

import * as coreHttp from "@azure/core-http";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regenerating unfortunately added extra noise here in the generated folder due to shifting things around. The meaningful changes are captured in the swagger transforms

@maorleger
Copy link
Member Author

@chradek / @xirzec how does this API look to you?

@check-enforcer
Copy link

check-enforcer bot commented Jun 7, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

chradek
chradek approved these changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@chradek chradek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API looks good to me.

@maorleger maorleger force-pushed the 15580-delete-role-feedback branch from a0f0324 to 3588e23 Compare June 8, 2021 15:02
@maorleger maorleger merged commit 2089881 into Azure:master Jun 8, 2021
@maorleger maorleger deleted the 15580-delete-role-feedback branch June 8, 2021 15:23
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Sep 9, 2021
@levimm @charlili1234
@haitch @nilo19 @asilverman @alexeldeib @matthchr
CodeGen from PR 15954 in Azure/azure-rest-api-specs
520ab8f 
Merge Dev-containerservice-microsoft.containerservice-2021-08-01 branch to main (Azure#15954)

* Adds base for updating Microsoft.ContainerService from version stable/2021-07-01 to version 2021-08-01

* Updates readme

* Updates API version in new specs and examples

* add publicNetworkAccess property per network platform's request (Azure#15489)

* add publicNetworkAccess per network platform's request

* fix quota

Co-authored-by: Li Ma <[email protected]>

* update readme for 2021-08-01 sdk generation (Azure#15476)

* update readme for sdk generation

* update readme for sdk generation

Co-authored-by: Charlie Li <[email protected]>

* allow disabling of runcommand (Azure#15481)

* allow disabling of runcommand

* rename file

* another rename

* fix prittier check

* fix stupid prettier check

* change publicNetworkAccess to enum (Azure#15564)

Co-authored-by: Li Ma <[email protected]>

* Add CreationData property to Agentpool level in 2021-08-01 API (Azure#15563)

* Add CreationData property to Agentpool level in 2021-08-01 API

* fix json format

* fix swagger spell check

Co-authored-by: Charlie Li <[email protected]>

* chore: add enableMultipleStandardLoadBalancers to loadBalancerProfile (Azure#15579)

* Add snapshot related new APIs and properties to AKS 2021-08-01 swagger (Azure#15586)

* Add CreationData property to Agentpool level in 2021-08-01 API

* Add snapshot related APIs and properties to AKS 2021-08-01 swagger

* fix lint and spell checks

* fix lint and spell checks

* fix PrettierCheck

* Change some Nodepool to NodePool

* some changes according to ARM team's review comments

Co-authored-by: Charlie Li <[email protected]>

* fix tag typo to match tag convention (Azure#15683)

* add workload runtime to agent pool api (Azure#15726)

* add workload runtime to agent pool api

* reference example

* add custom words

* fix: workload runtime description (Azure#15782)

* fix: workload runtime description

* add wasmtime to custom words

* clarify single workload type per node

Co-authored-by: Matthew Christopher <[email protected]>

Co-authored-by: Matthew Christopher <[email protected]>

* fix typo in readme.python.md (Azure#15903)

* Add CreationData property to Agentpool level in 2021-08-01 API

* fix typos in readme.python.md

Co-authored-by: Charlie Li <[email protected]>

* merge recent custom-words.txt changes from main branch to resolve conflicts (Azure#15938)

* Add CreationData property to Agentpool level in 2021-08-01 API

* merge recent custom-words.txt changes from main branch to resolve conflicts

Co-authored-by: Charlie Li <[email protected]>

* pull custom-words.txt from main

* add a new word - NodePool

* add two more words

Co-authored-by: Super <[email protected]>
Co-authored-by: Li Ma <[email protected]>
Co-authored-by: Charlie Li <[email protected]>
Co-authored-by: Haitao Chen <[email protected]>
Co-authored-by: Qi Ni <[email protected]>
Co-authored-by: Ariel Silverman <[email protected]>
Co-authored-by: Ace Eldeib <[email protected]>
Co-authored-by: Matthew Christopher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heaths heaths heaths left review comments

@chradek chradek chradek approved these changes

@sadasant sadasant sadasant approved these changes

@bterlson bterlson Awaiting requested review from bterlson

@xirzec xirzec Awaiting requested review from xirzec

Assignees
No one assigned
Labels
KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve architects' review feedback for Key Vault
4 participants
@maorleger @sadasant @heaths @chradek