[KeyVault] - Bump Keys timeout to 90 minutes #15489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run js - keyvault-keys - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
maorleger
changed the title
sadasant
reviewed
Jun 1, 2021
| @@ -5,7 +5,7 @@ stages: | |||
| parameters: | |||
| PackageName: "@azure/keyvault-keys" | |||
| ServiceDirectory: keyvault | |||
| TimeoutInMinutes: 59 | |||
| TimeoutInMinutes: 90 | |||
There was a problem hiding this comment.
We’re working on Identity optimizations, but yep… let’s do this for now.
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Sep 9, 2021
Merge Dev-containerservice-microsoft.containerservice-2021-08-01 branch to main (Azure#15954) * Adds base for updating Microsoft.ContainerService from version stable/2021-07-01 to version 2021-08-01 * Updates readme * Updates API version in new specs and examples * add publicNetworkAccess property per network platform's request (Azure#15489) * add publicNetworkAccess per network platform's request * fix quota Co-authored-by: Li Ma <[email protected]> * update readme for 2021-08-01 sdk generation (Azure#15476) * update readme for sdk generation * update readme for sdk generation Co-authored-by: Charlie Li <[email protected]> * allow disabling of runcommand (Azure#15481) * allow disabling of runcommand * rename file * another rename * fix prittier check * fix stupid prettier check * change publicNetworkAccess to enum (Azure#15564) Co-authored-by: Li Ma <[email protected]> * Add CreationData property to Agentpool level in 2021-08-01 API (Azure#15563) * Add CreationData property to Agentpool level in 2021-08-01 API * fix json format * fix swagger spell check Co-authored-by: Charlie Li <[email protected]> * chore: add enableMultipleStandardLoadBalancers to loadBalancerProfile (Azure#15579) * Add snapshot related new APIs and properties to AKS 2021-08-01 swagger (Azure#15586) * Add CreationData property to Agentpool level in 2021-08-01 API * Add snapshot related APIs and properties to AKS 2021-08-01 swagger * fix lint and spell checks * fix lint and spell checks * fix PrettierCheck * Change some Nodepool to NodePool * some changes according to ARM team's review comments Co-authored-by: Charlie Li <[email protected]> * fix tag typo to match tag convention (Azure#15683) * add workload runtime to agent pool api (Azure#15726) * add workload runtime to agent pool api * reference example * add custom words * fix: workload runtime description (Azure#15782) * fix: workload runtime description * add wasmtime to custom words * clarify single workload type per node Co-authored-by: Matthew Christopher <[email protected]> Co-authored-by: Matthew Christopher <[email protected]> * fix typo in readme.python.md (Azure#15903) * Add CreationData property to Agentpool level in 2021-08-01 API * fix typos in readme.python.md Co-authored-by: Charlie Li <[email protected]> * merge recent custom-words.txt changes from main branch to resolve conflicts (Azure#15938) * Add CreationData property to Agentpool level in 2021-08-01 API * merge recent custom-words.txt changes from main branch to resolve conflicts Co-authored-by: Charlie Li <[email protected]> * pull custom-words.txt from main * add a new word - NodePool * add two more words Co-authored-by: Super <[email protected]> Co-authored-by: Li Ma <[email protected]> Co-authored-by: Charlie Li <[email protected]> Co-authored-by: Haitao Chen <[email protected]> Co-authored-by: Qi Ni <[email protected]> Co-authored-by: Ariel Silverman <[email protected]> Co-authored-by: Ace Eldeib <[email protected]> Co-authored-by: Matthew Christopher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyVault Keys tests have been timing out on Managed HSM. Looking at the runs, it does look like we are just on the edge of timing out but a few recent test additions have put us over the edge.
There are N Key Vault tests + M Managed HSM specific tests, so only the Managed HSM runs started timing out. I think bumping to 90 minutes is a reasonable strategy here as I didn't see any large changes in the trends.