[KeyVault] - Delete methods should ignore 404 (#15586)

## What - Ensure KeyVaultAccessControlClient delete* methods ignore 404s and return the raw response instead of the deleted model. - Update tests to use `supportsTracing` helper ## Why - This came up in a recent architecture discussion. By succeeding when trying to delete a role definition that was already deleted we make retries much easier for the consumer. - The `supportsTracing` helper was added after these tests were written and is much more comprehensive. Resolves #15580
Azure · Jun 8, 2021 · 2089881 · 2089881
1 parent 1948204
commit 2089881
Show file tree

Hide file tree

Showing 33 changed files with 1,252 additions and 1,065 deletions.
diff --git a/sdk/keyvault/keyvault-admin/CHANGELOG.md b/sdk/keyvault/keyvault-admin/CHANGELOG.md
@@ -18,6 +18,7 @@
 - Renamed `KeyVaultBeginSelectiveRestoreOptions` to `KeyVaultBeginSelectiveKeyRestoreOptions`.
 - Renamed `KeyVaultSelectiveRestoreOperationState` to `KeyVaultSelectiveKeyRestoreOperationState`.
 - Renamed `KeyVaultSelectiveRestoreResult` to `KeyVaultSelectiveKeyRestoreResult`.
+- `deleteRoleAssignment` and `deleteRoleDefinition` will no longer throw an exception when the resource no longer exist, and will return the raw response of the operation.
 
 ## 4.0.0-beta.3 (2021-04-06)
 

diff --git a/...cordings/node/aborting_keyvaultbackupclients_requests/recording_can_abort_beginrestore.js b/...cordings/node/aborting_keyvaultbackupclients_requests/recording_can_abort_beginrestore.js
diff --git a/...e/aborting_keyvaultbackupclients_requests/recording_can_abort_beginselectivekeyrestore.js b/...e/aborting_keyvaultbackupclients_requests/recording_can_abort_beginselectivekeyrestore.js
diff --git a/...ode/challenge_based_authentication_tests/recording_authentication_should_be_idempotent.js b/...ode/challenge_based_authentication_tests/recording_authentication_should_be_idempotent.js
diff --git a/...tication_tests/recording_once_authenticated_new_requests_should_not_authenticate_again.js b/...tication_tests/recording_once_authenticated_new_requests_should_not_authenticate_again.js