Update tsconfig to target es2017 #15545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xirzec
added
the
Client
ghost
added
Azure.Core
App Configuration
jeremymeng
reviewed
Jun 3, 2021
| "dom.iterable", | ||
| "esnext" | ||
| ], | ||
| "lib": ["dom", "dom.iterable", "esnext"], |
There was a problem hiding this comment.
The sample doesn't need a target?
There was a problem hiding this comment.
whoops this is a bug, I excluded 'samples' but this is sample-react one sec will fix
deyaaeldeen
approved these changes
Jun 3, 2021
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "target": "ES2015", | |||
| "target": "ES2017", | |||
There was a problem hiding this comment.
This tsconfig for dev-tool is noEmit, so does it even need a target (or module for that matter)?
There was a problem hiding this comment.
It's noEmit, but doesn't ts-node still use tsconfig to decide how to compile it so Node can interpret?
5 tasks
sadasant
pushed a commit
to sadasant/azure-sdk-for-js
that referenced
this pull request
Jun 21, 2021
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Aug 11, 2021
Web ant94 2021 02 01 attempt 2 (Azure#15548) * Adds base for updating Microsoft.Web from version stable/2021-01-15 to version 2021-02-01 * Updates readme * Updates API version in new specs and examples * Changes for api-version 2012-02-01 (Azure#15545) * Address PR comments - AppServiceCertificateOrders (Azure#15561) * Changes for api-version 2012-02-01 * Address PR comments - AppServiceCertificatesOrder * Fix spelling issue * Fix summary+description for GET siteseal * Add reseller to custom words * Make DedicatedHostCount R/W (Azure#15580) Co-authored-by: Chris Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will greatly simplify TS codegen by avoiding the need to polyfill async/await. Async functions are supported all the way down to Node 8, so this isn't a compat concern except for IE11.
This PR leaves in place existing downlevel targets for storage, cosmos, and core. If this change is merged, I will track getting those packages updated in an issue.