Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tsconfig to target es2017 for remaining packages #15640

Closed
2 of 5 tasks
xirzec opened this issue Jun 9, 2021 · 3 comments · Fixed by #15835
Closed
2 of 5 tasks

Update tsconfig to target es2017 for remaining packages #15640

xirzec opened this issue Jun 9, 2021 · 3 comments · Fixed by #15835
Assignees
@deyaaeldeen
Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Milestone
[2021] July

Comments

@xirzec
Copy link
Member

xirzec commented Jun 9, 2021 •
edited by jeremymeng
Loading

Now that #15545 is merged, we can set about cleaning up the remaining places where we are targeting old runtimes. Since this change is compatible with Node 8, the only difference will be dropping IE11 support.
@xirzec xirzec added the Client This issue points to a problem in the data-plane of the library. label Jun 9, 2021
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jun 9, 2021 •
edited
Loading

We already have Azure/autorest.typescript#1026 for the code gen that takes care of the purely generated packages the next time they get generated.

@jeremymeng jeremymeng mentioned this issue Jun 9, 2021
Closed
4 tasks
@ramya-rao-a ramya-rao-a added this to the [2021] July milestone Jun 10, 2021
@ramya-rao-a
Copy link
Contributor

@xirzec Can you log separate issues for Cosmos and Storage? We can use this one for the core packages

@xirzec
Copy link
Member Author

xirzec commented Jun 10, 2021

@xirzec Can you log separate issues for Cosmos and Storage? We can use this one for the core packages

Filed #15670 and #15671

This was referenced Jun 15, 2021
Merged
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@deyaaeldeen deyaaeldeen

Labels
Azure.Core Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Milestone
[2021] July
Development

Successfully merging a pull request may close this issue.

[Storage] Use ES2017 deyaaeldeen/azure-sdk-for-js
3 participants
@xirzec @deyaaeldeen @ramya-rao-a