Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tsconfig to target es2017 #15545

Merged
merged 5 commits into from
Jun 9, 2021
Merged

Update tsconfig to target es2017 #15545

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3a8fcac
Update tsonfig to target es2017
xirzec Jun 3, 2021
0a4a5c2
revert changes to sample tsconfig
xirzec Jun 3, 2021
494966c
update sample
xirzec Jun 3, 2021
bade8d7
Merge remote-tracking branch 'upstream/master' into updateTsTarget
xirzec Jun 4, 2021
28e47a2
Merge remote-tracking branch 'upstream/master' into updateTsTarget
xirzec Jun 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/tools/dev-tool/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"compilerOptions": {
"target": "ES2015",
"target": "ES2017",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tsconfig for dev-tool is noEmit, so does it even need a target (or module for that matter)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's noEmit, but doesn't ts-node still use tsconfig to decide how to compile it so Node can interpret?

"module": "commonjs",
"moduleResolution": "node",
"noEmit": true,
Expand Down
2 changes: 1 addition & 1 deletion common/tools/eslint-plugin-azure-sdk/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"pretty": true,
"removeComments": true,
"strict": true,
"target": "es2016",
"target": "es2017",
"types": ["node"],
"sourceMap": true,
"resolveJsonModule": true
Expand Down
11 changes: 2 additions & 9 deletions sdk/appconfiguration/app-configuration/sample-react/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,6 @@
{
"compilerOptions": {
"target": "es5",
"lib": [
"dom",
"dom.iterable",
"esnext"
],
"lib": ["dom", "dom.iterable", "esnext"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample doesn't need a target?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops this is a bug, I excluded 'samples' but this is sample-react one sec will fix

"allowJs": true,
"skipLibCheck": true,
"esModuleInterop": true,
Expand All @@ -20,7 +15,5 @@
"noEmit": true,
"jsx": "react-jsx"
},
"include": [
"src"
]
"include": ["src"]
}
1 change: 0 additions & 1 deletion sdk/core/core-amqp/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"extends": "../../../tsconfig.package",
"compilerOptions": {
"target": "es6",
"outDir": "./dist-esm",
"declarationDir": "./types",
"resolveJsonModule": true
Expand Down
1 change: 0 additions & 1 deletion sdk/digitaltwins/digital-twins-core/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
"extends": "../../../tsconfig.package",
"compilerOptions": {
"strict": true,
"target": "es5",
"sourceMap": true,
"lib": ["es6", "dom"],
"declaration": true,
Expand Down
1 change: 0 additions & 1 deletion sdk/identity/identity/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
{
"extends": "../../../tsconfig.package",
"compilerOptions": {
"target": "es6",
"lib": ["DOM"],
"declarationDir": "./types",
"outDir": "./dist-esm",
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"compilerOptions": {
"target": "ES2015",
"target": "ES2017",
"module": "commonjs",
"lib": [],
"declaration": true,
Expand Down