[identity] Unpin msal-common and msal-browser dependencies #15338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
sadasant
approved these changes
May 19, 2021
HarshaNalluru
approved these changes
May 19, 2021
There was a problem hiding this comment.
Our browser tests don't care about the msal-browser since we rely on the CSC. We need to figure out a way to test the IBC with our SDKs soon.
Coming to the node tests, as long as msal doesn't drastically change the auth mechanism/calls, nothing should break the unit tests. Even if we see any such disruptive changes, we'd try to have mock calls in the recorder itself as much as possible to make it less disruptive.
|
#15339 should fix the node 16 failure. |
|
Oh look at that... merge conflicts on the lock file... what a surprise... |
ramya-rao-a
approved these changes
May 20, 2021
|
Hello @witemple-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Nov 9, 2022
Adding resourceconnector - Appliance GA API version (Azure#20681) * Adding resourceconnector - appliance GA API verson * Update swagger PR to add ArtifactURL and Another SSHKey type - ScopesAccessKey * Commiting previous API Version 2022-04-15-preview * Commiting latest API Version 2022-10-27 * Update to v3 types: * Adding words to custom-words.txt * run prettier check * Use v3 for appliance resource type too * resolve merge conflicts in custom words.txt * add in readmes * Add blockchain to latest profile * Add additional types * track2 modify eventhub readme.go.md (Azure#15338) * track2 modify operationalinsights readme.go.md (Azure#15354) * track2 modify security readme.go.md (Azure#15357) * track2 modify eventgrid readme.go.md (Azure#15358) * [Hub Generated] Public private branch 'dev-azure-kusto-Microsoft.Kusto-2021-08-27' (Azure#15905) * Adds base for updating Microsoft.Kusto from version stable/2021-01-01 to version 2021-08-27 * Updates readme * Updates API version in new specs and examples * Swagger changes * it1 * hh * it2 * it3 * it5 * it6 * it7 * readme * it10 * it11 * it11 * it 12 * it 13 * prettier * python * allowedIpRangeList - remove default * bassel changes * checkNameAvailability * fix lint * checkName * fix * managedPrivate check name * prettier * Update readme.python.md * add attached enum * Dor comments * fix description * readOnly Co-authored-by: msyyc <[email protected]> * update the format to int64 for creationtimestamp and expirationtimestamp * Updating Delete example to include location header for 202 response * fix header in delete example Co-authored-by: Mark Cowlishaw <[email protected]> Co-authored-by: JiahuiPeng <[email protected]> Co-authored-by: hila levi <[email protected]> Co-authored-by: msyyc <[email protected]> Co-authored-by: Aditi Malladi <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency analysis was showing that we are pulling in multiple copies of
msal-commonin the install footprint of identity. We were minor-pinned to msal-common 4.0.x (latest is 4.3.0) and hard pinned to a specific version of msal-browser. However, msal-browser itself carries a dependency on msal-common, and so our install footprint is currently pulling in three different versions of msal-common. Letting these dependencies roll forward within the same major version should help.CC @HarshaNalluru @sadasant -- is this something that will give us recorder pain?