Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename beginSelectiveRestore to beginSelectiveKeyRestore #15357

Closed
heaths opened this issue May 20, 2021 · 0 comments · Fixed by #15354
Closed

Rename beginSelectiveRestore to beginSelectiveKeyRestore #15357

heaths opened this issue May 20, 2021 · 0 comments · Fixed by #15354
Assignees
@sadasant
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Milestone
[2021] June

Comments

@heaths
Copy link
Member

heaths commented May 20, 2021

After #15210, rename the method as well. Probably resolved by PR #15354
@heaths heaths added Client This issue points to a problem in the data-plane of the library. KeyVault labels May 20, 2021
@heaths heaths added this to the [2021] June milestone May 20, 2021
@sadasant sadasant mentioned this issue May 20, 2021
Merged
@ghost ghost closed this as completed in #15354 May 21, 2021
ghost pushed a commit that referenced this issue May 21, 2021
@sadasant
[Key Vault Admin] Selective Restore to Selective Key Restore (#15354)
56b36fb 
This PR changes all the references to `/selectiverestore/ig` to `selectiveKeyRestore` (I did it manually, don't worry). I also copied the selective restore return type into a new type: `KeyVaultSelectiveKeyRestoreResult`.

Feedback appreciated 👍

Fixes #15357
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Nov 9, 2022
@markcowl @Alancere
@hilalevi170 @msyyc
CodeGen from PR 20681 in Azure/azure-rest-api-specs
f1294dd 
Adding resourceconnector - Appliance GA API version (Azure#20681)

* Adding resourceconnector - appliance GA API verson

* Update swagger PR to add ArtifactURL and Another SSHKey type - ScopesAccessKey

* Commiting previous API Version 2022-04-15-preview

* Commiting latest API Version 2022-10-27

* Update to v3 types:

* Adding words to custom-words.txt

* run prettier check

* Use v3 for appliance resource type too

* resolve merge conflicts in custom words.txt

* add in readmes

* Add blockchain to latest profile

* Add additional types

* track2 modify eventhub readme.go.md (Azure#15338)

* track2 modify operationalinsights readme.go.md (Azure#15354)

* track2 modify security readme.go.md (Azure#15357)

* track2 modify eventgrid readme.go.md (Azure#15358)

* [Hub Generated] Public private branch 'dev-azure-kusto-Microsoft.Kusto-2021-08-27' (Azure#15905)

* Adds base for updating Microsoft.Kusto from version stable/2021-01-01 to version 2021-08-27

* Updates readme

* Updates API version in new specs and examples

* Swagger changes

* it1

* hh

* it2

* it3

* it5

* it6

* it7

* readme

* it10

* it11

* it11

* it 12

* it 13

* prettier

* python

* allowedIpRangeList - remove default

* bassel changes

* checkNameAvailability

* fix lint

* checkName

* fix

* managedPrivate check name

* prettier

* Update readme.python.md

* add attached enum

* Dor comments

* fix description

* readOnly

Co-authored-by: msyyc <[email protected]>

* update the format to int64 for creationtimestamp and expirationtimestamp

* Updating Delete example to include location header for 202 response

* fix header in delete example

Co-authored-by: Mark Cowlishaw <[email protected]>
Co-authored-by: JiahuiPeng <[email protected]>
Co-authored-by: hila levi <[email protected]>
Co-authored-by: msyyc <[email protected]>
Co-authored-by: Aditi Malladi <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sadasant sadasant

Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Milestone
[2021] June
Development

Successfully merging a pull request may close this issue.

[Key Vault Admin] Selective Restore to Selective Key Restore sadasant/azure-sdk-for-js
2 participants
@sadasant @heaths