Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ref doc] Not all core packages are under Core node #15905

Closed
jeremymeng opened this issue Jun 22, 2021 · 4 comments
Closed

[ref doc] Not all core packages are under Core node #15905

jeremymeng opened this issue Jun 22, 2021 · 4 comments
Assignees
@ramya-rao-a
Labels
Client This issue points to a problem in the data-plane of the library. Docs
Milestone
[2021] July

Comments

@jeremymeng
Copy link
Member

Latest: https://docs.microsoft.com/en-us/javascript/api/overview/azure/core-http-readme?view=azure-node-latest

image.png

Preview: https://docs.microsoft.com/en-us/javascript/api/overview/azure/core-http-readme?view=azure-node-preview

image.png
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. Docs labels Jun 22, 2021
@ramya-rao-a
Copy link
Contributor

@danieljurek This goes back to the discussion of whether or not we should have a "Core" node at all. All other nodes map to a particular Azure service and my recommendation is to not have a node for "Core" and instead re-use the "Others" node.

@maggiepint Do you have any inputs here?

@maggiepint
Copy link
Contributor

This page is fairly low traffic, and about half of the traffic comes from organic search. In that context, since people aren't using the navigation to arrive there - I wouldn't be to terribly worried about where you put it either way.

@ramya-rao-a ramya-rao-a self-assigned this Jun 24, 2021
@ramya-rao-a ramya-rao-a added this to the [2021] July milestone Jun 24, 2021
@ramya-rao-a ramya-rao-a mentioned this issue Jun 24, 2021
Merged
@ramya-rao-a
Copy link
Contributor

Thanks @maggiepint

@danieljurek Please take a look at MicrosoftDocs/azure-docs-sdk-node#1253 where I remove the Core node altogether

ghost pushed a commit to MicrosoftDocs/azure-docs-sdk-node that referenced this issue Jun 24, 2021
@ramya-rao-a
Remove the Core node (#1253)
786097f 
Removing the "Core" node from the TOC as per discussions in Azure/azure-sdk-for-js#15905 as it does not correspond to any Azure service like the other nodes. Packages under it should start appearing under "Other"
@danieljurek
Copy link
Member

@ramya-rao-a, I approved and merged this change. Thanks!

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Nov 9, 2022
@markcowl @Alancere
@hilalevi170 @msyyc
CodeGen from PR 20681 in Azure/azure-rest-api-specs
f1294dd 
Adding resourceconnector - Appliance GA API version (Azure#20681)

* Adding resourceconnector - appliance GA API verson

* Update swagger PR to add ArtifactURL and Another SSHKey type - ScopesAccessKey

* Commiting previous API Version 2022-04-15-preview

* Commiting latest API Version 2022-10-27

* Update to v3 types:

* Adding words to custom-words.txt

* run prettier check

* Use v3 for appliance resource type too

* resolve merge conflicts in custom words.txt

* add in readmes

* Add blockchain to latest profile

* Add additional types

* track2 modify eventhub readme.go.md (Azure#15338)

* track2 modify operationalinsights readme.go.md (Azure#15354)

* track2 modify security readme.go.md (Azure#15357)

* track2 modify eventgrid readme.go.md (Azure#15358)

* [Hub Generated] Public private branch 'dev-azure-kusto-Microsoft.Kusto-2021-08-27' (Azure#15905)

* Adds base for updating Microsoft.Kusto from version stable/2021-01-01 to version 2021-08-27

* Updates readme

* Updates API version in new specs and examples

* Swagger changes

* it1

* hh

* it2

* it3

* it5

* it6

* it7

* readme

* it10

* it11

* it11

* it 12

* it 13

* prettier

* python

* allowedIpRangeList - remove default

* bassel changes

* checkNameAvailability

* fix lint

* checkName

* fix

* managedPrivate check name

* prettier

* Update readme.python.md

* add attached enum

* Dor comments

* fix description

* readOnly

Co-authored-by: msyyc <[email protected]>

* update the format to int64 for creationtimestamp and expirationtimestamp

* Updating Delete example to include location header for 202 response

* fix header in delete example

Co-authored-by: Mark Cowlishaw <[email protected]>
Co-authored-by: JiahuiPeng <[email protected]>
Co-authored-by: hila levi <[email protected]>
Co-authored-by: msyyc <[email protected]>
Co-authored-by: Aditi Malladi <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
Client This issue points to a problem in the data-plane of the library. Docs
Projects
None yet
Milestone
[2021] July
Development

No branches or pull requests
4 participants
@danieljurek @maggiepint @jeremymeng @ramya-rao-a