Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] Use Eslint plugin #11472

Merged
merged 3 commits into from
Sep 27, 2020

Conversation

deyaaeldeen
Copy link
Member

@deyaaeldeen deyaaeldeen commented Sep 24, 2020

We are planning on removing .eslintrc.old.json file and this PR removes its use in storage packages. See #11256.

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Sep 24, 2020
Copy link
Contributor

@ramya-rao-a ramya-rao-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wait for approval from anyone in the Storage team

@ljian3377
Copy link
Member

With this merged, do we have to fix all the linting errors if any?

@ramya-rao-a
Copy link
Contributor

With this merged, do we have to fix all the linting errors if any?

The output from the linter will continue to be published to the html file as listed in the lint script in the package.json file.
#10782 is tracking the work required to fix the linting errors.
Once all errors are fixed, we will remove the output to html file so that any future linting errors will break the build in the PR

@ramya-rao-a ramya-rao-a merged commit 405d009 into Azure:master Sep 27, 2020
@deyaaeldeen deyaaeldeen deleted the storage-use-eslint-plugin branch September 28, 2020 14:24
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Nov 11, 2020
Dev containerservice microsoft.container service 2020 11 01 (Azure#11588)

* Adds base for updating Microsoft.ContainerService from version stable/2020-09-01 to version 2020-11-01

* Updates readme

* Updates API version in new specs and examples

* add autoupgradeprofile to 2020-11-01 (Azure#11363)

* add autoupgradeprofile

* add autoupgrader profile to mc

* format change

Co-authored-by: Xiahe Liu <[email protected]>

* add pod subnet id on agentpool (Azure#11310)

* aks: add pod identity profile spec (Azure#11366)

* add private dns zone property in 2020-11-01 (Azure#11311)

Co-authored-by: Li Ma <[email protected]>

* Remove invalid pattern and adjust description (Azure#11312)

* aks: fix pod identity profile field names (Azure#11484)

* aks: add missing `podIdentityProfile.enabled` field

* aks: typo

* add non upgrade channel (Azure#11492)

Co-authored-by: Xiahe Liu <[email protected]>

* Make identityProfile mutable (Azure#11458)

* Add KubeletConfig and LinuxOSConfig specs (Azure#11490)

* aks: update readme tag for 1101 (Azure#11472)

* aks: update readme tag

* aks: add `2020-11-01-only`

* resovle merge conlicts to master, adding recent master change to dev branch (Azure#11604)

Co-authored-by: Xiahe Liu <[email protected]>

Co-authored-by: Xiahe Liu <[email protected]>
Co-authored-by: Paul Miller <[email protected]>
Co-authored-by: hbc <[email protected]>
Co-authored-by: Super <[email protected]>
Co-authored-by: Li Ma <[email protected]>
Co-authored-by: Qingchuan Hao <[email protected]>
Co-authored-by: Tongyao Si <[email protected]>
Co-authored-by: Bo Wang <[email protected]>
Co-authored-by: Phoenix He <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants